fix(dev-lead): centralize git identity; apply to fix-ci & fix-reviews

[don-petry]

Summary

Move the setup_git_identity helper to a shared lib and call it from all three dev-lead entry-point scripts. Previously, only dev-lead-fix-issue.sh configured git before committing, so review and CI intents failed on GitHub-hosted runners with fatal: empty ident name.

Observed failure

bmad-bgreat-suite#203, triggered by pull_request_review (handled by dev-lead-fix-reviews.sh):

##[error]git commit failed — check git identity configuration on the runner
##[error]Process completed with exit code 1.

dev-lead-fix-reviews.sh and dev-lead-fix-ci.sh both call git commit but neither configured user.name/user.email. The earlier fix in PR #326 only patched the issue intent.

Changes

• New: scripts/lib/git-identity.sh — shared setup_git_identity helper.
• Refactor: dev-lead-fix-issue.sh drops the inline duplicate; sources the shared lib.
• Fix: dev-lead-fix-ci.sh sources the shared lib; calls setup_git_identity before git commit.
• Fix: dev-lead-fix-reviews.sh sources the shared lib; calls setup_git_identity before git commit.

Test plan

• Merge.
• Trigger a dev-lead fix-reviews intent (e.g., re-request review on an existing PR) and confirm the commit step succeeds.
• Trigger a dev-lead fix-ci intent (e.g., push a commit that fails CI) and confirm the commit step succeeds.
• No regression on fix-issue (already worked).

🤖 Generated with Claude Code

[coderabbitai]

Warning

Review limit reached

@don-petry, we couldn't start this review because you've used your available PR reviews for now.

Your plan currently allows 1 review/hour. Refill in 49 minutes and 57 seconds.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more review capacity refills, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than trial, open-source, and free plans. In all cases, review capacity refills continuously over time.

Please see our FAQ for further information.

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 958af2c8-e183-4c07-ba0c-5f00e724f59e

📥 Commits

Reviewing files that changed from the base of the PR and between 4f9cdda and 15b82ba.

📒 Files selected for processing (4)

• scripts/dev-lead-fix-ci.sh
• scripts/dev-lead-fix-issue.sh
• scripts/dev-lead-fix-reviews.sh
• scripts/lib/git-identity.sh

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix/dev-lead-git-identity-shared

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[don-petry]

Dev-Lead — rate-limited (intent: review-changes)

PR: #379
The retry cron will re-attempt automatically.

[don-petry]

Note

@don-petry I received your request but all AI engines are currently rate-limited. I'll retry automatically once the rate limit clears.
Rate limit resets at: unknown

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[don-petry]

Dev-Lead — rate-limited (intent: fix-bot-comment)

PR: #379
Please re-trigger manually (re-mention @dev-lead) when the rate limit clears — the original request cannot be reconstructed automatically.

[don-petry]

Dev-Lead — rate-limited (intent: on-mention)

PR: #379
Please re-trigger manually (re-mention @dev-lead) when the rate limit clears — the original request cannot be reconstructed automatically.

[don-petry]

Note

@don-petry I received your request but all AI engines are currently rate-limited. Please re-mention @dev-lead when the rate limit clears (estimated: unknown) — I cannot reconstruct the original instruction automatically.

[donpetry-bot]

Automated review — APPROVED ✓

Risk: LOW
Reviewed commit: 15b82baf1d130330a8c9ef2e9cacf3014c6f7676
Review mode: triage-approved (single reviewer)

Summary

Small, focused fix that centralizes setup_git_identity into scripts/lib/git-identity.sh and ensures dev-lead-fix-ci.sh and dev-lead-fix-reviews.sh call it before git commit — addressing the fatal: empty ident name failures observed in bmad-bgreat-suite#203 (2026-05-23). The earlier fix in #326 only patched the issue intent path; this PR closes the gap for the review and CI intents.

Linked issue analysis

No linked issue reference, but the PR body documents the observed failure and points to bmad-bgreat-suite#203 as the symptom. Root cause and remediation are clearly described.

Findings

• Refactor is behavior-preserving. The shared setup_git_identity body in scripts/lib/git-identity.sh is byte-identical to the inline version it replaces in dev-lead-fix-issue.sh (same BOT_USER default, same gh api users/${bot} lookup, same noreply-vs-legacy fallback, same git config user.name).
• All git commit paths in dev-lead scripts are now guarded. Verified call ordering: fix-issue calls setup_git_identity (line 74) before the commit on line 116; fix-ci and fix-reviews now call it immediately before their respective commits inside the has_uncommitted branch.
• Sourcing is correct. All three entry-point scripts source lib/git-identity.sh at the top via $(dirname "$0"), matching the existing engine.sh sourcing pattern.
• No new external surface. No new dependencies, no auth/secret handling changes, no schema/migration impact, no workflow file changes. Identity is configured with git config (local, not --global), appropriate for ephemeral runners.
• Nit (non-blocking): release-notes.sh:237 also runs git commit and is not covered by this PR — out of scope (different code path, different invocation context), but worth keeping in mind if a similar failure surfaces there.

CI status

All 27 checks completed successfully or skipped appropriately: Lint, ShellCheck, bats, validate-agent-profiles, gh-aw-compile, Compile agentic workflows, Agent Security Scan, Secret scan (gitleaks), CodeQL (×2), SonarCloud, AgentShield, unit-tests, Dependency audit, and Dev-Lead dispatch all green. SonarCloud Quality Gate passed (0 new issues).

---

Reviewed automatically by the PR-review agent (single-reviewer mode: opus 4.7). Reply if you need a human review.

[Copilot]

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

[gemini-code-assist]

Code Review

This pull request centralizes the setup_git_identity function into a new shared library, scripts/lib/git-identity.sh, and updates the CI scripts to use it. This change ensures that git identity is correctly configured before commits, preventing failures on GitHub-hosted runners. Feedback was provided to optimize the function by checking for existing git configuration before making network calls to the GitHub API to avoid potential rate limiting.

[gemini-code-assist]

The setup_git_identity function performs a network request via gh api every time it is called. While these scripts are typically entry points, they may be called multiple times in a single environment (e.g., during local testing or if multiple intents are processed in sequence). Adding a check to see if the git identity is already configured can avoid unnecessary API calls and potential rate limiting.

Suggested change

	setup_git_identity() {
	local bot="${BOT_USER:-donpetry-bot}"
	local bot_id
	bot_id=$(gh api "users/${bot}" --jq '.id' 2>/dev/null || echo "")
	if [ -n "$bot_id" ]; then
	git config user.email "${bot_id}+${bot}@users.noreply.github.com"
	else
	git config user.email "${bot}@users.noreply.github.com"
	fi
	git config user.name "$bot"
	}
	setup_git_identity() {
	# Skip if identity is already configured (e.g. local dev or repeated call)
	if git config user.email >/dev/null 2>&1 && git config user.name >/dev/null 2>&1; then
	return 0
	fi
	local bot="${BOT_USER:-donpetry-bot}"
	local bot_id
	bot_id=$(gh api "users/${bot}" --jq '.id' 2>/dev/null || echo "")
	if [ -n "$bot_id" ]; then
	git config user.email "${bot_id}+${bot}@users.noreply.github.com"
	else
	git config user.email "${bot}@users.noreply.github.com"
	fi
	git config user.name "$bot"
	}

[don-petry]

Dev-Lead — rate-limited (intent: fix-reviews)

PR: #379
The retry cron will re-attempt automatically.

[donpetry-bot]

@don-petry assigned me as reviewer — starting a fresh review now. Results will appear in a few minutes.