Skip to content

bug: dev-lead-fix-reviews.sh fails with git identity error on all non-.github-private repos #368

Description

@don-petry

Summary

scripts/dev-lead-fix-reviews.sh fails with:

git commit failed — check git identity configuration on the runner

when the human, fix-reviews, or fix-bot-comment intent attempts to commit to any repo other than .github-private itself.

Root cause

commit_and_push() calls git commit without first setting git config user.name / git config user.email. The actions/checkout step in the reusable workflow sets local git identity for the repository it checks out (.github-private), but when the script operates on a cloned target repo (e.g. petry-projects/broodly) in a separate workspace directory, that local identity is not present.

This works accidentally for .github-private because the reusable workflow's own actions/checkout covers the same repo the script is committing to.

Affected repos

All repos that call dev-lead-reusable.yml: TalkTerm, broodly, markets, ContentTwin, bmad-bgreat-suite, and any future repos.

Reproduction

Trigger the dev-lead human intent on any PR in one of the affected repos (e.g. post @dev-lead fix all reviewer comments). The run completes but exits 1 on git commit.

Failing run examples (all from 2026-05-23T02:02-02:06Z):

Fix

In commit_and_push(), set git identity before the commit:

git config user.email "41898282+github-actions[bot]@users.noreply.github.com"
git config user.name "github-actions[bot]"
git commit -m "$commit_msg" || { ...

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugBug reports

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions