Skip to content

fix(compliance): add CLAUDE.md and dependabot.yml - #152

Merged
don-petry merged 77 commits into
mainfrom
claude/issue-261-compliance
Jun 8, 2026
Merged

fix(compliance): add CLAUDE.md and dependabot.yml#152
don-petry merged 77 commits into
mainfrom
claude/issue-261-compliance

Conversation

@don-petry

@don-petry don-petry commented May 12, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Adds CLAUDE.md with required AGENTS.md reference (fixes claude-md-missing-agents-ref)
  • Adds .github/dependabot.yml with github-actions ecosystem, security and dependencies labels (fixes missing-github-actions-ecosystem, missing-security-label, missing-dependencies-label)

Compliance findings addressed

Finding Severity Status
claude-md-missing-agents-ref error ✅ Fixed
missing-github-actions-ecosystem error ✅ Fixed
missing-security-label warning ✅ Fixed
missing-dependencies-label warning ✅ Fixed

Remaining findings requiring human action

The following findings for .github-private require elevated permissions not available to this agent:

  • Workflow files (missing-ci.yml, missing-pr-review-mention.yml, non-stub-auto-rebase.yml, non-stub-dependabot-automerge.yml, non-stub-agent-shield.yml) — require workflows write permission
  • SHA pinning in workflow files (unpinned-actions-*) — require workflows write permission
  • Repository settings (allow_auto_merge, delete_branch_on_merge, check-suite-auto-trigger-*) — run bash scripts/apply-repo-settings.sh .github-private with admin credentials
  • Secret scanning settings — run bash scripts/apply-repo-settings.sh .github-private

Part of petry-projects/.github#261

Generated with Claude Code

Summary by CodeRabbit

  • Chores
    • Updated internal project documentation and configuration guidelines.

Review Change Stack

Copilot AI review requested due to automatic review settings May 12, 2026 19:12
@coderabbitai

coderabbitai Bot commented May 12, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@don-petry, we couldn't start this review because you've used your available PR reviews for now.

Your plan currently allows 1 review/hour. Refill in 59 minutes and 49 seconds.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more review capacity refills, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than trial, open-source, and free plans. In all cases, review capacity refills continuously over time.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 169c921b-39c2-486f-90a4-19ec36942e0b

📥 Commits

Reviewing files that changed from the base of the PR and between b34e302 and 2508628.

📒 Files selected for processing (2)
  • .github/dependabot.yml
  • CLAUDE.md
📝 Walkthrough

Walkthrough

Added CLAUDE.md with repository-specific Claude Code guidance, directing agents to org-wide standards in AGENTS.md, defining the .github-private repository's purpose and structure, and establishing operational rules for shell script editing and GitHub Actions SHA pinning.

Changes

Repository Development Guidance for Claude Code

Layer / File(s) Summary
Claude Code repository guidance
CLAUDE.md
New file establishes development standards for Claude Code usage in .github-private, references org-wide AGENTS.md standards, documents repository contents (agents, scripts, workflows), and defines operational rules: shell scripts must pass shellcheck and GitHub Actions must pin SHAs via GitHub API lookup.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related issues

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Title check ⚠️ Warning The title references both CLAUDE.md and dependabot.yml, but the raw summary only documents CLAUDE.md changes; dependabot.yml is not mentioned or summarized. Either update the title to reflect only the documented changes (e.g., 'fix(compliance): add CLAUDE.md'), or confirm that dependabot.yml changes are included and ensure they are documented in the summary.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch claude/issue-261-compliance

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a Dependabot configuration for GitHub Actions and a CLAUDE.md file to provide context and guidelines for Claude Code. The review feedback suggests bundling Dependabot updates into groups to reduce noise, expanding the repository purpose section to include missing directories, and adding a commands section for common tasks like shell script linting.

Comment thread .github/dependabot.yml
Comment thread CLAUDE.md
Comment thread CLAUDE.md

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds missing compliance artifacts for this org-level .github-private repository: Claude Code instructions and Dependabot configuration for GitHub Actions updates.

Changes:

  • Add CLAUDE.md with a reference to AGENTS.md and repository-specific guidance.
  • Add .github/dependabot.yml to enable weekly GitHub Actions dependency updates with security and dependencies labels.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
CLAUDE.md Adds Claude Code repo instructions and points contributors to AGENTS.md standards.
.github/dependabot.yml Enables Dependabot for the github-actions ecosystem with standard labels.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread CLAUDE.md Outdated
coderabbitai[bot]
coderabbitai Bot previously approved these changes May 12, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Auto-rebase failed — merge conflict — this branch has conflicts with main that must be resolved manually.

Please resolve the conflicts and push:

git fetch origin
git merge origin/main
# resolve conflicts, then:
git add .
git commit
git push

@donpetry-bot

donpetry-bot commented May 14, 2026

Copy link
Copy Markdown
Contributor
Superseded by automated re-review at 881d6da3448bdc81863695ad5150975e4723e9d2 — click to expand prior review.

Review — fix requested (cycle 1/3)

The automated review identified the following issues. Please address each one:

Findings to fix

[Findings would be inserted here]

Additional tasks

  1. Resolve all unresolved review thread comments from other reviewers
  2. Ensure all CI checks pass after your changes
  3. Rebase on the target branch if behind
  4. Do NOT modify files unrelated to the findings above

The review cascade will automatically re-review after new commits are pushed.

@donpetry-bot

donpetry-bot commented May 14, 2026

Copy link
Copy Markdown
Contributor
Superseded by automated re-review at 5e0577b6e6511b9b3ebe4d5b2bbee79f622d5f5a — click to expand prior review.

Review — fix requested (cycle 2/3)

The automated review identified the following issues. Please address each one:

Findings to fix

[Findings would be inserted here]

Additional tasks

  1. Resolve all unresolved review thread comments from other reviewers
  2. Ensure all CI checks pass after your changes
  3. Rebase on the target branch if behind
  4. Do NOT modify files unrelated to the findings above

The review cascade will automatically re-review after new commits are pushed.

@donpetry-bot

donpetry-bot commented May 14, 2026

Copy link
Copy Markdown
Contributor
Superseded by automated re-review at 02c9a4b3b4f3f22f3c54920b101db0ed96d913a6 — click to expand prior review.

Review — fix requested (cycle 3/3)

The automated review identified the following issues. Please address each one:

Findings to fix

[Findings would be inserted here]

Additional tasks

  1. Resolve all unresolved review thread comments from other reviewers
  2. Ensure all CI checks pass after your changes
  3. Rebase on the target branch if behind
  4. Do NOT modify files unrelated to the findings above

The review cascade will automatically re-review after new commits are pushed.

@don-petry
don-petry force-pushed the claude/issue-261-compliance branch 3 times, most recently from 4ade6da to 1268491 Compare May 15, 2026 16:51
don-petry pushed a commit that referenced this pull request May 15, 2026
- Add groups bundling to dependabot.yml for GitHub Actions updates
- Add prompts/ and frameworks/ directories to CLAUDE.md Repository Purpose
- Correct inaccurate "non-stub" claim; clarify which workflows are thin callers
- Add Commands section with shellcheck lint command

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@don-petry

Copy link
Copy Markdown
Collaborator Author

Auto-rebase failed — merge conflict — this branch has conflicts with main that must be resolved.

Claude will attempt to resolve this automatically. If it cannot, a follow-up comment will explain what needs manual attention.

To resolve manually instead:

git fetch origin
git merge origin/main
# resolve conflicts, then:
git add .
git commit
git push

@don-petry

Copy link
Copy Markdown
Collaborator Author

Auto-rebase failed — merge conflict — this branch has conflicts with main that must be resolved.

Claude will attempt to resolve this automatically. If it cannot, a follow-up comment will explain what needs manual attention.

To resolve manually instead:

git fetch origin
git merge origin/main
# resolve conflicts, then:
git add .
git commit
git push

@don-petry

Copy link
Copy Markdown
Collaborator Author

Auto-rebase failed — merge conflict — this branch has conflicts with main that must be resolved.

Claude will attempt to resolve this automatically. If it cannot, a follow-up comment will explain what needs manual attention.

To resolve manually instead:

git fetch origin
git merge origin/main
# resolve conflicts, then:
git add .
git commit
git push

@don-petry

Copy link
Copy Markdown
Collaborator Author

Auto-rebase failed — merge conflict — this branch has conflicts with main that must be resolved.

Claude will attempt to resolve this automatically. If it cannot, a follow-up comment will explain what needs manual attention.

To resolve manually instead:

git fetch origin
git merge origin/main
# resolve conflicts, then:
git add .
git commit
git push

@don-petry

Copy link
Copy Markdown
Collaborator Author

Auto-rebase failed — merge conflict — this branch has conflicts with main that must be resolved.

Claude will attempt to resolve this automatically. If it cannot, a follow-up comment will explain what needs manual attention.

To resolve manually instead:

git fetch origin
git merge origin/main
# resolve conflicts, then:
git add .
git commit
git push

@don-petry

Copy link
Copy Markdown
Collaborator Author

Auto-rebase failed — merge conflict — this branch has conflicts with main that must be resolved.

Claude will attempt to resolve this automatically. If it cannot, a follow-up comment will explain what needs manual attention.

To resolve manually instead:

git fetch origin
git merge origin/main
# resolve conflicts, then:
git add .
git commit
git push

@don-petry

Copy link
Copy Markdown
Collaborator Author

Auto-rebase failed — merge conflict — this branch has conflicts with main that must be resolved.

Claude will attempt to resolve this automatically. If it cannot, a follow-up comment will explain what needs manual attention.

To resolve manually instead:

git fetch origin
git merge origin/main
# resolve conflicts, then:
git add .
git commit
git push

@don-petry

Copy link
Copy Markdown
Collaborator Author

Auto-rebase failed — merge conflict — this branch has conflicts with main that must be resolved.

Claude will attempt to resolve this automatically. If it cannot, a follow-up comment will explain what needs manual attention.

To resolve manually instead:

git fetch origin
git merge origin/main
# resolve conflicts, then:
git add .
git commit
git push

@don-petry

Copy link
Copy Markdown
Collaborator Author

@donpetry-bot review

@donpetry-bot

Copy link
Copy Markdown
Contributor

@don-petry I'm on it — starting a fresh review now. Results will appear in a few minutes.

@don-petry
don-petry disabled auto-merge June 7, 2026 22:52
@don-petry
don-petry enabled auto-merge (squash) June 7, 2026 22:53
@don-petry don-petry removed the needs-human-review Flagged by automated PR review agent label Jun 7, 2026
@don-petry
don-petry disabled auto-merge June 7, 2026 23:01
@don-petry
don-petry enabled auto-merge (squash) June 7, 2026 23:03
@sonarqubecloud

sonarqubecloud Bot commented Jun 7, 2026

Copy link
Copy Markdown

@don-petry
don-petry disabled auto-merge June 7, 2026 23:04
@don-petry
don-petry enabled auto-merge (squash) June 7, 2026 23:05
@don-petry
don-petry disabled auto-merge June 7, 2026 23:05
@don-petry

Copy link
Copy Markdown
Collaborator Author

Dev-Lead — fix-bot-comment (no-changes)

Agent reasoning
Issues addressed: 0
Files changed: none
Skipped (informational): 0
No actionable issues found. Quality Gate passed with zero findings.
No open review threads from sonarqubecloud[bot] to resolve.
No Tier 1 CI or review blockers present.
PR is in a clean, unblocked state.
```

@don-petry
don-petry enabled auto-merge (squash) June 7, 2026 23:06
@don-petry

Copy link
Copy Markdown
Collaborator Author

@donpetry-bot review

@donpetry-bot

Copy link
Copy Markdown
Contributor

@don-petry I'm on it — starting a fresh review now. Results will appear in a few minutes.

@donpetry-bot donpetry-bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review — APPROVED ✓

Risk: LOW
Reviewed commit: 02c9a4b3b4f3f22f3c54920b101db0ed96d913a6
Review mode: triage-approved (single reviewer)

Summary

Small compliance PR (2 files, +44/-11): adds CLAUDE.md referencing AGENTS.md and restructures .github/dependabot.yml to add required security/dependencies labels and an actions group. Both changes are documentation/configuration only — no executable code, no auth/secrets/migrations. Triage already cleared this as low-risk; this confirmation review agrees.

Linked issue analysis

PR is "Part of petry-projects/.github#261" (the 2026-05-12 compliance audit umbrella). It targets four named findings for .github-private (claude-md-missing-agents-ref, missing-github-actions-ecosystem, missing-security-label, missing-dependencies-label) and the diff demonstrably addresses each: CLAUDE.md exists and links AGENTS.md; dependabot.yml has the github-actions ecosystem with both labels. Remaining audit findings for this repo (workflow edits, repo settings) are explicitly out-of-scope and called out in the PR description.

Findings

  • CLAUDE.md — Clean, factual file: project purpose, links to AGENTS.md, distinguishes thin-caller stub workflows from org-private logic workflows, includes a ## Commands section with shellcheck scripts/*.sh. Earlier reviewer feedback from Gemini (missing prompts//frameworks/, missing Commands section) and Copilot (incorrect stub/non-stub wording) is all factually resolved in the current head; the two technically-unresolved review threads have explicit author replies confirming this and the file content matches.
  • .github/dependabot.yml — Restructured to canonical form: version: 2 at top, consistent indentation, weekly schedule preserved, open-PR limit 10 preserved, github/gh-aw-actions/* ignore preserved with explanation, security/dependencies labels added, groups: actions added to bundle action updates into a single PR. Valid dependabot v2 syntax; no functional regressions.

No security, correctness, or maintainability concerns.

CI status

All required checks green: Lint, CodeQL, Analyze (actions), Analyze (python), unit-tests, ShellCheck, Secret scan (gitleaks), Agent Security Scan, agent-shield, review, Compile agentic workflows, SonarCloud, CodeRabbit. Ecosystem-specific dependency-audit jobs and dependabot-automerge correctly skipped (no matching ecosystems / not a dependabot PR).


Reviewed automatically by the PR-review agent (single-reviewer mode: opus 4.7). Reply if you need a human review.

@don-petry
don-petry merged commit 3a872ad into main Jun 8, 2026
29 checks passed
@don-petry
don-petry deleted the claude/issue-261-compliance branch June 8, 2026 00:13
don-petry added a commit that referenced this pull request Jun 12, 2026
* chore: add CLAUDE.md with AGENTS.md reference

* fix(reviews): address PR #152 review feedback

- Add groups bundling to dependabot.yml for GitHub Actions updates
- Add prompts/ and frameworks/ directories to CLAUDE.md Repository Purpose
- Correct inaccurate "non-stub" claim; clarify which workflows are thin callers
- Add Commands section with shellcheck lint command

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* ci: Add fallback-model opus to CI Failure Analyst (#378)

Enables automatic fallback to Opus when Sonnet is rate-limited,
ensuring analyst continues functioning across rate limit boundaries.

* test(dev-lead): runtime-build PEM markers in writer redaction test (#377)

* test(dev-lead): runtime-build PEM markers in writer redaction test

The previous form embedded the literal `-----BEGIN RSA PRIVATE KEY-----`
and `-----END RSA PRIVATE KEY-----` directly in the stub script body, which
trips gitleaks's `private-key` rule on any PR that re-touches the surrounding
lines. Build the markers from a `dashes="-----"` variable inside a non-quoted
heredoc so the source no longer contains the matching literal, matching the
pattern already used by the post_no_changes PEM tests in
test_fix_reviews.bats.

No behaviour change — `bats tests/dev-lead/unit/test_engine_writer.bats`
still 33/33 green.

Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>

* test(dev-lead): loosen negative greps to catch dash-trimmed PEM leaks

Per Copilot review on #377: the previous revision tightened the negative
assertions to `grep -F "$begin"` (full `-----BEGIN/END RSA PRIVATE KEY-----`
form). That misses leaks where the wrapping dashes are altered or stripped
but the key body / phrase still slips through.

Revert the assertions to substring-only (`BEGIN RSA PRIVATE KEY` /
`END RSA PRIVATE KEY`). The runtime-built stub markers stay — they're what
keeps gitleaks happy. The substring on its own does not satisfy gitleaks's
`private-key` rule (`-----BEGIN ... -----` is required), so this stays
green on the secret scan while making the leak detection stricter.

`bats tests/dev-lead/unit/test_engine_writer.bats` — 33/33 pass.

Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Gemini CLI <gemini-cli@example.com>
Co-authored-by: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>

* fix(dev-lead): centralize git identity setup; apply to fix-ci & fix-reviews (#379)

`dev-lead-fix-issue.sh` defined a `setup_git_identity` helper locally and
called it before `git commit`. The sibling scripts `dev-lead-fix-ci.sh` and
`dev-lead-fix-reviews.sh` did not — so when triggered by `check_run` /
`pull_request_review` / `issue_comment` events, they hit:

    fatal: empty ident name (for <(null)>) not allowed
    ##[error]git commit failed — check git identity configuration on the runner

Observed in bmad-bgreat-suite#203 dev-lead runs (2026-05-23). The earlier
fix in petry-projects/.github-private PR #326 only addressed the issue
intent path; the review and CI intents kept silently failing.

Refactor:
  - Move `setup_git_identity` to a shared lib at `scripts/lib/git-identity.sh`.
  - Source it from all three dev-lead entry-point scripts.
  - Call it before any `git commit` (was previously missing in fix-ci &
    fix-reviews).
  - Drop the inline duplicate in fix-issue.

The helper itself is unchanged in behaviour.

Co-authored-by: don-petry <don-petry@users.noreply.github.com>
Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* fix(dev-lead): expose GEMINI_API_KEY so gemini fallback actually works (#381)

When Claude is rate-limited (e.g. monthly cap exhausted), engine.sh falls
back to invoking the gemini CLI. The CLI fails immediately:

  Please set an Auth method in your /home/runner/.gemini/settings.json or
  specify one of the following environment variables before running:
  GEMINI_API_KEY, GOOGLE_GENAI_USE_VERTEXAI, GOOGLE_GENAI_USE_GCA

The workflow already exposes `GOOGLE_API_KEY` (the org secret) but the
gemini CLI specifically looks for `GEMINI_API_KEY`. Alias one to the other
in every env: block that calls a dev-lead script, so the fallback path
actually has credentials when invoked.

Observed during 2026-05-23 compliance blitz: Claude monthly limit hit
(resets May 26), gemini fallback errored with the message above, every
queued dev-lead run failed → no PRs created for ~33 cycled compliance
issues.

Co-authored-by: don-petry <don-petry@users.noreply.github.com>
Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* feat(engine): in-Claude model fallback before cross-provider switch (#380)

* feat(engine): in-Claude model fallback before cross-provider switch

When a Claude model hits a per-model rate limit, walk an in-engine model
chain (e.g. sonnet → opus) before failing over to gemini/copilot. Each
Claude model has its own TPM/RPM bucket, so swapping models within Claude
often recovers without leaving the provider. Addresses the rate-limit
gap referenced in issues #195 and #206.

- Adds CLAUDE_TRIAGE/DEEP/AUDIT/ACTION/SINGLE_MODEL_CHAIN env vars,
  defaulted in engine.sh's claude branch (sonnet→opus for write/deep,
  opus→sonnet for audit/single, haiku→sonnet for triage; haiku is
  intentionally excluded from the write tier).
- New _claude_chain_invoke helper walks the chain, detects rate-limit on
  each attempt, propagates non-rate-limit failures immediately, and
  returns 2 only when every model in the chain is rate-limited.
- run_writer / run_agentic / run_triage (claude branches only) now route
  through the helper. Gemini and Copilot paths are unchanged.
- Note: in-engine fallback only helps with per-model bucket limits;
  the shared daily subscription cap still requires the proactive guard
  tracked in issue #206.

Tests: 11 new bats cases covering success-on-first, fallback-on-rl,
exhaustion-on-all-rl, non-rl propagation, whitespace tolerance, per-tier
chain selection, env override, and gemini-unchanged. All 191 existing
unit tests still pass (the 2 pre-existing fix-issue rate-limit
failures are unrelated to this change).

Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>

* fix(reviews): address review comments [skip ci-relay]

* fix(review-comments): file-based RL detection, mktemp leak, workflow gate

Addresses three gemini-code-assist findings on scripts/engine.sh and one
pre-existing dev-lead.yml gating bug that surfaced as a failing dispatch
job on this PR.

engine.sh:
- Split is_rate_limited into a regex helper (_rate_limit_pattern) plus
  two callers: the existing text-based is_rate_limited and a new
  is_rate_limited_files that runs grep directly on tmp files. Avoids
  loading multi-MB agent output into $(cat ...) shell substitutions.
- Same treatment for parse_reset_time: extracted _emit_reset_iso and
  added parse_reset_time_files.
- _claude_chain_invoke now uses both file-aware variants and cleans up
  partial mktemp output before degrading to passthrough on mktemp
  failure (previous code could leak stdout_tmp if stderr_tmp failed).

dev-lead.yml:
- The enable-auto-merge step's own env block sets INTENT_TYPE, which
  was in scope for the step's `if:` gate and made the gate always true
  whenever the step was reached, regardless of the upstream intent.
  Switched the gate to steps.intent.outputs.intent_type (step outputs
  are not shadowed by step env) and added the INTENT_PR_NUMBER guard
  already present in dev-lead-reusable.yml. This was the cause of the
  "PR_NUMBER is required" failures appearing under "Enable auto-merge
  on bot approval" on bot-approval events.

tests:
- test_fix_issue.bats: rewrote the gh stubs in the two rate-limit
  scenarios to dispatch on the gh subcommand ($1) instead of pattern
  matching against $*. The prompt body contains literal "gh api
  .../issues/..." example text from the prompt template, which made
  the api branch match before the copilot branch and masked the
  rate-limit path. Both tests were pre-existing failures on main.
- test_engine_chain.bats: 5 new cases covering the file-aware
  helpers.

Test plan:
- bats tests/dev-lead/unit/*.bats tests/test_batch_fallback.bats
  tests/test_validate_engines.bats tests/fleet_report.bats → 241/241
- shellcheck scripts/engine.sh → no new findings
- yamllint .github/workflows/dev-lead.yml → no new findings

Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>

* fix(engine): address Codex review findings on chain semantics

Codex flagged five behavioral bugs in the in-Claude chain logic. All addressed
with regression tests (test_engine_chain.bats now at 22/22).

P1 — Throttled-warning text triggered false rate-limit classification:
The chain emitted `::warning::[claude] model X rate-limited (rc=N) ...` to
stderr after each rate-limited attempt. Downstream callers that scan our
stderr/stdout with is_rate_limited (e.g. review-one-pr.sh:346–350 on triage
stderr; run_writer via `2>&1 | tee _tmp` then is_rate_limited_files _tmp)
would then misclassify a SUCCESSFUL chain fallback as a provider rate-limit
and force cross-provider switch (or, worse, remap a non-RL hard failure in a
later attempt to exit 2). Reworded the warning to "throttled (rc=N) — trying
next in chain" — none of the words match _rate_limit_pattern. Added a unit
test asserting the warning string does not match is_rate_limited.

P2 — Empty/whitespace-only chain was returning rate-limited exit code:
`final_rc` was initialized to 2; if `chain_csv` parsed to zero valid models,
the function returned 2, indistinguishable from a true rate-limit. Switched
init to 0, and added an explicit "no valid model entries" guard that returns
1 (config error) when `attempted == 0`.

P2 — run_agentic / run_writer ignored caller's explicit `model` argument:
Previously the chain unconditionally replaced the caller-supplied model for
any recognized tier, breaking the documented `[model]` parameter and any
emergency model-pin use case. Now: if the caller passes the tier's default
ENGINE_*_MODEL, the chain expands as before; if the caller passes any other
model, treat it as an explicit pin (single-element chain). Verified with two
new tests (one per function) plus a regression guard that confirms default
behavior still expands the chain on rate-limit.

Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
Co-authored-by: donpetry-bot <281750570+donpetry-bot@users.noreply.github.com>

* fix(dev-lead): set git identity before commit in commit_and_push (#369)

* fix(dev-lead): set git identity before commit in commit_and_push

actions/checkout only sets local git config for the repo it checks out
(.github-private). When the script operates on a cloned target repo in a
separate workspace, user.name and user.email are unset, causing git commit
to fail on all non-.github-private repos.

Fixes #368

Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>

* chore: apply manual instructions [skip ci-relay]

* chore: apply manual instructions [skip ci-relay]

* style: improve git-identity.sh comments and conditionals

- Add context about GitHub runner's missing git identity
- Use Bash [[ ]] conditional instead of POSIX [ ] for consistency
- Resolves CodeRabbit style suggestions

Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>

---------

Co-authored-by: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: donpetry-bot <281750570+donpetry-bot@users.noreply.github.com>

* chore(deps): bump anthropics/claude-code-action from 1.0.128 to 1.0.133 (#406)

Bumps [anthropics/claude-code-action](https://github.com/anthropics/claude-code-action) from 1.0.128 to 1.0.133.
- [Release notes](https://github.com/anthropics/claude-code-action/releases)
- [Commits](anthropics/claude-code-action@20c8abf...787c5a0)

---
updated-dependencies:
- dependency-name: anthropics/claude-code-action
  dependency-version: 1.0.133
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* fix: simplify PR_URL_OVERRIDE logic to resolve enumeration bug

## Root Cause

PR #403 was not reviewed despite the workflow running successfully.
Investigation revealed that PR_URL_OVERRIDE was evaluating to an empty
string for pull_request synchronize events, causing the workflow to skip
enumeration entirely (or fall back to list-prs.sh and silently return
no candidates).

The bug occurred because:
1. The original YAML boolean expression used complex && operators within
   || chains: (github.event_name == 'pull_request' && github.event.pull_request.html_url)
2. For some event payloads, github.event.pull_request.html_url was null
3. OR the YAML expression evaluation has precedence/scoping issues with the && operator

This caused PR_URL_OVERRIDE to fall through to the empty string default.

## Solution

Simplify the expression to directly access github.event.pull_request.html_url
without boolean event_name checks. This field is:
- Populated for both 'pull_request' and 'pull_request_review' events
- Null/falsy for other event types, which causes safe fallthrough to the next || clause
- Already successfully used this way in the concurrency group logic

## Result

- pull_request (synchronize, ready_for_review, reopened): PR_URL_OVERRIDE is set directly
- pull_request_review (submitted, dismissed): PR_URL_OVERRIDE is set directly
- check_suite: PR_URL_OVERRIDE is null, falls through to CHECK_SUITE_PRS logic
- All other events: PR_URL_OVERRIDE is null, falls through to list-prs.sh

Fixes #403 not being reviewed.

Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>

* fix(dev-lead): resolve outdated comments in both applied and no-changes paths (#411)

* fix: pin GitHub Actions to specific commit SHAs per compliance standard

* fix(dev-lead): resolve outdated comments in both applied and no-changes paths

The resolve_actor_outdated_threads() safety net was only called when the
agent made no code changes. When the agent successfully addressed comments
and pushed changes, outdated review threads were never resolved.

Move resolve_actor_outdated_threads() outside the if/else block for:
- fix-reviews intent
- fix-bot-comment intent
- review-changes intent

This ensures outdated threads from the triggering reviewer are marked as
resolved regardless of whether code changes were pushed or not.

Tests: All 36 unit tests pass, including new tests validating that
resolve_actor_outdated_threads is called in the applied path (dry-run).

Resolves: PR #403 comment resolution issue

Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>

* fix(ci): correct invalid GitHub Actions cache SHA in daily-pr-review-health.yml

The actions/cache@v5.0.5 SHA was pinned to an invalid commit hash
(0c45773b...) that doesn't exist in the actions/cache repository.
Updated to the correct SHA (27d5ce7f...) used elsewhere in the repo.

This fixes the health check workflow which would fail on scheduled runs.

Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>

---------

Co-authored-by: donpetry-bot <{}+donpetry-bot@users.noreply.github.com>
Co-authored-by: Claude Haiku 4.5 <noreply@anthropic.com>

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: claude-code[bot] <claude-code[bot]@users.noreply.github.com>
Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-authored-by: Gemini CLI <gemini-cli@example.com>
Co-authored-by: don-petry <don-petry@users.noreply.github.com>
Co-authored-by: donpetry-bot <281750570+donpetry-bot@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: donpetry-bot <{}+donpetry-bot@users.noreply.github.com>
don-petry added a commit that referenced this pull request Jun 14, 2026
* chore: add CLAUDE.md with AGENTS.md reference

* fix(reviews): address PR #152 review feedback

- Add groups bundling to dependabot.yml for GitHub Actions updates
- Add prompts/ and frameworks/ directories to CLAUDE.md Repository Purpose
- Correct inaccurate "non-stub" claim; clarify which workflows are thin callers
- Add Commands section with shellcheck lint command

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* ci: Add fallback-model opus to CI Failure Analyst (#378)

Enables automatic fallback to Opus when Sonnet is rate-limited,
ensuring analyst continues functioning across rate limit boundaries.

* test(dev-lead): runtime-build PEM markers in writer redaction test (#377)

* test(dev-lead): runtime-build PEM markers in writer redaction test

The previous form embedded the literal `-----BEGIN RSA PRIVATE KEY-----`
and `-----END RSA PRIVATE KEY-----` directly in the stub script body, which
trips gitleaks's `private-key` rule on any PR that re-touches the surrounding
lines. Build the markers from a `dashes="-----"` variable inside a non-quoted
heredoc so the source no longer contains the matching literal, matching the
pattern already used by the post_no_changes PEM tests in
test_fix_reviews.bats.

No behaviour change — `bats tests/dev-lead/unit/test_engine_writer.bats`
still 33/33 green.

Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>

* test(dev-lead): loosen negative greps to catch dash-trimmed PEM leaks

Per Copilot review on #377: the previous revision tightened the negative
assertions to `grep -F "$begin"` (full `-----BEGIN/END RSA PRIVATE KEY-----`
form). That misses leaks where the wrapping dashes are altered or stripped
but the key body / phrase still slips through.

Revert the assertions to substring-only (`BEGIN RSA PRIVATE KEY` /
`END RSA PRIVATE KEY`). The runtime-built stub markers stay — they're what
keeps gitleaks happy. The substring on its own does not satisfy gitleaks's
`private-key` rule (`-----BEGIN ... -----` is required), so this stays
green on the secret scan while making the leak detection stricter.

`bats tests/dev-lead/unit/test_engine_writer.bats` — 33/33 pass.

Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Gemini CLI <gemini-cli@example.com>
Co-authored-by: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>

* fix(dev-lead): centralize git identity setup; apply to fix-ci & fix-reviews (#379)

`dev-lead-fix-issue.sh` defined a `setup_git_identity` helper locally and
called it before `git commit`. The sibling scripts `dev-lead-fix-ci.sh` and
`dev-lead-fix-reviews.sh` did not — so when triggered by `check_run` /
`pull_request_review` / `issue_comment` events, they hit:

    fatal: empty ident name (for <(null)>) not allowed
    ##[error]git commit failed — check git identity configuration on the runner

Observed in bmad-bgreat-suite#203 dev-lead runs (2026-05-23). The earlier
fix in petry-projects/.github-private PR #326 only addressed the issue
intent path; the review and CI intents kept silently failing.

Refactor:
  - Move `setup_git_identity` to a shared lib at `scripts/lib/git-identity.sh`.
  - Source it from all three dev-lead entry-point scripts.
  - Call it before any `git commit` (was previously missing in fix-ci &
    fix-reviews).
  - Drop the inline duplicate in fix-issue.

The helper itself is unchanged in behaviour.

Co-authored-by: don-petry <don-petry@users.noreply.github.com>
Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* fix(dev-lead): expose GEMINI_API_KEY so gemini fallback actually works (#381)

When Claude is rate-limited (e.g. monthly cap exhausted), engine.sh falls
back to invoking the gemini CLI. The CLI fails immediately:

  Please set an Auth method in your /home/runner/.gemini/settings.json or
  specify one of the following environment variables before running:
  GEMINI_API_KEY, GOOGLE_GENAI_USE_VERTEXAI, GOOGLE_GENAI_USE_GCA

The workflow already exposes `GOOGLE_API_KEY` (the org secret) but the
gemini CLI specifically looks for `GEMINI_API_KEY`. Alias one to the other
in every env: block that calls a dev-lead script, so the fallback path
actually has credentials when invoked.

Observed during 2026-05-23 compliance blitz: Claude monthly limit hit
(resets May 26), gemini fallback errored with the message above, every
queued dev-lead run failed → no PRs created for ~33 cycled compliance
issues.

Co-authored-by: don-petry <don-petry@users.noreply.github.com>
Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* feat(engine): in-Claude model fallback before cross-provider switch (#380)

* feat(engine): in-Claude model fallback before cross-provider switch

When a Claude model hits a per-model rate limit, walk an in-engine model
chain (e.g. sonnet → opus) before failing over to gemini/copilot. Each
Claude model has its own TPM/RPM bucket, so swapping models within Claude
often recovers without leaving the provider. Addresses the rate-limit
gap referenced in issues #195 and #206.

- Adds CLAUDE_TRIAGE/DEEP/AUDIT/ACTION/SINGLE_MODEL_CHAIN env vars,
  defaulted in engine.sh's claude branch (sonnet→opus for write/deep,
  opus→sonnet for audit/single, haiku→sonnet for triage; haiku is
  intentionally excluded from the write tier).
- New _claude_chain_invoke helper walks the chain, detects rate-limit on
  each attempt, propagates non-rate-limit failures immediately, and
  returns 2 only when every model in the chain is rate-limited.
- run_writer / run_agentic / run_triage (claude branches only) now route
  through the helper. Gemini and Copilot paths are unchanged.
- Note: in-engine fallback only helps with per-model bucket limits;
  the shared daily subscription cap still requires the proactive guard
  tracked in issue #206.

Tests: 11 new bats cases covering success-on-first, fallback-on-rl,
exhaustion-on-all-rl, non-rl propagation, whitespace tolerance, per-tier
chain selection, env override, and gemini-unchanged. All 191 existing
unit tests still pass (the 2 pre-existing fix-issue rate-limit
failures are unrelated to this change).

Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>

* fix(reviews): address review comments [skip ci-relay]

* fix(review-comments): file-based RL detection, mktemp leak, workflow gate

Addresses three gemini-code-assist findings on scripts/engine.sh and one
pre-existing dev-lead.yml gating bug that surfaced as a failing dispatch
job on this PR.

engine.sh:
- Split is_rate_limited into a regex helper (_rate_limit_pattern) plus
  two callers: the existing text-based is_rate_limited and a new
  is_rate_limited_files that runs grep directly on tmp files. Avoids
  loading multi-MB agent output into $(cat ...) shell substitutions.
- Same treatment for parse_reset_time: extracted _emit_reset_iso and
  added parse_reset_time_files.
- _claude_chain_invoke now uses both file-aware variants and cleans up
  partial mktemp output before degrading to passthrough on mktemp
  failure (previous code could leak stdout_tmp if stderr_tmp failed).

dev-lead.yml:
- The enable-auto-merge step's own env block sets INTENT_TYPE, which
  was in scope for the step's `if:` gate and made the gate always true
  whenever the step was reached, regardless of the upstream intent.
  Switched the gate to steps.intent.outputs.intent_type (step outputs
  are not shadowed by step env) and added the INTENT_PR_NUMBER guard
  already present in dev-lead-reusable.yml. This was the cause of the
  "PR_NUMBER is required" failures appearing under "Enable auto-merge
  on bot approval" on bot-approval events.

tests:
- test_fix_issue.bats: rewrote the gh stubs in the two rate-limit
  scenarios to dispatch on the gh subcommand ($1) instead of pattern
  matching against $*. The prompt body contains literal "gh api
  .../issues/..." example text from the prompt template, which made
  the api branch match before the copilot branch and masked the
  rate-limit path. Both tests were pre-existing failures on main.
- test_engine_chain.bats: 5 new cases covering the file-aware
  helpers.

Test plan:
- bats tests/dev-lead/unit/*.bats tests/test_batch_fallback.bats
  tests/test_validate_engines.bats tests/fleet_report.bats → 241/241
- shellcheck scripts/engine.sh → no new findings
- yamllint .github/workflows/dev-lead.yml → no new findings

Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>

* fix(engine): address Codex review findings on chain semantics

Codex flagged five behavioral bugs in the in-Claude chain logic. All addressed
with regression tests (test_engine_chain.bats now at 22/22).

P1 — Throttled-warning text triggered false rate-limit classification:
The chain emitted `::warning::[claude] model X rate-limited (rc=N) ...` to
stderr after each rate-limited attempt. Downstream callers that scan our
stderr/stdout with is_rate_limited (e.g. review-one-pr.sh:346–350 on triage
stderr; run_writer via `2>&1 | tee _tmp` then is_rate_limited_files _tmp)
would then misclassify a SUCCESSFUL chain fallback as a provider rate-limit
and force cross-provider switch (or, worse, remap a non-RL hard failure in a
later attempt to exit 2). Reworded the warning to "throttled (rc=N) — trying
next in chain" — none of the words match _rate_limit_pattern. Added a unit
test asserting the warning string does not match is_rate_limited.

P2 — Empty/whitespace-only chain was returning rate-limited exit code:
`final_rc` was initialized to 2; if `chain_csv` parsed to zero valid models,
the function returned 2, indistinguishable from a true rate-limit. Switched
init to 0, and added an explicit "no valid model entries" guard that returns
1 (config error) when `attempted == 0`.

P2 — run_agentic / run_writer ignored caller's explicit `model` argument:
Previously the chain unconditionally replaced the caller-supplied model for
any recognized tier, breaking the documented `[model]` parameter and any
emergency model-pin use case. Now: if the caller passes the tier's default
ENGINE_*_MODEL, the chain expands as before; if the caller passes any other
model, treat it as an explicit pin (single-element chain). Verified with two
new tests (one per function) plus a regression guard that confirms default
behavior still expands the chain on rate-limit.

Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
Co-authored-by: donpetry-bot <281750570+donpetry-bot@users.noreply.github.com>

* fix(dev-lead): set git identity before commit in commit_and_push (#369)

* fix(dev-lead): set git identity before commit in commit_and_push

actions/checkout only sets local git config for the repo it checks out
(.github-private). When the script operates on a cloned target repo in a
separate workspace, user.name and user.email are unset, causing git commit
to fail on all non-.github-private repos.

Fixes #368

Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>

* chore: apply manual instructions [skip ci-relay]

* chore: apply manual instructions [skip ci-relay]

* style: improve git-identity.sh comments and conditionals

- Add context about GitHub runner's missing git identity
- Use Bash [[ ]] conditional instead of POSIX [ ] for consistency
- Resolves CodeRabbit style suggestions

Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>

---------

Co-authored-by: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: donpetry-bot <281750570+donpetry-bot@users.noreply.github.com>

* chore(deps): bump anthropics/claude-code-action from 1.0.128 to 1.0.133 (#406)

Bumps [anthropics/claude-code-action](https://github.com/anthropics/claude-code-action) from 1.0.128 to 1.0.133.
- [Release notes](https://github.com/anthropics/claude-code-action/releases)
- [Commits](anthropics/claude-code-action@20c8abf...787c5a0)

---
updated-dependencies:
- dependency-name: anthropics/claude-code-action
  dependency-version: 1.0.133
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* fix: simplify PR_URL_OVERRIDE logic to resolve enumeration bug

## Root Cause

PR #403 was not reviewed despite the workflow running successfully.
Investigation revealed that PR_URL_OVERRIDE was evaluating to an empty
string for pull_request synchronize events, causing the workflow to skip
enumeration entirely (or fall back to list-prs.sh and silently return
no candidates).

The bug occurred because:
1. The original YAML boolean expression used complex && operators within
   || chains: (github.event_name == 'pull_request' && github.event.pull_request.html_url)
2. For some event payloads, github.event.pull_request.html_url was null
3. OR the YAML expression evaluation has precedence/scoping issues with the && operator

This caused PR_URL_OVERRIDE to fall through to the empty string default.

## Solution

Simplify the expression to directly access github.event.pull_request.html_url
without boolean event_name checks. This field is:
- Populated for both 'pull_request' and 'pull_request_review' events
- Null/falsy for other event types, which causes safe fallthrough to the next || clause
- Already successfully used this way in the concurrency group logic

## Result

- pull_request (synchronize, ready_for_review, reopened): PR_URL_OVERRIDE is set directly
- pull_request_review (submitted, dismissed): PR_URL_OVERRIDE is set directly
- check_suite: PR_URL_OVERRIDE is null, falls through to CHECK_SUITE_PRS logic
- All other events: PR_URL_OVERRIDE is null, falls through to list-prs.sh

Fixes #403 not being reviewed.

Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>

* fix(dev-lead): resolve outdated comments in both applied and no-changes paths (#411)

* fix: pin GitHub Actions to specific commit SHAs per compliance standard

* fix(dev-lead): resolve outdated comments in both applied and no-changes paths

The resolve_actor_outdated_threads() safety net was only called when the
agent made no code changes. When the agent successfully addressed comments
and pushed changes, outdated review threads were never resolved.

Move resolve_actor_outdated_threads() outside the if/else block for:
- fix-reviews intent
- fix-bot-comment intent
- review-changes intent

This ensures outdated threads from the triggering reviewer are marked as
resolved regardless of whether code changes were pushed or not.

Tests: All 36 unit tests pass, including new tests validating that
resolve_actor_outdated_threads is called in the applied path (dry-run).

Resolves: PR #403 comment resolution issue

Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>

* fix(ci): correct invalid GitHub Actions cache SHA in daily-pr-review-health.yml

The actions/cache@v5.0.5 SHA was pinned to an invalid commit hash
(0c45773b...) that doesn't exist in the actions/cache repository.
Updated to the correct SHA (27d5ce7f...) used elsewhere in the repo.

This fixes the health check workflow which would fail on scheduled runs.

Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>

---------

Co-authored-by: donpetry-bot <{}+donpetry-bot@users.noreply.github.com>
Co-authored-by: Claude Haiku 4.5 <noreply@anthropic.com>

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: claude-code[bot] <claude-code[bot]@users.noreply.github.com>
Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-authored-by: Gemini CLI <gemini-cli@example.com>
Co-authored-by: don-petry <don-petry@users.noreply.github.com>
Co-authored-by: donpetry-bot <281750570+donpetry-bot@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: donpetry-bot <{}+donpetry-bot@users.noreply.github.com>
don-petry added a commit that referenced this pull request Jun 18, 2026
* chore: add CLAUDE.md with AGENTS.md reference

* fix(reviews): address PR #152 review feedback

- Add groups bundling to dependabot.yml for GitHub Actions updates
- Add prompts/ and frameworks/ directories to CLAUDE.md Repository Purpose
- Correct inaccurate "non-stub" claim; clarify which workflows are thin callers
- Add Commands section with shellcheck lint command

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* ci: Add fallback-model opus to CI Failure Analyst (#378)

Enables automatic fallback to Opus when Sonnet is rate-limited,
ensuring analyst continues functioning across rate limit boundaries.

* test(dev-lead): runtime-build PEM markers in writer redaction test (#377)

* test(dev-lead): runtime-build PEM markers in writer redaction test

The previous form embedded the literal `-----BEGIN RSA PRIVATE KEY-----`
and `-----END RSA PRIVATE KEY-----` directly in the stub script body, which
trips gitleaks's `private-key` rule on any PR that re-touches the surrounding
lines. Build the markers from a `dashes="-----"` variable inside a non-quoted
heredoc so the source no longer contains the matching literal, matching the
pattern already used by the post_no_changes PEM tests in
test_fix_reviews.bats.

No behaviour change — `bats tests/dev-lead/unit/test_engine_writer.bats`
still 33/33 green.

Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>

* test(dev-lead): loosen negative greps to catch dash-trimmed PEM leaks

Per Copilot review on #377: the previous revision tightened the negative
assertions to `grep -F "$begin"` (full `-----BEGIN/END RSA PRIVATE KEY-----`
form). That misses leaks where the wrapping dashes are altered or stripped
but the key body / phrase still slips through.

Revert the assertions to substring-only (`BEGIN RSA PRIVATE KEY` /
`END RSA PRIVATE KEY`). The runtime-built stub markers stay — they're what
keeps gitleaks happy. The substring on its own does not satisfy gitleaks's
`private-key` rule (`-----BEGIN ... -----` is required), so this stays
green on the secret scan while making the leak detection stricter.

`bats tests/dev-lead/unit/test_engine_writer.bats` — 33/33 pass.

Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Gemini CLI <gemini-cli@example.com>
Co-authored-by: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>

* fix(dev-lead): centralize git identity setup; apply to fix-ci & fix-reviews (#379)

`dev-lead-fix-issue.sh` defined a `setup_git_identity` helper locally and
called it before `git commit`. The sibling scripts `dev-lead-fix-ci.sh` and
`dev-lead-fix-reviews.sh` did not — so when triggered by `check_run` /
`pull_request_review` / `issue_comment` events, they hit:

    fatal: empty ident name (for <(null)>) not allowed
    ##[error]git commit failed — check git identity configuration on the runner

Observed in bmad-bgreat-suite#203 dev-lead runs (2026-05-23). The earlier
fix in petry-projects/.github-private PR #326 only addressed the issue
intent path; the review and CI intents kept silently failing.

Refactor:
  - Move `setup_git_identity` to a shared lib at `scripts/lib/git-identity.sh`.
  - Source it from all three dev-lead entry-point scripts.
  - Call it before any `git commit` (was previously missing in fix-ci &
    fix-reviews).
  - Drop the inline duplicate in fix-issue.

The helper itself is unchanged in behaviour.

Co-authored-by: don-petry <don-petry@users.noreply.github.com>
Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* fix(dev-lead): expose GEMINI_API_KEY so gemini fallback actually works (#381)

When Claude is rate-limited (e.g. monthly cap exhausted), engine.sh falls
back to invoking the gemini CLI. The CLI fails immediately:

  Please set an Auth method in your /home/runner/.gemini/settings.json or
  specify one of the following environment variables before running:
  GEMINI_API_KEY, GOOGLE_GENAI_USE_VERTEXAI, GOOGLE_GENAI_USE_GCA

The workflow already exposes `GOOGLE_API_KEY` (the org secret) but the
gemini CLI specifically looks for `GEMINI_API_KEY`. Alias one to the other
in every env: block that calls a dev-lead script, so the fallback path
actually has credentials when invoked.

Observed during 2026-05-23 compliance blitz: Claude monthly limit hit
(resets May 26), gemini fallback errored with the message above, every
queued dev-lead run failed → no PRs created for ~33 cycled compliance
issues.

Co-authored-by: don-petry <don-petry@users.noreply.github.com>
Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* feat(engine): in-Claude model fallback before cross-provider switch (#380)

* feat(engine): in-Claude model fallback before cross-provider switch

When a Claude model hits a per-model rate limit, walk an in-engine model
chain (e.g. sonnet → opus) before failing over to gemini/copilot. Each
Claude model has its own TPM/RPM bucket, so swapping models within Claude
often recovers without leaving the provider. Addresses the rate-limit
gap referenced in issues #195 and #206.

- Adds CLAUDE_TRIAGE/DEEP/AUDIT/ACTION/SINGLE_MODEL_CHAIN env vars,
  defaulted in engine.sh's claude branch (sonnet→opus for write/deep,
  opus→sonnet for audit/single, haiku→sonnet for triage; haiku is
  intentionally excluded from the write tier).
- New _claude_chain_invoke helper walks the chain, detects rate-limit on
  each attempt, propagates non-rate-limit failures immediately, and
  returns 2 only when every model in the chain is rate-limited.
- run_writer / run_agentic / run_triage (claude branches only) now route
  through the helper. Gemini and Copilot paths are unchanged.
- Note: in-engine fallback only helps with per-model bucket limits;
  the shared daily subscription cap still requires the proactive guard
  tracked in issue #206.

Tests: 11 new bats cases covering success-on-first, fallback-on-rl,
exhaustion-on-all-rl, non-rl propagation, whitespace tolerance, per-tier
chain selection, env override, and gemini-unchanged. All 191 existing
unit tests still pass (the 2 pre-existing fix-issue rate-limit
failures are unrelated to this change).

Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>

* fix(reviews): address review comments [skip ci-relay]

* fix(review-comments): file-based RL detection, mktemp leak, workflow gate

Addresses three gemini-code-assist findings on scripts/engine.sh and one
pre-existing dev-lead.yml gating bug that surfaced as a failing dispatch
job on this PR.

engine.sh:
- Split is_rate_limited into a regex helper (_rate_limit_pattern) plus
  two callers: the existing text-based is_rate_limited and a new
  is_rate_limited_files that runs grep directly on tmp files. Avoids
  loading multi-MB agent output into $(cat ...) shell substitutions.
- Same treatment for parse_reset_time: extracted _emit_reset_iso and
  added parse_reset_time_files.
- _claude_chain_invoke now uses both file-aware variants and cleans up
  partial mktemp output before degrading to passthrough on mktemp
  failure (previous code could leak stdout_tmp if stderr_tmp failed).

dev-lead.yml:
- The enable-auto-merge step's own env block sets INTENT_TYPE, which
  was in scope for the step's `if:` gate and made the gate always true
  whenever the step was reached, regardless of the upstream intent.
  Switched the gate to steps.intent.outputs.intent_type (step outputs
  are not shadowed by step env) and added the INTENT_PR_NUMBER guard
  already present in dev-lead-reusable.yml. This was the cause of the
  "PR_NUMBER is required" failures appearing under "Enable auto-merge
  on bot approval" on bot-approval events.

tests:
- test_fix_issue.bats: rewrote the gh stubs in the two rate-limit
  scenarios to dispatch on the gh subcommand ($1) instead of pattern
  matching against $*. The prompt body contains literal "gh api
  .../issues/..." example text from the prompt template, which made
  the api branch match before the copilot branch and masked the
  rate-limit path. Both tests were pre-existing failures on main.
- test_engine_chain.bats: 5 new cases covering the file-aware
  helpers.

Test plan:
- bats tests/dev-lead/unit/*.bats tests/test_batch_fallback.bats
  tests/test_validate_engines.bats tests/fleet_report.bats → 241/241
- shellcheck scripts/engine.sh → no new findings
- yamllint .github/workflows/dev-lead.yml → no new findings

Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>

* fix(engine): address Codex review findings on chain semantics

Codex flagged five behavioral bugs in the in-Claude chain logic. All addressed
with regression tests (test_engine_chain.bats now at 22/22).

P1 — Throttled-warning text triggered false rate-limit classification:
The chain emitted `::warning::[claude] model X rate-limited (rc=N) ...` to
stderr after each rate-limited attempt. Downstream callers that scan our
stderr/stdout with is_rate_limited (e.g. review-one-pr.sh:346–350 on triage
stderr; run_writer via `2>&1 | tee _tmp` then is_rate_limited_files _tmp)
would then misclassify a SUCCESSFUL chain fallback as a provider rate-limit
and force cross-provider switch (or, worse, remap a non-RL hard failure in a
later attempt to exit 2). Reworded the warning to "throttled (rc=N) — trying
next in chain" — none of the words match _rate_limit_pattern. Added a unit
test asserting the warning string does not match is_rate_limited.

P2 — Empty/whitespace-only chain was returning rate-limited exit code:
`final_rc` was initialized to 2; if `chain_csv` parsed to zero valid models,
the function returned 2, indistinguishable from a true rate-limit. Switched
init to 0, and added an explicit "no valid model entries" guard that returns
1 (config error) when `attempted == 0`.

P2 — run_agentic / run_writer ignored caller's explicit `model` argument:
Previously the chain unconditionally replaced the caller-supplied model for
any recognized tier, breaking the documented `[model]` parameter and any
emergency model-pin use case. Now: if the caller passes the tier's default
ENGINE_*_MODEL, the chain expands as before; if the caller passes any other
model, treat it as an explicit pin (single-element chain). Verified with two
new tests (one per function) plus a regression guard that confirms default
behavior still expands the chain on rate-limit.

Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
Co-authored-by: donpetry-bot <281750570+donpetry-bot@users.noreply.github.com>

* fix(dev-lead): set git identity before commit in commit_and_push (#369)

* fix(dev-lead): set git identity before commit in commit_and_push

actions/checkout only sets local git config for the repo it checks out
(.github-private). When the script operates on a cloned target repo in a
separate workspace, user.name and user.email are unset, causing git commit
to fail on all non-.github-private repos.

Fixes #368

Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>

* chore: apply manual instructions [skip ci-relay]

* chore: apply manual instructions [skip ci-relay]

* style: improve git-identity.sh comments and conditionals

- Add context about GitHub runner's missing git identity
- Use Bash [[ ]] conditional instead of POSIX [ ] for consistency
- Resolves CodeRabbit style suggestions

Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>

---------

Co-authored-by: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: donpetry-bot <281750570+donpetry-bot@users.noreply.github.com>

* chore(deps): bump anthropics/claude-code-action from 1.0.128 to 1.0.133 (#406)

Bumps [anthropics/claude-code-action](https://github.com/anthropics/claude-code-action) from 1.0.128 to 1.0.133.
- [Release notes](https://github.com/anthropics/claude-code-action/releases)
- [Commits](anthropics/claude-code-action@20c8abf...787c5a0)

---
updated-dependencies:
- dependency-name: anthropics/claude-code-action
  dependency-version: 1.0.133
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* fix: simplify PR_URL_OVERRIDE logic to resolve enumeration bug

## Root Cause

PR #403 was not reviewed despite the workflow running successfully.
Investigation revealed that PR_URL_OVERRIDE was evaluating to an empty
string for pull_request synchronize events, causing the workflow to skip
enumeration entirely (or fall back to list-prs.sh and silently return
no candidates).

The bug occurred because:
1. The original YAML boolean expression used complex && operators within
   || chains: (github.event_name == 'pull_request' && github.event.pull_request.html_url)
2. For some event payloads, github.event.pull_request.html_url was null
3. OR the YAML expression evaluation has precedence/scoping issues with the && operator

This caused PR_URL_OVERRIDE to fall through to the empty string default.

## Solution

Simplify the expression to directly access github.event.pull_request.html_url
without boolean event_name checks. This field is:
- Populated for both 'pull_request' and 'pull_request_review' events
- Null/falsy for other event types, which causes safe fallthrough to the next || clause
- Already successfully used this way in the concurrency group logic

## Result

- pull_request (synchronize, ready_for_review, reopened): PR_URL_OVERRIDE is set directly
- pull_request_review (submitted, dismissed): PR_URL_OVERRIDE is set directly
- check_suite: PR_URL_OVERRIDE is null, falls through to CHECK_SUITE_PRS logic
- All other events: PR_URL_OVERRIDE is null, falls through to list-prs.sh

Fixes #403 not being reviewed.

Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>

* fix(dev-lead): resolve outdated comments in both applied and no-changes paths (#411)

* fix: pin GitHub Actions to specific commit SHAs per compliance standard

* fix(dev-lead): resolve outdated comments in both applied and no-changes paths

The resolve_actor_outdated_threads() safety net was only called when the
agent made no code changes. When the agent successfully addressed comments
and pushed changes, outdated review threads were never resolved.

Move resolve_actor_outdated_threads() outside the if/else block for:
- fix-reviews intent
- fix-bot-comment intent
- review-changes intent

This ensures outdated threads from the triggering reviewer are marked as
resolved regardless of whether code changes were pushed or not.

Tests: All 36 unit tests pass, including new tests validating that
resolve_actor_outdated_threads is called in the applied path (dry-run).

Resolves: PR #403 comment resolution issue

Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>

* fix(ci): correct invalid GitHub Actions cache SHA in daily-pr-review-health.yml

The actions/cache@v5.0.5 SHA was pinned to an invalid commit hash
(0c45773b...) that doesn't exist in the actions/cache repository.
Updated to the correct SHA (27d5ce7f...) used elsewhere in the repo.

This fixes the health check workflow which would fail on scheduled runs.

Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>

---------

Co-authored-by: donpetry-bot <{}+donpetry-bot@users.noreply.github.com>
Co-authored-by: Claude Haiku 4.5 <noreply@anthropic.com>

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: claude-code[bot] <claude-code[bot]@users.noreply.github.com>
Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-authored-by: Gemini CLI <gemini-cli@example.com>
Co-authored-by: don-petry <don-petry@users.noreply.github.com>
Co-authored-by: donpetry-bot <281750570+donpetry-bot@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: donpetry-bot <{}+donpetry-bot@users.noreply.github.com>
don-petry added a commit that referenced this pull request Jun 25, 2026
* chore: add CLAUDE.md with AGENTS.md reference

* fix(reviews): address PR #152 review feedback

- Add groups bundling to dependabot.yml for GitHub Actions updates
- Add prompts/ and frameworks/ directories to CLAUDE.md Repository Purpose
- Correct inaccurate "non-stub" claim; clarify which workflows are thin callers
- Add Commands section with shellcheck lint command

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* ci: Add fallback-model opus to CI Failure Analyst (#378)

Enables automatic fallback to Opus when Sonnet is rate-limited,
ensuring analyst continues functioning across rate limit boundaries.

* test(dev-lead): runtime-build PEM markers in writer redaction test (#377)

* test(dev-lead): runtime-build PEM markers in writer redaction test

The previous form embedded the literal `-----BEGIN RSA PRIVATE KEY-----`
and `-----END RSA PRIVATE KEY-----` directly in the stub script body, which
trips gitleaks's `private-key` rule on any PR that re-touches the surrounding
lines. Build the markers from a `dashes="-----"` variable inside a non-quoted
heredoc so the source no longer contains the matching literal, matching the
pattern already used by the post_no_changes PEM tests in
test_fix_reviews.bats.

No behaviour change — `bats tests/dev-lead/unit/test_engine_writer.bats`
still 33/33 green.

Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>

* test(dev-lead): loosen negative greps to catch dash-trimmed PEM leaks

Per Copilot review on #377: the previous revision tightened the negative
assertions to `grep -F "$begin"` (full `-----BEGIN/END RSA PRIVATE KEY-----`
form). That misses leaks where the wrapping dashes are altered or stripped
but the key body / phrase still slips through.

Revert the assertions to substring-only (`BEGIN RSA PRIVATE KEY` /
`END RSA PRIVATE KEY`). The runtime-built stub markers stay — they're what
keeps gitleaks happy. The substring on its own does not satisfy gitleaks's
`private-key` rule (`-----BEGIN ... -----` is required), so this stays
green on the secret scan while making the leak detection stricter.

`bats tests/dev-lead/unit/test_engine_writer.bats` — 33/33 pass.

Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Gemini CLI <gemini-cli@example.com>
Co-authored-by: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>

* fix(dev-lead): centralize git identity setup; apply to fix-ci & fix-reviews (#379)

`dev-lead-fix-issue.sh` defined a `setup_git_identity` helper locally and
called it before `git commit`. The sibling scripts `dev-lead-fix-ci.sh` and
`dev-lead-fix-reviews.sh` did not — so when triggered by `check_run` /
`pull_request_review` / `issue_comment` events, they hit:

    fatal: empty ident name (for <(null)>) not allowed
    ##[error]git commit failed — check git identity configuration on the runner

Observed in bmad-bgreat-suite#203 dev-lead runs (2026-05-23). The earlier
fix in petry-projects/.github-private PR #326 only addressed the issue
intent path; the review and CI intents kept silently failing.

Refactor:
  - Move `setup_git_identity` to a shared lib at `scripts/lib/git-identity.sh`.
  - Source it from all three dev-lead entry-point scripts.
  - Call it before any `git commit` (was previously missing in fix-ci &
    fix-reviews).
  - Drop the inline duplicate in fix-issue.

The helper itself is unchanged in behaviour.

Co-authored-by: don-petry <don-petry@users.noreply.github.com>
Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* fix(dev-lead): expose GEMINI_API_KEY so gemini fallback actually works (#381)

When Claude is rate-limited (e.g. monthly cap exhausted), engine.sh falls
back to invoking the gemini CLI. The CLI fails immediately:

  Please set an Auth method in your /home/runner/.gemini/settings.json or
  specify one of the following environment variables before running:
  GEMINI_API_KEY, GOOGLE_GENAI_USE_VERTEXAI, GOOGLE_GENAI_USE_GCA

The workflow already exposes `GOOGLE_API_KEY` (the org secret) but the
gemini CLI specifically looks for `GEMINI_API_KEY`. Alias one to the other
in every env: block that calls a dev-lead script, so the fallback path
actually has credentials when invoked.

Observed during 2026-05-23 compliance blitz: Claude monthly limit hit
(resets May 26), gemini fallback errored with the message above, every
queued dev-lead run failed → no PRs created for ~33 cycled compliance
issues.

Co-authored-by: don-petry <don-petry@users.noreply.github.com>
Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* feat(engine): in-Claude model fallback before cross-provider switch (#380)

* feat(engine): in-Claude model fallback before cross-provider switch

When a Claude model hits a per-model rate limit, walk an in-engine model
chain (e.g. sonnet → opus) before failing over to gemini/copilot. Each
Claude model has its own TPM/RPM bucket, so swapping models within Claude
often recovers without leaving the provider. Addresses the rate-limit
gap referenced in issues #195 and #206.

- Adds CLAUDE_TRIAGE/DEEP/AUDIT/ACTION/SINGLE_MODEL_CHAIN env vars,
  defaulted in engine.sh's claude branch (sonnet→opus for write/deep,
  opus→sonnet for audit/single, haiku→sonnet for triage; haiku is
  intentionally excluded from the write tier).
- New _claude_chain_invoke helper walks the chain, detects rate-limit on
  each attempt, propagates non-rate-limit failures immediately, and
  returns 2 only when every model in the chain is rate-limited.
- run_writer / run_agentic / run_triage (claude branches only) now route
  through the helper. Gemini and Copilot paths are unchanged.
- Note: in-engine fallback only helps with per-model bucket limits;
  the shared daily subscription cap still requires the proactive guard
  tracked in issue #206.

Tests: 11 new bats cases covering success-on-first, fallback-on-rl,
exhaustion-on-all-rl, non-rl propagation, whitespace tolerance, per-tier
chain selection, env override, and gemini-unchanged. All 191 existing
unit tests still pass (the 2 pre-existing fix-issue rate-limit
failures are unrelated to this change).

Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>

* fix(reviews): address review comments [skip ci-relay]

* fix(review-comments): file-based RL detection, mktemp leak, workflow gate

Addresses three gemini-code-assist findings on scripts/engine.sh and one
pre-existing dev-lead.yml gating bug that surfaced as a failing dispatch
job on this PR.

engine.sh:
- Split is_rate_limited into a regex helper (_rate_limit_pattern) plus
  two callers: the existing text-based is_rate_limited and a new
  is_rate_limited_files that runs grep directly on tmp files. Avoids
  loading multi-MB agent output into $(cat ...) shell substitutions.
- Same treatment for parse_reset_time: extracted _emit_reset_iso and
  added parse_reset_time_files.
- _claude_chain_invoke now uses both file-aware variants and cleans up
  partial mktemp output before degrading to passthrough on mktemp
  failure (previous code could leak stdout_tmp if stderr_tmp failed).

dev-lead.yml:
- The enable-auto-merge step's own env block sets INTENT_TYPE, which
  was in scope for the step's `if:` gate and made the gate always true
  whenever the step was reached, regardless of the upstream intent.
  Switched the gate to steps.intent.outputs.intent_type (step outputs
  are not shadowed by step env) and added the INTENT_PR_NUMBER guard
  already present in dev-lead-reusable.yml. This was the cause of the
  "PR_NUMBER is required" failures appearing under "Enable auto-merge
  on bot approval" on bot-approval events.

tests:
- test_fix_issue.bats: rewrote the gh stubs in the two rate-limit
  scenarios to dispatch on the gh subcommand ($1) instead of pattern
  matching against $*. The prompt body contains literal "gh api
  .../issues/..." example text from the prompt template, which made
  the api branch match before the copilot branch and masked the
  rate-limit path. Both tests were pre-existing failures on main.
- test_engine_chain.bats: 5 new cases covering the file-aware
  helpers.

Test plan:
- bats tests/dev-lead/unit/*.bats tests/test_batch_fallback.bats
  tests/test_validate_engines.bats tests/fleet_report.bats → 241/241
- shellcheck scripts/engine.sh → no new findings
- yamllint .github/workflows/dev-lead.yml → no new findings

Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>

* fix(engine): address Codex review findings on chain semantics

Codex flagged five behavioral bugs in the in-Claude chain logic. All addressed
with regression tests (test_engine_chain.bats now at 22/22).

P1 — Throttled-warning text triggered false rate-limit classification:
The chain emitted `::warning::[claude] model X rate-limited (rc=N) ...` to
stderr after each rate-limited attempt. Downstream callers that scan our
stderr/stdout with is_rate_limited (e.g. review-one-pr.sh:346–350 on triage
stderr; run_writer via `2>&1 | tee _tmp` then is_rate_limited_files _tmp)
would then misclassify a SUCCESSFUL chain fallback as a provider rate-limit
and force cross-provider switch (or, worse, remap a non-RL hard failure in a
later attempt to exit 2). Reworded the warning to "throttled (rc=N) — trying
next in chain" — none of the words match _rate_limit_pattern. Added a unit
test asserting the warning string does not match is_rate_limited.

P2 — Empty/whitespace-only chain was returning rate-limited exit code:
`final_rc` was initialized to 2; if `chain_csv` parsed to zero valid models,
the function returned 2, indistinguishable from a true rate-limit. Switched
init to 0, and added an explicit "no valid model entries" guard that returns
1 (config error) when `attempted == 0`.

P2 — run_agentic / run_writer ignored caller's explicit `model` argument:
Previously the chain unconditionally replaced the caller-supplied model for
any recognized tier, breaking the documented `[model]` parameter and any
emergency model-pin use case. Now: if the caller passes the tier's default
ENGINE_*_MODEL, the chain expands as before; if the caller passes any other
model, treat it as an explicit pin (single-element chain). Verified with two
new tests (one per function) plus a regression guard that confirms default
behavior still expands the chain on rate-limit.

Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
Co-authored-by: donpetry-bot <281750570+donpetry-bot@users.noreply.github.com>

* fix(dev-lead): set git identity before commit in commit_and_push (#369)

* fix(dev-lead): set git identity before commit in commit_and_push

actions/checkout only sets local git config for the repo it checks out
(.github-private). When the script operates on a cloned target repo in a
separate workspace, user.name and user.email are unset, causing git commit
to fail on all non-.github-private repos.

Fixes #368

Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>

* chore: apply manual instructions [skip ci-relay]

* chore: apply manual instructions [skip ci-relay]

* style: improve git-identity.sh comments and conditionals

- Add context about GitHub runner's missing git identity
- Use Bash [[ ]] conditional instead of POSIX [ ] for consistency
- Resolves CodeRabbit style suggestions

Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>

---------

Co-authored-by: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: donpetry-bot <281750570+donpetry-bot@users.noreply.github.com>

* chore(deps): bump anthropics/claude-code-action from 1.0.128 to 1.0.133 (#406)

Bumps [anthropics/claude-code-action](https://github.com/anthropics/claude-code-action) from 1.0.128 to 1.0.133.
- [Release notes](https://github.com/anthropics/claude-code-action/releases)
- [Commits](anthropics/claude-code-action@20c8abf...787c5a0)

---
updated-dependencies:
- dependency-name: anthropics/claude-code-action
  dependency-version: 1.0.133
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* fix: simplify PR_URL_OVERRIDE logic to resolve enumeration bug

## Root Cause

PR #403 was not reviewed despite the workflow running successfully.
Investigation revealed that PR_URL_OVERRIDE was evaluating to an empty
string for pull_request synchronize events, causing the workflow to skip
enumeration entirely (or fall back to list-prs.sh and silently return
no candidates).

The bug occurred because:
1. The original YAML boolean expression used complex && operators within
   || chains: (github.event_name == 'pull_request' && github.event.pull_request.html_url)
2. For some event payloads, github.event.pull_request.html_url was null
3. OR the YAML expression evaluation has precedence/scoping issues with the && operator

This caused PR_URL_OVERRIDE to fall through to the empty string default.

## Solution

Simplify the expression to directly access github.event.pull_request.html_url
without boolean event_name checks. This field is:
- Populated for both 'pull_request' and 'pull_request_review' events
- Null/falsy for other event types, which causes safe fallthrough to the next || clause
- Already successfully used this way in the concurrency group logic

## Result

- pull_request (synchronize, ready_for_review, reopened): PR_URL_OVERRIDE is set directly
- pull_request_review (submitted, dismissed): PR_URL_OVERRIDE is set directly
- check_suite: PR_URL_OVERRIDE is null, falls through to CHECK_SUITE_PRS logic
- All other events: PR_URL_OVERRIDE is null, falls through to list-prs.sh

Fixes #403 not being reviewed.

Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>

* fix(dev-lead): resolve outdated comments in both applied and no-changes paths (#411)

* fix: pin GitHub Actions to specific commit SHAs per compliance standard

* fix(dev-lead): resolve outdated comments in both applied and no-changes paths

The resolve_actor_outdated_threads() safety net was only called when the
agent made no code changes. When the agent successfully addressed comments
and pushed changes, outdated review threads were never resolved.

Move resolve_actor_outdated_threads() outside the if/else block for:
- fix-reviews intent
- fix-bot-comment intent
- review-changes intent

This ensures outdated threads from the triggering reviewer are marked as
resolved regardless of whether code changes were pushed or not.

Tests: All 36 unit tests pass, including new tests validating that
resolve_actor_outdated_threads is called in the applied path (dry-run).

Resolves: PR #403 comment resolution issue

Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>

* fix(ci): correct invalid GitHub Actions cache SHA in daily-pr-review-health.yml

The actions/cache@v5.0.5 SHA was pinned to an invalid commit hash
(0c45773b...) that doesn't exist in the actions/cache repository.
Updated to the correct SHA (27d5ce7f...) used elsewhere in the repo.

This fixes the health check workflow which would fail on scheduled runs.

Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>

---------

Co-authored-by: donpetry-bot <{}+donpetry-bot@users.noreply.github.com>
Co-authored-by: Claude Haiku 4.5 <noreply@anthropic.com>

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: claude-code[bot] <claude-code[bot]@users.noreply.github.com>
Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-authored-by: Gemini CLI <gemini-cli@example.com>
Co-authored-by: don-petry <don-petry@users.noreply.github.com>
Co-authored-by: donpetry-bot <281750570+donpetry-bot@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: donpetry-bot <{}+donpetry-bot@users.noreply.github.com>
don-petry added a commit that referenced this pull request Jun 25, 2026
* chore: add CLAUDE.md with AGENTS.md reference

* fix(reviews): address PR #152 review feedback

- Add groups bundling to dependabot.yml for GitHub Actions updates
- Add prompts/ and frameworks/ directories to CLAUDE.md Repository Purpose
- Correct inaccurate "non-stub" claim; clarify which workflows are thin callers
- Add Commands section with shellcheck lint command

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* ci: Add fallback-model opus to CI Failure Analyst (#378)

Enables automatic fallback to Opus when Sonnet is rate-limited,
ensuring analyst continues functioning across rate limit boundaries.

* test(dev-lead): runtime-build PEM markers in writer redaction test (#377)

* test(dev-lead): runtime-build PEM markers in writer redaction test

The previous form embedded the literal `-----BEGIN RSA PRIVATE KEY-----`
and `-----END RSA PRIVATE KEY-----` directly in the stub script body, which
trips gitleaks's `private-key` rule on any PR that re-touches the surrounding
lines. Build the markers from a `dashes="-----"` variable inside a non-quoted
heredoc so the source no longer contains the matching literal, matching the
pattern already used by the post_no_changes PEM tests in
test_fix_reviews.bats.

No behaviour change — `bats tests/dev-lead/unit/test_engine_writer.bats`
still 33/33 green.

Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>

* test(dev-lead): loosen negative greps to catch dash-trimmed PEM leaks

Per Copilot review on #377: the previous revision tightened the negative
assertions to `grep -F "$begin"` (full `-----BEGIN/END RSA PRIVATE KEY-----`
form). That misses leaks where the wrapping dashes are altered or stripped
but the key body / phrase still slips through.

Revert the assertions to substring-only (`BEGIN RSA PRIVATE KEY` /
`END RSA PRIVATE KEY`). The runtime-built stub markers stay — they're what
keeps gitleaks happy. The substring on its own does not satisfy gitleaks's
`private-key` rule (`-----BEGIN ... -----` is required), so this stays
green on the secret scan while making the leak detection stricter.

`bats tests/dev-lead/unit/test_engine_writer.bats` — 33/33 pass.

Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Gemini CLI <gemini-cli@example.com>
Co-authored-by: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>

* fix(dev-lead): centralize git identity setup; apply to fix-ci & fix-reviews (#379)

`dev-lead-fix-issue.sh` defined a `setup_git_identity` helper locally and
called it before `git commit`. The sibling scripts `dev-lead-fix-ci.sh` and
`dev-lead-fix-reviews.sh` did not — so when triggered by `check_run` /
`pull_request_review` / `issue_comment` events, they hit:

    fatal: empty ident name (for <(null)>) not allowed
    ##[error]git commit failed — check git identity configuration on the runner

Observed in bmad-bgreat-suite#203 dev-lead runs (2026-05-23). The earlier
fix in petry-projects/.github-private PR #326 only addressed the issue
intent path; the review and CI intents kept silently failing.

Refactor:
  - Move `setup_git_identity` to a shared lib at `scripts/lib/git-identity.sh`.
  - Source it from all three dev-lead entry-point scripts.
  - Call it before any `git commit` (was previously missing in fix-ci &
    fix-reviews).
  - Drop the inline duplicate in fix-issue.

The helper itself is unchanged in behaviour.

Co-authored-by: don-petry <don-petry@users.noreply.github.com>
Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* fix(dev-lead): expose GEMINI_API_KEY so gemini fallback actually works (#381)

When Claude is rate-limited (e.g. monthly cap exhausted), engine.sh falls
back to invoking the gemini CLI. The CLI fails immediately:

  Please set an Auth method in your /home/runner/.gemini/settings.json or
  specify one of the following environment variables before running:
  GEMINI_API_KEY, GOOGLE_GENAI_USE_VERTEXAI, GOOGLE_GENAI_USE_GCA

The workflow already exposes `GOOGLE_API_KEY` (the org secret) but the
gemini CLI specifically looks for `GEMINI_API_KEY`. Alias one to the other
in every env: block that calls a dev-lead script, so the fallback path
actually has credentials when invoked.

Observed during 2026-05-23 compliance blitz: Claude monthly limit hit
(resets May 26), gemini fallback errored with the message above, every
queued dev-lead run failed → no PRs created for ~33 cycled compliance
issues.

Co-authored-by: don-petry <don-petry@users.noreply.github.com>
Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* feat(engine): in-Claude model fallback before cross-provider switch (#380)

* feat(engine): in-Claude model fallback before cross-provider switch

When a Claude model hits a per-model rate limit, walk an in-engine model
chain (e.g. sonnet → opus) before failing over to gemini/copilot. Each
Claude model has its own TPM/RPM bucket, so swapping models within Claude
often recovers without leaving the provider. Addresses the rate-limit
gap referenced in issues #195 and #206.

- Adds CLAUDE_TRIAGE/DEEP/AUDIT/ACTION/SINGLE_MODEL_CHAIN env vars,
  defaulted in engine.sh's claude branch (sonnet→opus for write/deep,
  opus→sonnet for audit/single, haiku→sonnet for triage; haiku is
  intentionally excluded from the write tier).
- New _claude_chain_invoke helper walks the chain, detects rate-limit on
  each attempt, propagates non-rate-limit failures immediately, and
  returns 2 only when every model in the chain is rate-limited.
- run_writer / run_agentic / run_triage (claude branches only) now route
  through the helper. Gemini and Copilot paths are unchanged.
- Note: in-engine fallback only helps with per-model bucket limits;
  the shared daily subscription cap still requires the proactive guard
  tracked in issue #206.

Tests: 11 new bats cases covering success-on-first, fallback-on-rl,
exhaustion-on-all-rl, non-rl propagation, whitespace tolerance, per-tier
chain selection, env override, and gemini-unchanged. All 191 existing
unit tests still pass (the 2 pre-existing fix-issue rate-limit
failures are unrelated to this change).

Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>

* fix(reviews): address review comments [skip ci-relay]

* fix(review-comments): file-based RL detection, mktemp leak, workflow gate

Addresses three gemini-code-assist findings on scripts/engine.sh and one
pre-existing dev-lead.yml gating bug that surfaced as a failing dispatch
job on this PR.

engine.sh:
- Split is_rate_limited into a regex helper (_rate_limit_pattern) plus
  two callers: the existing text-based is_rate_limited and a new
  is_rate_limited_files that runs grep directly on tmp files. Avoids
  loading multi-MB agent output into $(cat ...) shell substitutions.
- Same treatment for parse_reset_time: extracted _emit_reset_iso and
  added parse_reset_time_files.
- _claude_chain_invoke now uses both file-aware variants and cleans up
  partial mktemp output before degrading to passthrough on mktemp
  failure (previous code could leak stdout_tmp if stderr_tmp failed).

dev-lead.yml:
- The enable-auto-merge step's own env block sets INTENT_TYPE, which
  was in scope for the step's `if:` gate and made the gate always true
  whenever the step was reached, regardless of the upstream intent.
  Switched the gate to steps.intent.outputs.intent_type (step outputs
  are not shadowed by step env) and added the INTENT_PR_NUMBER guard
  already present in dev-lead-reusable.yml. This was the cause of the
  "PR_NUMBER is required" failures appearing under "Enable auto-merge
  on bot approval" on bot-approval events.

tests:
- test_fix_issue.bats: rewrote the gh stubs in the two rate-limit
  scenarios to dispatch on the gh subcommand ($1) instead of pattern
  matching against $*. The prompt body contains literal "gh api
  .../issues/..." example text from the prompt template, which made
  the api branch match before the copilot branch and masked the
  rate-limit path. Both tests were pre-existing failures on main.
- test_engine_chain.bats: 5 new cases covering the file-aware
  helpers.

Test plan:
- bats tests/dev-lead/unit/*.bats tests/test_batch_fallback.bats
  tests/test_validate_engines.bats tests/fleet_report.bats → 241/241
- shellcheck scripts/engine.sh → no new findings
- yamllint .github/workflows/dev-lead.yml → no new findings

Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>

* fix(engine): address Codex review findings on chain semantics

Codex flagged five behavioral bugs in the in-Claude chain logic. All addressed
with regression tests (test_engine_chain.bats now at 22/22).

P1 — Throttled-warning text triggered false rate-limit classification:
The chain emitted `::warning::[claude] model X rate-limited (rc=N) ...` to
stderr after each rate-limited attempt. Downstream callers that scan our
stderr/stdout with is_rate_limited (e.g. review-one-pr.sh:346–350 on triage
stderr; run_writer via `2>&1 | tee _tmp` then is_rate_limited_files _tmp)
would then misclassify a SUCCESSFUL chain fallback as a provider rate-limit
and force cross-provider switch (or, worse, remap a non-RL hard failure in a
later attempt to exit 2). Reworded the warning to "throttled (rc=N) — trying
next in chain" — none of the words match _rate_limit_pattern. Added a unit
test asserting the warning string does not match is_rate_limited.

P2 — Empty/whitespace-only chain was returning rate-limited exit code:
`final_rc` was initialized to 2; if `chain_csv` parsed to zero valid models,
the function returned 2, indistinguishable from a true rate-limit. Switched
init to 0, and added an explicit "no valid model entries" guard that returns
1 (config error) when `attempted == 0`.

P2 — run_agentic / run_writer ignored caller's explicit `model` argument:
Previously the chain unconditionally replaced the caller-supplied model for
any recognized tier, breaking the documented `[model]` parameter and any
emergency model-pin use case. Now: if the caller passes the tier's default
ENGINE_*_MODEL, the chain expands as before; if the caller passes any other
model, treat it as an explicit pin (single-element chain). Verified with two
new tests (one per function) plus a regression guard that confirms default
behavior still expands the chain on rate-limit.

Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
Co-authored-by: donpetry-bot <281750570+donpetry-bot@users.noreply.github.com>

* fix(dev-lead): set git identity before commit in commit_and_push (#369)

* fix(dev-lead): set git identity before commit in commit_and_push

actions/checkout only sets local git config for the repo it checks out
(.github-private). When the script operates on a cloned target repo in a
separate workspace, user.name and user.email are unset, causing git commit
to fail on all non-.github-private repos.

Fixes #368

Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>

* chore: apply manual instructions [skip ci-relay]

* chore: apply manual instructions [skip ci-relay]

* style: improve git-identity.sh comments and conditionals

- Add context about GitHub runner's missing git identity
- Use Bash [[ ]] conditional instead of POSIX [ ] for consistency
- Resolves CodeRabbit style suggestions

Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>

---------

Co-authored-by: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: donpetry-bot <281750570+donpetry-bot@users.noreply.github.com>

* chore(deps): bump anthropics/claude-code-action from 1.0.128 to 1.0.133 (#406)

Bumps [anthropics/claude-code-action](https://github.com/anthropics/claude-code-action) from 1.0.128 to 1.0.133.
- [Release notes](https://github.com/anthropics/claude-code-action/releases)
- [Commits](anthropics/claude-code-action@20c8abf...787c5a0)

---
updated-dependencies:
- dependency-name: anthropics/claude-code-action
  dependency-version: 1.0.133
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* fix: simplify PR_URL_OVERRIDE logic to resolve enumeration bug

## Root Cause

PR #403 was not reviewed despite the workflow running successfully.
Investigation revealed that PR_URL_OVERRIDE was evaluating to an empty
string for pull_request synchronize events, causing the workflow to skip
enumeration entirely (or fall back to list-prs.sh and silently return
no candidates).

The bug occurred because:
1. The original YAML boolean expression used complex && operators within
   || chains: (github.event_name == 'pull_request' && github.event.pull_request.html_url)
2. For some event payloads, github.event.pull_request.html_url was null
3. OR the YAML expression evaluation has precedence/scoping issues with the && operator

This caused PR_URL_OVERRIDE to fall through to the empty string default.

## Solution

Simplify the expression to directly access github.event.pull_request.html_url
without boolean event_name checks. This field is:
- Populated for both 'pull_request' and 'pull_request_review' events
- Null/falsy for other event types, which causes safe fallthrough to the next || clause
- Already successfully used this way in the concurrency group logic

## Result

- pull_request (synchronize, ready_for_review, reopened): PR_URL_OVERRIDE is set directly
- pull_request_review (submitted, dismissed): PR_URL_OVERRIDE is set directly
- check_suite: PR_URL_OVERRIDE is null, falls through to CHECK_SUITE_PRS logic
- All other events: PR_URL_OVERRIDE is null, falls through to list-prs.sh

Fixes #403 not being reviewed.

Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>

* fix(dev-lead): resolve outdated comments in both applied and no-changes paths (#411)

* fix: pin GitHub Actions to specific commit SHAs per compliance standard

* fix(dev-lead): resolve outdated comments in both applied and no-changes paths

The resolve_actor_outdated_threads() safety net was only called when the
agent made no code changes. When the agent successfully addressed comments
and pushed changes, outdated review threads were never resolved.

Move resolve_actor_outdated_threads() outside the if/else block for:
- fix-reviews intent
- fix-bot-comment intent
- review-changes intent

This ensures outdated threads from the triggering reviewer are marked as
resolved regardless of whether code changes were pushed or not.

Tests: All 36 unit tests pass, including new tests validating that
resolve_actor_outdated_threads is called in the applied path (dry-run).

Resolves: PR #403 comment resolution issue

Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>

* fix(ci): correct invalid GitHub Actions cache SHA in daily-pr-review-health.yml

The actions/cache@v5.0.5 SHA was pinned to an invalid commit hash
(0c45773b...) that doesn't exist in the actions/cache repository.
Updated to the correct SHA (27d5ce7f...) used elsewhere in the repo.

This fixes the health check workflow which would fail on scheduled runs.

Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>

---------

Co-authored-by: donpetry-bot <{}+donpetry-bot@users.noreply.github.com>
Co-authored-by: Claude Haiku 4.5 <noreply@anthropic.com>

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: claude-code[bot] <claude-code[bot]@users.noreply.github.com>
Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-authored-by: Gemini CLI <gemini-cli@example.com>
Co-authored-by: don-petry <don-petry@users.noreply.github.com>
Co-authored-by: donpetry-bot <281750570+donpetry-bot@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: donpetry-bot <{}+donpetry-bot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants