Skip to content

Remove NS1R from master#923

Merged
spacebear21 merged 1 commit intopayjoin:masterfrom
arminsabouri:move-ns1r-out-of-master
Aug 4, 2025
Merged

Remove NS1R from master#923
spacebear21 merged 1 commit intopayjoin:masterfrom
arminsabouri:move-ns1r-out-of-master

Conversation

@arminsabouri
Copy link
Collaborator

@arminsabouri arminsabouri commented Aug 4, 2025

Our v1 and v2 APIs is rapidly changing. Maintaining the NS1R implementation in its current experimental status is only adding to developer burden and slowing us down from getting to a stable 1.0 API; and by extension slowing down multiparty efforts.

The current master branch with NS1R is backed up to ns1r-master-backup.

Related ticket: #922


9897f3e6ce45b8f1fafcebd5915652fc
Although this may seem like a regression to our multiparty and research efforts its actually the contrary. NS1R demonstrated how we can upgrade BIP77 to batch transfers between multiple untrusting parties with minimal API changes. Multiparty efforts will resume; however, we should be sure that the API is "close to finished" before we do that.

@arminsabouri arminsabouri requested a review from DanGould August 4, 2025 15:20
@arminsabouri arminsabouri force-pushed the move-ns1r-out-of-master branch from f3a630d to d331447 Compare August 4, 2025 15:23
Our v1/v2 API is rapidly changing. Maintaining the NS1R
implementation in its current experimental status is only adding to
developer burden and slowing us down from getting to a stable 1.0 API.

The current master branch with NS1R is backed up to ns1r-master-backup.

Related ticket: payjoin#922
@arminsabouri arminsabouri force-pushed the move-ns1r-out-of-master branch from d331447 to 6b87adc Compare August 4, 2025 15:38
Copy link
Collaborator

@spacebear21 spacebear21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

concept ACK

Copy link
Collaborator

@nothingmuch nothingmuch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@spacebear21 spacebear21 merged commit 825051b into payjoin:master Aug 4, 2025
10 checks passed
@arminsabouri arminsabouri deleted the move-ns1r-out-of-master branch August 4, 2025 16:23
@benalleng benalleng mentioned this pull request Aug 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants