Ns1r integration test does not fail with greater than 4 senders

[benalleng]

according to this comment 4 should be the max number of senders possible but the test does not fail when senders is set to 5.

rust-payjoin/payjoin/tests/integration.rs

Lines 747 to 750 in 361c31e

	async fn do_ns1r(services: &TestServices) -> Result<(), BoxError> {
	// Anything past 4 senders will hit a max payload size error
	let num_senders = 4;
	let (_bitcoind, senders, receiver) =

[arminsabouri]

Interesting... I distinctly remeber hitting a max payload size. I guess there are some variables that could change this behavior like numbers of inputs every senders is contributing

[benalleng]

After testing this a little more I was able to get up to 24 senders, after which the test-wallet ran out of bitcoin, so perhaps this comment / whole test needs another look to make sure something else flaky isn't happening.

[Johnosezele]

Do we have an actual payload size validation

[arminsabouri]

Do we have an actual payload size validation

Yes IIRC this is a policy on the directory

Edit: its also checked by the receiver when they are decapsulating the ohttp responses

[arminsabouri]

NS1R was removed from rust-payjoin #923