feat: Add links to users and roles in ACL dialog and handle invalid entries #2436

FransGH · 2023-05-25T12:24:46Z

New Pull Request Checklist

I am not disclosing a vulnerability.
I am creating this PR in reference to an issue.

Issue Description

The PermissionsDialog currently offers no way to inspect users and roles.

Approach

This makes roles and user in the most simple way clickable and open in a separate browser window (tab).
It avoids complex in-app navigation issues by not attempting to browse within the same window and offer an option to return back to the CLP dialog.

TODOs before merging

Add tests
Add changes to documentation (guides, repository pages, in-code descriptions)

… new tab

parse-github-assistant · 2023-05-25T12:24:49Z

Thanks for opening this pull request!

🎉 We are excited about your hands-on contribution!

uffizzi-cloud · 2023-05-25T12:34:25Z

Uffizzi Ephemeral Environment `deployment-26634`

⌚ Updated May 25, 2023, 12:24 UTC

☁️ https://app.uffizzi.com/github.com/parse-community/parse-dashboard/pull/2436

📄 View Application Logs etc.

What is Uffizzi? Learn more

FransGH · 2023-05-25T12:49:41Z

The way the url is composed is a bit hackie and will clearly fail if the current location is not ../browser/..
Didn't dive that deep into the code to get a clean base url but happy with suggestions!

mtrezza · 2023-05-25T21:45:47Z

Could you add a before / after screenshot so its easier to see where the changes are?

FransGH · 2023-05-25T23:02:12Z

Screenshot from v3.2.1 vs latest alpha. Don't ask me what happened to the role-objectIds between these versions, I didn't take them out. The only visual change as a result of the PR is that the names are now blue (= default link color) as opposed to grey and the cursor changes to a pointer while hovering (standard link behaviour).

mtrezza · 2023-05-25T23:40:07Z

I've just tried it out, I think it's nicely done, for me the links are even better visible than in your screenshot:

mtrezza · 2023-05-25T23:41:07Z

The way the url is composed is a bit hackie and will clearly fail if the current location is not ../browser/..

@parse-community/dashboard any suggestion?

FransGH · 2023-05-26T09:51:01Z

There appear to be two different layouts for the permission list. One shows the object id's the other doesn't. The one with the object Id's, like in your screenshot, looks better. I see both flavours on both the older and latest dashboard depending on the object's ACL.

This is now fixed, see #2437

FransGH · 2023-05-26T09:53:35Z

mtrezza · 2023-05-26T12:59:24Z

Great, could you explain, what is the "and handle invalid entries"?

FransGH · 2023-05-26T14:35:09Z

Great, could you explain, what is the "and handle invalid entries"?
Basically fixed a bug that caused the render function to not work as intended when just one of the role or user objects was not found. With 'handling' I mean that they now explicitly appear as 'not found' on the UI.

mtrezza · 2023-05-26T14:53:06Z

Got it. That could have been a separate PR, but we can merge this as 1 since you it's already mixed.

In what cases do you think the URL approach could cause issues?

FransGH · 2023-05-26T15:16:59Z

I haven't experienced any issues with the url approach so far. It really solved a major pain I was having while migrating from user to role based ACLs. Still like to improve how the url is composed so hoping for some feedback.

mtrezza · 2023-05-26T19:07:03Z

Well if there is no feedback then let's merge as is. If it's not working someone will hopefully open an issue and we can look at it then.

Maybe you want to take a look at the code and see how that is solved at other places?

If you take a look at this for example:

parse-dashboard/src/dashboard/Data/Browser/Browser.react.js

Line 858 in 52ca7fc

getRelationURL() {

There's a generatePath import that may be helpful. It seems to be used to compose the URL from the current context.

…ionsDialog

FransGH · 2023-05-26T23:57:23Z

Yep, that worked, thx!

src/components/PermissionsDialog/PermissionsDialog.react.js

Signed-off-by: Manuel <5673677+mtrezza@users.noreply.github.com>

mtrezza

Looks good!

# [5.2.0-alpha.2](5.2.0-alpha.1...5.2.0-alpha.2) (2023-05-27) ### Features * Add links to users and roles in ACL dialog and handle invalid entries ([#2436](#2436)) ([a20cb8e](a20cb8e))

parseplatformorg · 2023-05-27T00:36:35Z

🎉 This change has been released in version 5.2.0-alpha.2

# [5.2.0-beta.2](5.2.0-beta.1...5.2.0-beta.2) (2023-06-08) ### Bug Fixes * Back button in data browser disappears after page refresh ([#2421](#2421)) ([6c5f19f](6c5f19f)) * Cannot navigate to nested relation field in data browser ([#2420](#2420)) ([e7ace9e](e7ace9e)) * Dashboard crashes when adding a row with modal in a class that contains a pointer to another class that contains an array of pointers ([#2416](#2416)) ([286269f](286269f)) * Empty table in data browser when navigating back using the "back” button ([#2423](#2423)) ([6f3dab6](6f3dab6)) * File uploading status not updating in data browser ([#2422](#2422)) ([e761f97](e761f97)) * Incorrect date picker position in data browser filter dialog ([#2425](#2425)) ([b96b48f](b96b48f)) * Option missing for Parse Config parameter to require master key ([#2440](#2440)) ([6623369](6623369)) * Scroll position is preserved when re-opening the same class in data browser via navigation bar ([#2445](#2445)) ([667675c](667675c)) * Text input cursor jumps to first position when writing long text ([#2413](#2413)) ([422ffb2](422ffb2)) ### Features * Add links to users and roles in ACL dialog and handle invalid entries ([#2436](#2436)) ([a20cb8e](a20cb8e)) * Add visual configurator for Parse Dashboard settings ([#2406](#2406)) ([228d839](228d839))

# [5.2.0-beta.2](5.2.0-beta.1...5.2.0-beta.2) (2023-06-10) ### Bug Fixes * Back button in data browser disappears after page refresh ([#2421](#2421)) ([6c5f19f](6c5f19f)) * Cannot navigate to nested relation field in data browser ([#2420](#2420)) ([e7ace9e](e7ace9e)) * Dashboard crashes when adding a row with modal in a class that contains a pointer to another class that contains an array of pointers ([#2416](#2416)) ([286269f](286269f)) * Empty table in data browser when navigating back using the "back” button ([#2423](#2423)) ([6f3dab6](6f3dab6)) * File uploading status not updating in data browser ([#2422](#2422)) ([e761f97](e761f97)) * Hitting backspace key in data browser crashes dashboard ([#2456](#2456)) ([32aeea2](32aeea2)) * Incorrect date picker position in data browser filter dialog ([#2425](#2425)) ([b96b48f](b96b48f)) * Option missing for Parse Config parameter to require master key ([#2440](#2440)) ([6623369](6623369)) * Scroll position is preserved when re-opening the same class in data browser via navigation bar ([#2445](#2445)) ([667675c](667675c)) * Text input cursor jumps to first position when writing long text ([#2413](#2413)) ([422ffb2](422ffb2)) ### Features * Add export of saved data browser filters via `classPreference` settings ([#2455](#2455)) ([f56f946](f56f946)) * Add filter views to save frequently used filters in data browser ([#2404](#2404)) ([a9ec3a9](a9ec3a9)) * Add links to users and roles in ACL dialog and handle invalid entries ([#2436](#2436)) ([a20cb8e](a20cb8e)) * Add visual configurator for Parse Dashboard settings ([#2406](#2406)) ([228d839](228d839))

parseplatformorg · 2023-06-10T14:04:35Z

🎉 This change has been released in version 5.2.0-beta.2

# [5.2.0](5.1.0...5.2.0) (2023-09-15) ### Bug Fixes * Back button in data browser disappears after page refresh ([#2421](#2421)) ([6c5f19f](6c5f19f)) * Cannot navigate to nested relation field in data browser ([#2420](#2420)) ([e7ace9e](e7ace9e)) * Dashboard crashes when adding a row with modal in a class that contains a pointer to another class that contains an array of pointers ([#2416](#2416)) ([286269f](286269f)) * Empty table in data browser when navigating back using the "back” button ([#2423](#2423)) ([6f3dab6](6f3dab6)) * File uploading status not updating in data browser ([#2422](#2422)) ([e761f97](e761f97)) * Hitting backspace key in data browser crashes dashboard ([#2456](#2456)) ([32aeea2](32aeea2)) * Incorrect date picker position in data browser filter dialog ([#2425](#2425)) ([b96b48f](b96b48f)) * Option missing for Parse Config parameter to require master key ([#2440](#2440)) ([6623369](6623369)) * Scroll position is preserved when re-opening the same class in data browser via navigation bar ([#2445](#2445)) ([667675c](667675c)) * Text input cursor jumps to first position when writing long text ([#2413](#2413)) ([422ffb2](422ffb2)) * Uncaught error when editing Number field in Edit Row dialog ([#2401](#2401)) ([26bd6fa](26bd6fa)) ### Features * Add export of saved data browser filters via `classPreference` settings ([#2455](#2455)) ([f56f946](f56f946)) * Add filter views to save frequently used filters in data browser ([#2404](#2404)) ([a9ec3a9](a9ec3a9)) * Add links to users and roles in ACL dialog and handle invalid entries ([#2436](#2436)) ([a20cb8e](a20cb8e)) * Add visual configurator for Parse Dashboard settings ([#2406](#2406)) ([228d839](228d839)) * Data types and pointer classes are sorted alphabetically in dialog to add new column ([#2400](#2400)) ([d9d285b](d9d285b)) * Sort Cloud Code Jobs alphabetically ([#2402](#2402)) ([77fc372](77fc372))

parseplatformorg · 2023-09-15T14:12:51Z

🎉 This change has been released in version 5.2.0

make users and roles in the PermissionsDialog clickable and open in a…

2e6a4ee

… new tab

FransGH changed the title ~~Browse user and roles from PermissionsDialog~~ feat: Browse user and roles from PermissionsDialog May 25, 2023

mtrezza requested a review from a team May 25, 2023 17:25

mtrezza changed the title ~~feat: Browse user and roles from PermissionsDialog~~ feat: Browse user and roles from permissions dialog May 25, 2023

mtrezza changed the title ~~feat: Browse user and roles from permissions dialog~~ feat: Browse user and roles from ACL dialog May 25, 2023

mtrezza changed the title ~~feat: Browse user and roles from ACL dialog~~ feat: Add links to users and roles in ACL dialog May 25, 2023

identify and mark invalid users and roles in PermissionsDialog

96a2dbb

FransGH changed the title ~~feat: Add links to users and roles in ACL dialog~~ feat: Add links to users and roles in ACL dialog and handle invalid entries May 26, 2023

use generatePath(this.context, ...) for composing urls in the Permiss…

e768974

…ionsDialog

mtrezza reviewed May 27, 2023

View reviewed changes

src/components/PermissionsDialog/PermissionsDialog.react.js Outdated Show resolved Hide resolved

mtrezza reviewed May 27, 2023

View reviewed changes

src/components/PermissionsDialog/PermissionsDialog.react.js Outdated Show resolved Hide resolved

restyle

e827b66

Signed-off-by: Manuel <5673677+mtrezza@users.noreply.github.com>

mtrezza approved these changes May 27, 2023

View reviewed changes

mtrezza merged commit a20cb8e into parse-community:alpha May 27, 2023

parseplatformorg added the state:released-alpha Released as alpha version label May 27, 2023

FransGH mentioned this pull request May 30, 2023

Actions resulting in opening a new browser window fail when the dashboard is not mounted on "/" (see generatePath) #2441

Open

4 tasks

mtrezza mentioned this pull request Jun 5, 2023

Identify and mark invalid users and roles in Permissions Dialog #2437

Closed

3 tasks

parseplatformorg added the state:released-beta Released as beta version label Jun 10, 2023

parseplatformorg added the state:released Released as stable version label Sep 15, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Add links to users and roles in ACL dialog and handle invalid entries #2436

feat: Add links to users and roles in ACL dialog and handle invalid entries #2436

FransGH commented May 25, 2023 •

edited

Loading

parse-github-assistant bot commented May 25, 2023 •

edited

Loading

uffizzi-cloud bot commented May 25, 2023

FransGH commented May 25, 2023

mtrezza commented May 25, 2023

FransGH commented May 25, 2023

mtrezza commented May 25, 2023 •

edited

Loading

mtrezza commented May 25, 2023

FransGH commented May 26, 2023

FransGH commented May 26, 2023

mtrezza commented May 26, 2023

FransGH commented May 26, 2023

mtrezza commented May 26, 2023

FransGH commented May 26, 2023

mtrezza commented May 26, 2023 •

edited

Loading

FransGH commented May 26, 2023 •

edited

Loading

mtrezza left a comment

parseplatformorg commented May 27, 2023

parseplatformorg commented Jun 10, 2023

parseplatformorg commented Sep 15, 2023

feat: Add links to users and roles in ACL dialog and handle invalid entries #2436

feat: Add links to users and roles in ACL dialog and handle invalid entries #2436

Conversation

FransGH commented May 25, 2023 • edited Loading

New Pull Request Checklist

Issue Description

Approach

TODOs before merging

parse-github-assistant bot commented May 25, 2023 • edited Loading

Thanks for opening this pull request!

uffizzi-cloud bot commented May 25, 2023

Uffizzi Ephemeral Environment deployment-26634

FransGH commented May 25, 2023

mtrezza commented May 25, 2023

FransGH commented May 25, 2023

mtrezza commented May 25, 2023 • edited Loading

mtrezza commented May 25, 2023

FransGH commented May 26, 2023

FransGH commented May 26, 2023

mtrezza commented May 26, 2023

FransGH commented May 26, 2023

mtrezza commented May 26, 2023

FransGH commented May 26, 2023

mtrezza commented May 26, 2023 • edited Loading

FransGH commented May 26, 2023 • edited Loading

mtrezza left a comment

Choose a reason for hiding this comment

parseplatformorg commented May 27, 2023

parseplatformorg commented Jun 10, 2023

parseplatformorg commented Sep 15, 2023

FransGH commented May 25, 2023 •

edited

Loading

parse-github-assistant bot commented May 25, 2023 •

edited

Loading

Uffizzi Ephemeral Environment `deployment-26634`

mtrezza commented May 25, 2023 •

edited

Loading

mtrezza commented May 26, 2023 •

edited

Loading

FransGH commented May 26, 2023 •

edited

Loading