Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: File uploading status not updating in data browser #2422

Merged
merged 6 commits into from
May 27, 2023
Merged

fix: File uploading status not updating in data browser #2422

merged 6 commits into from
May 27, 2023

Conversation

patelmilanun
Copy link
Member

New Pull Request Checklist

Issue Description

there was a problem of status change when u do upload a file. The problem was that even after the file is uploaded there is no way the user is getting notified of it as the field will show uploading.. even though the upload is completed.

Closes: #2274

Approach

So the issue is that we are saving the row before saving of file gets completed and thus we are not able to identify that the change has occurred. This PR resolve it by resolving the pending file upload promise if its there and than re-render the cell.

TODOs before merging

None

@parse-github-assistant
Copy link

I will reformat the title to use the proper commit message syntax.

@parse-github-assistant parse-github-assistant bot changed the title fix: file uploading status not changing fix: File uploading status not changing Apr 14, 2023
@parse-github-assistant
Copy link

parse-github-assistant bot commented Apr 14, 2023 •
edited
Loading

Thanks for opening this pull request!

  • 🎉 We are excited about your hands-on contribution!

@uffizzi-cloud
Copy link

uffizzi-cloud bot commented Apr 14, 2023

Uffizzi Ephemeral Environment deployment-22315

⌚ Updated Apr 14, 2023, 18:46 UTC

☁️ https://app.uffizzi.com/github.com/parse-community/parse-dashboard/pull/2422

📄 View Application Logs etc.

What is Uffizzi? Learn more

@patelmilanun
Copy link
Member Author

How one can see the preview build which uses mongodb as the given preview url is using postgreSQL

@mtrezza
Copy link
Member

mtrezza commented Apr 15, 2023

What do you mean

@patelmilanun
Copy link
Member Author

So if I open the preview link generated with Uffizzi, we are not able to do file upload as it is integrated with mongoDB only I think, and in order to take a look at if my changes fixed the issue or not the preview link should use mongoDB. If u look at the logs for the build you can see we are using PostgreSQL and not the mongoDB. This problem is specific to mongoDB.

So for case like this where we have to only see our changes using mongoDB as our database is it possible?

@mtrezza
Copy link
Member

mtrezza commented Apr 16, 2023

Got it, the current set up is limited to what it is. We could look into expanding this, but that's a separate issue we'd need to explore. For now we'd just test this locally and merge if we can verify the issue is fixed.

@mtrezza mtrezza changed the title fix: File uploading status not changing fix: File uploading status not changing in data browser May 27, 2023
@mtrezza mtrezza changed the title fix: File uploading status not changing in data browser fix: File uploading status not updating in data browser May 27, 2023
mtrezza
mtrezza approved these changes May 27, 2023
View reviewed changes
Copy link
Member

@mtrezza mtrezza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@mtrezza mtrezza merged commit e761f97 into parse-community:alpha May 27, 2023
parseplatformorg pushed a commit that referenced this pull request May 27, 2023
@semantic-release-bot
chore(release): 5.2.0-alpha.7 [skip ci]
1b23966 
# [5.2.0-alpha.7](5.2.0-alpha.6...5.2.0-alpha.7) (2023-05-27)

### Bug Fixes

* File uploading status not updating in data browser ([#2422](#2422)) ([e761f97](e761f97))
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 5.2.0-alpha.7

@parseplatformorg parseplatformorg added the state:released-alpha Released as alpha version label May 27, 2023
parseplatformorg pushed a commit that referenced this pull request Jun 8, 2023
@semantic-release-bot
chore(release): 5.2.0-beta.2 [skip ci]
4f8e35e 
# [5.2.0-beta.2](5.2.0-beta.1...5.2.0-beta.2) (2023-06-08)

### Bug Fixes

* Back button in data browser disappears after page refresh ([#2421](#2421)) ([6c5f19f](6c5f19f))
* Cannot navigate to nested relation field in data browser ([#2420](#2420)) ([e7ace9e](e7ace9e))
* Dashboard crashes when adding a row with modal in a class that contains a pointer to another class that contains an array of pointers ([#2416](#2416)) ([286269f](286269f))
* Empty table in data browser when navigating back using the "back” button ([#2423](#2423)) ([6f3dab6](6f3dab6))
* File uploading status not updating in data browser ([#2422](#2422)) ([e761f97](e761f97))
* Incorrect date picker position in data browser filter dialog ([#2425](#2425)) ([b96b48f](b96b48f))
* Option missing for Parse Config parameter to require master key ([#2440](#2440)) ([6623369](6623369))
* Scroll position is preserved when re-opening the same class in data browser via navigation bar ([#2445](#2445)) ([667675c](667675c))
* Text input cursor jumps to first position when writing long text ([#2413](#2413)) ([422ffb2](422ffb2))

### Features

* Add links to users and roles in ACL dialog and handle invalid entries ([#2436](#2436)) ([a20cb8e](a20cb8e))
* Add visual configurator for Parse Dashboard settings ([#2406](#2406)) ([228d839](228d839))
parseplatformorg pushed a commit that referenced this pull request Jun 8, 2023
@semantic-release-bot
chore(release): 5.2.0-beta.2 [skip ci]
a880b1a 
# [5.2.0-beta.2](5.2.0-beta.1...5.2.0-beta.2) (2023-06-08)

### Bug Fixes

* Back button in data browser disappears after page refresh ([#2421](#2421)) ([6c5f19f](6c5f19f))
* Cannot navigate to nested relation field in data browser ([#2420](#2420)) ([e7ace9e](e7ace9e))
* Dashboard crashes when adding a row with modal in a class that contains a pointer to another class that contains an array of pointers ([#2416](#2416)) ([286269f](286269f))
* Empty table in data browser when navigating back using the "back” button ([#2423](#2423)) ([6f3dab6](6f3dab6))
* File uploading status not updating in data browser ([#2422](#2422)) ([e761f97](e761f97))
* Incorrect date picker position in data browser filter dialog ([#2425](#2425)) ([b96b48f](b96b48f))
* Option missing for Parse Config parameter to require master key ([#2440](#2440)) ([6623369](6623369))
* Scroll position is preserved when re-opening the same class in data browser via navigation bar ([#2445](#2445)) ([667675c](667675c))
* Text input cursor jumps to first position when writing long text ([#2413](#2413)) ([422ffb2](422ffb2))

### Features

* Add links to users and roles in ACL dialog and handle invalid entries ([#2436](#2436)) ([a20cb8e](a20cb8e))
* Add visual configurator for Parse Dashboard settings ([#2406](#2406)) ([228d839](228d839))
parseplatformorg pushed a commit that referenced this pull request Jun 8, 2023
@semantic-release-bot
chore(release): 5.2.0-beta.2 [skip ci]
ecfcd03 
# [5.2.0-beta.2](5.2.0-beta.1...5.2.0-beta.2) (2023-06-08)

### Bug Fixes

* Back button in data browser disappears after page refresh ([#2421](#2421)) ([6c5f19f](6c5f19f))
* Cannot navigate to nested relation field in data browser ([#2420](#2420)) ([e7ace9e](e7ace9e))
* Dashboard crashes when adding a row with modal in a class that contains a pointer to another class that contains an array of pointers ([#2416](#2416)) ([286269f](286269f))
* Empty table in data browser when navigating back using the "back” button ([#2423](#2423)) ([6f3dab6](6f3dab6))
* File uploading status not updating in data browser ([#2422](#2422)) ([e761f97](e761f97))
* Incorrect date picker position in data browser filter dialog ([#2425](#2425)) ([b96b48f](b96b48f))
* Option missing for Parse Config parameter to require master key ([#2440](#2440)) ([6623369](6623369))
* Scroll position is preserved when re-opening the same class in data browser via navigation bar ([#2445](#2445)) ([667675c](667675c))
* Text input cursor jumps to first position when writing long text ([#2413](#2413)) ([422ffb2](422ffb2))

### Features

* Add links to users and roles in ACL dialog and handle invalid entries ([#2436](#2436)) ([a20cb8e](a20cb8e))
* Add visual configurator for Parse Dashboard settings ([#2406](#2406)) ([228d839](228d839))
@mtrezza mtrezza mentioned this pull request Jun 9, 2023
Closed
4 tasks
parseplatformorg pushed a commit that referenced this pull request Jun 10, 2023
@semantic-release-bot
chore(release): 5.2.0-beta.2 [skip ci]
057fc8b 
# [5.2.0-beta.2](5.2.0-beta.1...5.2.0-beta.2) (2023-06-10)

### Bug Fixes

* Back button in data browser disappears after page refresh ([#2421](#2421)) ([6c5f19f](6c5f19f))
* Cannot navigate to nested relation field in data browser ([#2420](#2420)) ([e7ace9e](e7ace9e))
* Dashboard crashes when adding a row with modal in a class that contains a pointer to another class that contains an array of pointers ([#2416](#2416)) ([286269f](286269f))
* Empty table in data browser when navigating back using the "back” button ([#2423](#2423)) ([6f3dab6](6f3dab6))
* File uploading status not updating in data browser ([#2422](#2422)) ([e761f97](e761f97))
* Hitting backspace key in data browser crashes dashboard ([#2456](#2456)) ([32aeea2](32aeea2))
* Incorrect date picker position in data browser filter dialog ([#2425](#2425)) ([b96b48f](b96b48f))
* Option missing for Parse Config parameter to require master key ([#2440](#2440)) ([6623369](6623369))
* Scroll position is preserved when re-opening the same class in data browser via navigation bar ([#2445](#2445)) ([667675c](667675c))
* Text input cursor jumps to first position when writing long text ([#2413](#2413)) ([422ffb2](422ffb2))

### Features

* Add export of saved data browser filters via `classPreference` settings ([#2455](#2455)) ([f56f946](f56f946))
* Add filter views to save frequently used filters in data browser ([#2404](#2404)) ([a9ec3a9](a9ec3a9))
* Add links to users and roles in ACL dialog and handle invalid entries ([#2436](#2436)) ([a20cb8e](a20cb8e))
* Add visual configurator for Parse Dashboard settings ([#2406](#2406)) ([228d839](228d839))
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 5.2.0-beta.2

@parseplatformorg parseplatformorg added the state:released-beta Released as beta version label Jun 10, 2023
parseplatformorg pushed a commit that referenced this pull request Sep 15, 2023
@semantic-release-bot
chore(release): 5.2.0 [skip ci]
5b85740 
# [5.2.0](5.1.0...5.2.0) (2023-09-15)

### Bug Fixes

* Back button in data browser disappears after page refresh ([#2421](#2421)) ([6c5f19f](6c5f19f))
* Cannot navigate to nested relation field in data browser ([#2420](#2420)) ([e7ace9e](e7ace9e))
* Dashboard crashes when adding a row with modal in a class that contains a pointer to another class that contains an array of pointers ([#2416](#2416)) ([286269f](286269f))
* Empty table in data browser when navigating back using the "back” button ([#2423](#2423)) ([6f3dab6](6f3dab6))
* File uploading status not updating in data browser ([#2422](#2422)) ([e761f97](e761f97))
* Hitting backspace key in data browser crashes dashboard ([#2456](#2456)) ([32aeea2](32aeea2))
* Incorrect date picker position in data browser filter dialog ([#2425](#2425)) ([b96b48f](b96b48f))
* Option missing for Parse Config parameter to require master key ([#2440](#2440)) ([6623369](6623369))
* Scroll position is preserved when re-opening the same class in data browser via navigation bar ([#2445](#2445)) ([667675c](667675c))
* Text input cursor jumps to first position when writing long text ([#2413](#2413)) ([422ffb2](422ffb2))
* Uncaught error when editing Number field in Edit Row dialog ([#2401](#2401)) ([26bd6fa](26bd6fa))

### Features

* Add export of saved data browser filters via `classPreference` settings ([#2455](#2455)) ([f56f946](f56f946))
* Add filter views to save frequently used filters in data browser ([#2404](#2404)) ([a9ec3a9](a9ec3a9))
* Add links to users and roles in ACL dialog and handle invalid entries ([#2436](#2436)) ([a20cb8e](a20cb8e))
* Add visual configurator for Parse Dashboard settings ([#2406](#2406)) ([228d839](228d839))
* Data types and pointer classes are sorted alphabetically in dialog to add new column ([#2400](#2400)) ([d9d285b](d9d285b))
* Sort Cloud Code Jobs alphabetically ([#2402](#2402)) ([77fc372](77fc372))
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 5.2.0

@parseplatformorg parseplatformorg added the state:released Released as stable version label Sep 15, 2023
beiguancyc pushed a commit to beiguancyc/parse-dashboard that referenced this pull request Sep 20, 2023
@cycqitianwushuge
Merge branch 'release'
e2e8af1 
* release: (41 commits)
  chore(release): 5.2.0 [skip ci]
  release
  chore(release): 5.2.0-beta.2 [skip ci]
  empty commit
  chore(release): 5.2.0-alpha.14 [skip ci]
  fix: Hitting backspace key in data browser crashes dashboard (parse-community#2456)
  chore(release): 5.2.0-alpha.13 [skip ci]
  feat: Add export of saved data browser filters via `classPreference` settings (parse-community#2455)
  chore(release): 5.2.0-alpha.12 [skip ci]
  feat: Add filter views to save frequently used filters in data browser (parse-community#2404)
  chore(release): 5.2.0-alpha.11 [skip ci]
  fix: Scroll position is preserved when re-opening the same class in data browser via navigation bar (parse-community#2445)
  chore(release): 5.2.0-alpha.10 [skip ci]
  fix: Option missing for Parse Config parameter to require master key (parse-community#2440)
  chore(release): 5.2.0-alpha.9 [skip ci]
  fix: Dashboard crashes when adding a row with modal in a class that contains a pointer to another class that contains an array of pointers (parse-community#2416)
  chore(release): 5.2.0-alpha.8 [skip ci]
  fix: Cannot navigate to nested relation field in data browser (parse-community#2420)
  chore(release): 5.2.0-alpha.7 [skip ci]
  fix: File uploading status not updating in data browser (parse-community#2422)
  ...

# Conflicts:
#	package-lock.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtrezza mtrezza mtrezza approved these changes

Assignees
No one assigned
Labels
state:released Released as stable version state:released-alpha Released as alpha version state:released-beta Released as beta version
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

File uploading status not changing after uploading completed
3 participants
@patelmilanun @mtrezza @parseplatformorg