Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Dashboard crashes when adding a row with modal in a class that contains a pointer to another class that contains an array of pointers #2416

Merged
merged 3 commits into from
May 27, 2023
Merged

fix: Dashboard crashes when adding a row with modal in a class that contains a pointer to another class that contains an array of pointers #2416

merged 3 commits into from
May 27, 2023

Conversation

TravisHeaver
Copy link
Contributor

@TravisHeaver TravisHeaver commented Apr 10, 2023 •
edited by mtrezza
Loading

New Pull Request Checklist

Issue Description

Closes: #2426

Make sure there is an onPointerClick when setting the copyableValue, if not fallback to stringify.

The crash happens occurs when adding a new row via the modal then selecting a filed to add where the class being added has a field type array of pointers

[Error] TypeError: undefined is not an object (evaluating 'it.bind')

(anonymous function) (bind.js:7)
(anonymous function) (BrowserCell.react.js:194:116)
map
renderCellContent (BrowserCell.react.js:184:137)
componentDidMount (BrowserCell.react.js:540)
commitLifeCycles (react-dom.development.js:19814)
commitLayoutEffects (react-dom.development.js:22803)
callCallback (react-dom.development.js:188)
dispatchEvent
invokeGuardedCallbackDev (react-dom.development.js:237)
invokeGuardedCallback (react-dom.development.js:292)
commitRootImpl (react-dom.development.js:22541)
commitRootImpl
unstable_runWithPriority (scheduler.development.js:653)
commitRoot (react-dom.development.js:22381)
finishSyncRender (react-dom.development.js:21807)
performSyncWorkOnRoot (react-dom.development.js:21793)
performSyncWorkOnRoot
(anonymous function) (react-dom.development.js:11089)
unstable_runWithPriority (scheduler.development.js:653)
flushSyncCallbackQueueImpl (react-dom.development.js:11084)
flushSyncCallbackQueue (react-dom.development.js:11072)
scheduleUpdateOnFiber (react-dom.development.js:21199)
enqueueSetState (react-dom.development.js:12639)
(anonymous function) (react.development.js:471)
_callee3$ (ObjectPickerDialog.react.js:245)
tryCatch (regeneratorRuntime.js:53)
(anonymous function) (regeneratorRuntime.js:135)
asyncGeneratorStep (asyncToGenerator.js:9)
_next (asyncToGenerator.js:28)

Approach

TODOs before merging

  • Add tests
  • Add changes to documentation (guides, repository pages, in-code descriptions)

@TravisHeaver
Make sure there is an onPointerClick when setting the copyableValue, …
f8a668c 
…if not fallback to stringify.

The crash happens occurs when adding a new row via the modal then selecting a filed to add where the class being added has a field type array of pointers

[Error] TypeError: undefined is not an object (evaluating 'it.bind')

	(anonymous function) (bind.js:7)
	(anonymous function) (BrowserCell.react.js:194:116)
	map
	renderCellContent (BrowserCell.react.js:184:137)
	componentDidMount (BrowserCell.react.js:540)
	commitLifeCycles (react-dom.development.js:19814)
	commitLayoutEffects (react-dom.development.js:22803)
	callCallback (react-dom.development.js:188)
	dispatchEvent
	invokeGuardedCallbackDev (react-dom.development.js:237)
	invokeGuardedCallback (react-dom.development.js:292)
	commitRootImpl (react-dom.development.js:22541)
	commitRootImpl
	unstable_runWithPriority (scheduler.development.js:653)
	commitRoot (react-dom.development.js:22381)
	finishSyncRender (react-dom.development.js:21807)
	performSyncWorkOnRoot (react-dom.development.js:21793)
	performSyncWorkOnRoot
	(anonymous function) (react-dom.development.js:11089)
	unstable_runWithPriority (scheduler.development.js:653)
	flushSyncCallbackQueueImpl (react-dom.development.js:11084)
	flushSyncCallbackQueue (react-dom.development.js:11072)
	scheduleUpdateOnFiber (react-dom.development.js:21199)
	enqueueSetState (react-dom.development.js:12639)
	(anonymous function) (react.development.js:471)
	_callee3$ (ObjectPickerDialog.react.js:245)
	tryCatch (regeneratorRuntime.js:53)
	(anonymous function) (regeneratorRuntime.js:135)
	asyncGeneratorStep (asyncToGenerator.js:9)
	_next (asyncToGenerator.js:28)
@parse-github-assistant
Copy link

I will reformat the title to use the proper commit message syntax.

@parse-github-assistant parse-github-assistant bot changed the title fix: add row with modal TypeError: undefined is not an object fix: Add row with modal TypeError: undefined is not an object Apr 10, 2023
@parse-github-assistant
Copy link

parse-github-assistant bot commented Apr 10, 2023 •
edited
Loading

Thanks for opening this pull request!

  • 🎉 We are excited about your hands-on contribution!

@uffizzi-cloud
Copy link

uffizzi-cloud bot commented Apr 10, 2023

Uffizzi Ephemeral Environment deployment-21819

⌚ Updated Apr 10, 2023, 23:46 UTC

☁️ https://app.uffizzi.com/github.com/parse-community/parse-dashboard/pull/2416

📄 View Application Logs etc.

What is Uffizzi? Learn more

@mtrezza mtrezza requested a review from a team April 20, 2023 22:44
@mtrezza mtrezza changed the title fix: Add row with modal TypeError: undefined is not an object fix: Dashboard crashes when adding a row with modal in a class that contains a pointer to another class that contains an array of pointers May 27, 2023
@mtrezza mtrezza merged commit 286269f into parse-community:alpha May 27, 2023
parseplatformorg pushed a commit that referenced this pull request May 27, 2023
@semantic-release-bot
chore(release): 5.2.0-alpha.9 [skip ci]
34b7f83 
# [5.2.0-alpha.9](5.2.0-alpha.8...5.2.0-alpha.9) (2023-05-27)

### Bug Fixes

* Dashboard crashes when adding a row with modal in a class that contains a pointer to another class that contains an array of pointers ([#2416](#2416)) ([286269f](286269f))
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 5.2.0-alpha.9

@parseplatformorg parseplatformorg added the state:released-alpha Released as alpha version label May 27, 2023
parseplatformorg pushed a commit that referenced this pull request Jun 8, 2023
@semantic-release-bot
chore(release): 5.2.0-beta.2 [skip ci]
4f8e35e 
# [5.2.0-beta.2](5.2.0-beta.1...5.2.0-beta.2) (2023-06-08)

### Bug Fixes

* Back button in data browser disappears after page refresh ([#2421](#2421)) ([6c5f19f](6c5f19f))
* Cannot navigate to nested relation field in data browser ([#2420](#2420)) ([e7ace9e](e7ace9e))
* Dashboard crashes when adding a row with modal in a class that contains a pointer to another class that contains an array of pointers ([#2416](#2416)) ([286269f](286269f))
* Empty table in data browser when navigating back using the "back” button ([#2423](#2423)) ([6f3dab6](6f3dab6))
* File uploading status not updating in data browser ([#2422](#2422)) ([e761f97](e761f97))
* Incorrect date picker position in data browser filter dialog ([#2425](#2425)) ([b96b48f](b96b48f))
* Option missing for Parse Config parameter to require master key ([#2440](#2440)) ([6623369](6623369))
* Scroll position is preserved when re-opening the same class in data browser via navigation bar ([#2445](#2445)) ([667675c](667675c))
* Text input cursor jumps to first position when writing long text ([#2413](#2413)) ([422ffb2](422ffb2))

### Features

* Add links to users and roles in ACL dialog and handle invalid entries ([#2436](#2436)) ([a20cb8e](a20cb8e))
* Add visual configurator for Parse Dashboard settings ([#2406](#2406)) ([228d839](228d839))
parseplatformorg pushed a commit that referenced this pull request Jun 8, 2023
@semantic-release-bot
chore(release): 5.2.0-beta.2 [skip ci]
a880b1a 
# [5.2.0-beta.2](5.2.0-beta.1...5.2.0-beta.2) (2023-06-08)

### Bug Fixes

* Back button in data browser disappears after page refresh ([#2421](#2421)) ([6c5f19f](6c5f19f))
* Cannot navigate to nested relation field in data browser ([#2420](#2420)) ([e7ace9e](e7ace9e))
* Dashboard crashes when adding a row with modal in a class that contains a pointer to another class that contains an array of pointers ([#2416](#2416)) ([286269f](286269f))
* Empty table in data browser when navigating back using the "back” button ([#2423](#2423)) ([6f3dab6](6f3dab6))
* File uploading status not updating in data browser ([#2422](#2422)) ([e761f97](e761f97))
* Incorrect date picker position in data browser filter dialog ([#2425](#2425)) ([b96b48f](b96b48f))
* Option missing for Parse Config parameter to require master key ([#2440](#2440)) ([6623369](6623369))
* Scroll position is preserved when re-opening the same class in data browser via navigation bar ([#2445](#2445)) ([667675c](667675c))
* Text input cursor jumps to first position when writing long text ([#2413](#2413)) ([422ffb2](422ffb2))

### Features

* Add links to users and roles in ACL dialog and handle invalid entries ([#2436](#2436)) ([a20cb8e](a20cb8e))
* Add visual configurator for Parse Dashboard settings ([#2406](#2406)) ([228d839](228d839))
parseplatformorg pushed a commit that referenced this pull request Jun 8, 2023
@semantic-release-bot
chore(release): 5.2.0-beta.2 [skip ci]
ecfcd03 
# [5.2.0-beta.2](5.2.0-beta.1...5.2.0-beta.2) (2023-06-08)

### Bug Fixes

* Back button in data browser disappears after page refresh ([#2421](#2421)) ([6c5f19f](6c5f19f))
* Cannot navigate to nested relation field in data browser ([#2420](#2420)) ([e7ace9e](e7ace9e))
* Dashboard crashes when adding a row with modal in a class that contains a pointer to another class that contains an array of pointers ([#2416](#2416)) ([286269f](286269f))
* Empty table in data browser when navigating back using the "back” button ([#2423](#2423)) ([6f3dab6](6f3dab6))
* File uploading status not updating in data browser ([#2422](#2422)) ([e761f97](e761f97))
* Incorrect date picker position in data browser filter dialog ([#2425](#2425)) ([b96b48f](b96b48f))
* Option missing for Parse Config parameter to require master key ([#2440](#2440)) ([6623369](6623369))
* Scroll position is preserved when re-opening the same class in data browser via navigation bar ([#2445](#2445)) ([667675c](667675c))
* Text input cursor jumps to first position when writing long text ([#2413](#2413)) ([422ffb2](422ffb2))

### Features

* Add links to users and roles in ACL dialog and handle invalid entries ([#2436](#2436)) ([a20cb8e](a20cb8e))
* Add visual configurator for Parse Dashboard settings ([#2406](#2406)) ([228d839](228d839))
parseplatformorg pushed a commit that referenced this pull request Jun 10, 2023
@semantic-release-bot
chore(release): 5.2.0-beta.2 [skip ci]
057fc8b 
# [5.2.0-beta.2](5.2.0-beta.1...5.2.0-beta.2) (2023-06-10)

### Bug Fixes

* Back button in data browser disappears after page refresh ([#2421](#2421)) ([6c5f19f](6c5f19f))
* Cannot navigate to nested relation field in data browser ([#2420](#2420)) ([e7ace9e](e7ace9e))
* Dashboard crashes when adding a row with modal in a class that contains a pointer to another class that contains an array of pointers ([#2416](#2416)) ([286269f](286269f))
* Empty table in data browser when navigating back using the "back” button ([#2423](#2423)) ([6f3dab6](6f3dab6))
* File uploading status not updating in data browser ([#2422](#2422)) ([e761f97](e761f97))
* Hitting backspace key in data browser crashes dashboard ([#2456](#2456)) ([32aeea2](32aeea2))
* Incorrect date picker position in data browser filter dialog ([#2425](#2425)) ([b96b48f](b96b48f))
* Option missing for Parse Config parameter to require master key ([#2440](#2440)) ([6623369](6623369))
* Scroll position is preserved when re-opening the same class in data browser via navigation bar ([#2445](#2445)) ([667675c](667675c))
* Text input cursor jumps to first position when writing long text ([#2413](#2413)) ([422ffb2](422ffb2))

### Features

* Add export of saved data browser filters via `classPreference` settings ([#2455](#2455)) ([f56f946](f56f946))
* Add filter views to save frequently used filters in data browser ([#2404](#2404)) ([a9ec3a9](a9ec3a9))
* Add links to users and roles in ACL dialog and handle invalid entries ([#2436](#2436)) ([a20cb8e](a20cb8e))
* Add visual configurator for Parse Dashboard settings ([#2406](#2406)) ([228d839](228d839))
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 5.2.0-beta.2

@parseplatformorg parseplatformorg added the state:released-beta Released as beta version label Jun 10, 2023
parseplatformorg pushed a commit that referenced this pull request Sep 15, 2023
@semantic-release-bot
chore(release): 5.2.0 [skip ci]
5b85740 
# [5.2.0](5.1.0...5.2.0) (2023-09-15)

### Bug Fixes

* Back button in data browser disappears after page refresh ([#2421](#2421)) ([6c5f19f](6c5f19f))
* Cannot navigate to nested relation field in data browser ([#2420](#2420)) ([e7ace9e](e7ace9e))
* Dashboard crashes when adding a row with modal in a class that contains a pointer to another class that contains an array of pointers ([#2416](#2416)) ([286269f](286269f))
* Empty table in data browser when navigating back using the "back” button ([#2423](#2423)) ([6f3dab6](6f3dab6))
* File uploading status not updating in data browser ([#2422](#2422)) ([e761f97](e761f97))
* Hitting backspace key in data browser crashes dashboard ([#2456](#2456)) ([32aeea2](32aeea2))
* Incorrect date picker position in data browser filter dialog ([#2425](#2425)) ([b96b48f](b96b48f))
* Option missing for Parse Config parameter to require master key ([#2440](#2440)) ([6623369](6623369))
* Scroll position is preserved when re-opening the same class in data browser via navigation bar ([#2445](#2445)) ([667675c](667675c))
* Text input cursor jumps to first position when writing long text ([#2413](#2413)) ([422ffb2](422ffb2))
* Uncaught error when editing Number field in Edit Row dialog ([#2401](#2401)) ([26bd6fa](26bd6fa))

### Features

* Add export of saved data browser filters via `classPreference` settings ([#2455](#2455)) ([f56f946](f56f946))
* Add filter views to save frequently used filters in data browser ([#2404](#2404)) ([a9ec3a9](a9ec3a9))
* Add links to users and roles in ACL dialog and handle invalid entries ([#2436](#2436)) ([a20cb8e](a20cb8e))
* Add visual configurator for Parse Dashboard settings ([#2406](#2406)) ([228d839](228d839))
* Data types and pointer classes are sorted alphabetically in dialog to add new column ([#2400](#2400)) ([d9d285b](d9d285b))
* Sort Cloud Code Jobs alphabetically ([#2402](#2402)) ([77fc372](77fc372))
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 5.2.0

@parseplatformorg parseplatformorg added the state:released Released as stable version label Sep 15, 2023
beiguancyc pushed a commit to beiguancyc/parse-dashboard that referenced this pull request Sep 20, 2023
@cycqitianwushuge
Merge branch 'release'
e2e8af1 
* release: (41 commits)
  chore(release): 5.2.0 [skip ci]
  release
  chore(release): 5.2.0-beta.2 [skip ci]
  empty commit
  chore(release): 5.2.0-alpha.14 [skip ci]
  fix: Hitting backspace key in data browser crashes dashboard (parse-community#2456)
  chore(release): 5.2.0-alpha.13 [skip ci]
  feat: Add export of saved data browser filters via `classPreference` settings (parse-community#2455)
  chore(release): 5.2.0-alpha.12 [skip ci]
  feat: Add filter views to save frequently used filters in data browser (parse-community#2404)
  chore(release): 5.2.0-alpha.11 [skip ci]
  fix: Scroll position is preserved when re-opening the same class in data browser via navigation bar (parse-community#2445)
  chore(release): 5.2.0-alpha.10 [skip ci]
  fix: Option missing for Parse Config parameter to require master key (parse-community#2440)
  chore(release): 5.2.0-alpha.9 [skip ci]
  fix: Dashboard crashes when adding a row with modal in a class that contains a pointer to another class that contains an array of pointers (parse-community#2416)
  chore(release): 5.2.0-alpha.8 [skip ci]
  fix: Cannot navigate to nested relation field in data browser (parse-community#2420)
  chore(release): 5.2.0-alpha.7 [skip ci]
  fix: File uploading status not updating in data browser (parse-community#2422)
  ...

# Conflicts:
#	package-lock.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtrezza mtrezza mtrezza approved these changes

Assignees
No one assigned
Labels
state:released Released as stable version state:released-alpha Released as alpha version state:released-beta Released as beta version
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add row with modal causes crash in BrowserCell.react.js
3 participants
@TravisHeaver @parseplatformorg @mtrezza