Port safe commits from master to polkadot-staging #2761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* move Chain::ID from relay-level Chain to primitives-level Chain * removed chain IDs from bp-runtime * add missing file header
svyatonik
added
the
A-chores
* some code grooming: enable warn(missing_docs) for all piblic crates + added missing documentation + removed obsolete clippy/deny workarounds * removed strange allow + added comment related to other allow * removed incorrect_clone_impl_on_copy_type which is unknown to CI clippy
svyatonik
force-pushed
the
port-safe-commits-from-master
branch
from
83b7e47
to
a31dc48
Compare
|
Actually, there's a lot of changes that I'm going to port (#2457), so maybe it is better to have multiple PRs. So let's start with that one |
serban300
approved these changes
Jan 3, 2024
serban300
pushed a commit
to serban300/parity-bridges-common
that referenced
this pull request
Mar 27, 2024
* introduce bp_messages::ChainWithMessages (paritytech#2171) * Move Chain::ID from relay-level Chain to primitives-level Chain (paritytech#2181) * move Chain::ID from relay-level Chain to primitives-level Chain * removed chain IDs from bp-runtime * add missing file header * Some code grooming (paritytech#2276) * some code grooming: enable warn(missing_docs) for all piblic crates + added missing documentation + removed obsolete clippy/deny workarounds * removed strange allow + added comment related to other allow * removed incorrect_clone_impl_on_copy_type which is unknown to CI clippy
serban300
pushed a commit
to serban300/parity-bridges-common
that referenced
this pull request
Apr 8, 2024
* introduce bp_messages::ChainWithMessages (paritytech#2171) * Move Chain::ID from relay-level Chain to primitives-level Chain (paritytech#2181) * move Chain::ID from relay-level Chain to primitives-level Chain * removed chain IDs from bp-runtime * add missing file header * Some code grooming (paritytech#2276) * some code grooming: enable warn(missing_docs) for all piblic crates + added missing documentation + removed obsolete clippy/deny workarounds * removed strange allow + added comment related to other allow * removed incorrect_clone_impl_on_copy_type which is unknown to CI clippy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
opening early for visibility - could be reviewed commit-by-commit
Since we are now closer to moving to
polkadot-sdkthan to developingbridges-v2+ some parts of v2 have been already merged to thepolkadot-staging, maybe we should start picking some commits from master and merge them topolkadot-staging. I'll start with safe commits that are not touching any critical code pieces. The final goal is to have #2457 inpolkadot-staging- it'll should make bridges configuration much easier. So in next updates of polkadot-sdk and fellowship runtimes we'll decrease LOCs dedicated to bridges configuration.All
v2stuff (dynamic lanes, relayers protocol) will stay in master.Additionally, it'll make backporting easier - right now not having #2171 and #2181 in
polkadot-stagingis painful