Some code grooming #2276
Merged
Some code grooming #2276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… added missing documentation + removed obsolete clippy/deny workarounds
svyatonik
added
the
A-chores
bkontur
approved these changes
Jul 17, 2023
I'd avoid that - imo let's not push commits that are not strongly necessary there. We can update that later, during next "big merge" step. |
svyatonik
pushed a commit
that referenced
this pull request
Jul 17, 2023
…2289) * Brigehub: Add in force upgrade xcm version. (Same as assets and collectives) * [Fix] Allow force_xcm_version call for assets parachains (#2276) * add force_xcm_version to safe calls (#2284) * Removing duplication --------- Co-authored-by: Roman Useinov <roman.useinov@gmail.com> Co-authored-by: joe petrowski <25483142+joepetrowski@users.noreply.github.com>
svyatonik
added a commit
that referenced
this pull request
Dec 27, 2023
* some code grooming: enable warn(missing_docs) for all piblic crates + added missing documentation + removed obsolete clippy/deny workarounds * removed strange allow + added comment related to other allow * removed incorrect_clone_impl_on_copy_type which is unknown to CI clippy
svyatonik
added a commit
that referenced
this pull request
Dec 28, 2023
* some code grooming: enable warn(missing_docs) for all piblic crates + added missing documentation + removed obsolete clippy/deny workarounds * removed strange allow + added comment related to other allow * removed incorrect_clone_impl_on_copy_type which is unknown to CI clippy
svyatonik
added a commit
that referenced
this pull request
Jan 11, 2024
* introduce bp_messages::ChainWithMessages (#2171) * Move Chain::ID from relay-level Chain to primitives-level Chain (#2181) * move Chain::ID from relay-level Chain to primitives-level Chain * removed chain IDs from bp-runtime * add missing file header * Some code grooming (#2276) * some code grooming: enable warn(missing_docs) for all piblic crates + added missing documentation + removed obsolete clippy/deny workarounds * removed strange allow + added comment related to other allow * removed incorrect_clone_impl_on_copy_type which is unknown to CI clippy
serban300
pushed a commit
to serban300/parity-bridges-common
that referenced
this pull request
Mar 27, 2024
* introduce bp_messages::ChainWithMessages (paritytech#2171) * Move Chain::ID from relay-level Chain to primitives-level Chain (paritytech#2181) * move Chain::ID from relay-level Chain to primitives-level Chain * removed chain IDs from bp-runtime * add missing file header * Some code grooming (paritytech#2276) * some code grooming: enable warn(missing_docs) for all piblic crates + added missing documentation + removed obsolete clippy/deny workarounds * removed strange allow + added comment related to other allow * removed incorrect_clone_impl_on_copy_type which is unknown to CI clippy
serban300
pushed a commit
to serban300/parity-bridges-common
that referenced
this pull request
Apr 8, 2024
* introduce bp_messages::ChainWithMessages (paritytech#2171) * Move Chain::ID from relay-level Chain to primitives-level Chain (paritytech#2181) * move Chain::ID from relay-level Chain to primitives-level Chain * removed chain IDs from bp-runtime * add missing file header * Some code grooming (paritytech#2276) * some code grooming: enable warn(missing_docs) for all piblic crates + added missing documentation + removed obsolete clippy/deny workarounds * removed strange allow + added comment related to other allow * removed incorrect_clone_impl_on_copy_type which is unknown to CI clippy
bkontur
pushed a commit
that referenced
this pull request
May 7, 2024
* some code grooming: enable warn(missing_docs) for all piblic crates + added missing documentation + removed obsolete clippy/deny workarounds * removed strange allow + added comment related to other allow * removed incorrect_clone_impl_on_copy_type which is unknown to CI clippy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
most of #2498
I've added:
warn(missing_docs)for all crates that are "exported" to the Cumulus repo;