BUG Series rolling count ignores min periods #31319
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, we stated it as merely optional xref: pandas-dev#30773 pandas-dev#30814
We are not using them for now.
The check doesn't do anything, and we still a raise KeyError anyways
* REGR: Fixed hash_key=None for object values Closes pandas-dev#30887
* Compat for util.testing import Closes pandas-dev#30869
…unt_ignores_min_periods
Updated the behavior of rolling and expanding count so that it becomes consistent with all other rolling and expanding functions. Also updated many test cases to reflect this change of behavior.
* TST: Add more regression tests for fixed issues * Fix lint and platform compat * Using intp * Move interval indexing test to appropriate location
* REG: restore format_type attr
…unt_ignores_min_periods
5 tasks
Contributor
|
you need to clone the 1.0.x branch and cherry-pick this. |
Contributor
Author
|
got it, will close this PR |
Contributor
|
k you could have actually pushed to this branch after you rebased but ok |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
37 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR targets 1.0.x branch and is a manual backport for #30923
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff