CLN: misc cleanups #30877
Merged
CLN: misc cleanups #30877
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WillAyd
requested changes
Jan 10, 2020
pandas/core/arrays/categorical.py
Outdated
| ) | ||
|
|
||
| def equals(self, other): | ||
| def equals(self, other) -> bool: |
Member
There was a problem hiding this comment.
Suggested change
| def equals(self, other) -> bool: | |
| def equals(self, other: Any) -> bool: |
Purely stylistic but we've been typing other as Any elsewhere, so good to do here as well (applicable in a few spots)
Member
Author
There was a problem hiding this comment.
the docstring says other is Categorical; id prefer not to introduce mismatches
Member
Author
|
reverted annotations to push the other parts down the field |
Member
Author
|
@WillAyd gentle ping; reverted the parts that were non-trivial |
WillAyd
approved these changes
Jan 13, 2020
Member
|
Thanks @jbrockmendel |
jreback
reviewed
Jan 14, 2020
| ) | ||
| except (KeyError, TypeError, ValueError): | ||
| return False | ||
| return bool( |
Contributor
There was a problem hiding this comment.
isn't the bool redundant here?
Member
Author
There was a problem hiding this comment.
not according to mypy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Things I find myself doing in multiple branches.