Follow-up: XLSB Support #31215
Merged
Follow-up: XLSB Support #31215
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meeseeksmachine
pushed a commit
to meeseeksmachine/pandas
that referenced
this pull request
Jan 22, 2020
Member
|
@Rik-de-Kort yea your name should auto-generate as a contributor when we release Thanks! |
TomAugspurger
pushed a commit
that referenced
this pull request
Jan 22, 2020
Co-authored-by: Rik-de-Kort <32839123+Rik-de-Kort@users.noreply.github.com>
Contributor
Author
Excellent, and you're welcome. Maybe next patch we go a bit quicker, eh? :P |
Contributor
Author
@WillAyd Happy to see the release is out, with my code :D However, my name does not appear to have been auto-generated in the contributors list. I do have the tag here though. Any ideas? |
Member
|
Hmm @TomAugspurger any ideas on the contributor piece? Original PR of #29836 was part of 1.0 |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated min version for
pyxlsbto 1.0.6 and removed the now unnecessary xfail for read from url. Turns out the other xfail is actually unnecessary so I've removed it.Question: is my name supposed to show up in the contributors list?
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff