Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tslibs resolution #18034

Merged
merged 24 commits into from
Nov 13, 2017
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
c8cb176
implement tslibs.resolution
jbrockmendel Oct 26, 2017
757321d
flake cleanup
jbrockmendel Oct 26, 2017
98e612f
Merge branch 'master' of https://github.com/pandas-dev/pandas into ts…
jbrockmendel Oct 29, 2017
4b6080d
Merge branch 'master' of https://github.com/pandas-dev/pandas into ts…
jbrockmendel Oct 30, 2017
58ced56
Merge branch 'master' of https://github.com/pandas-dev/pandas into ts…
jbrockmendel Oct 31, 2017
1ae12c6
update imports
jbrockmendel Nov 1, 2017
1507a7f
Merge branch 'master' of https://github.com/pandas-dev/pandas into ts…
jbrockmendel Nov 1, 2017
7404b13
dummy commit to force CI re-run
jbrockmendel Nov 1, 2017
9b8c61c
edits per reviewer suggestions
jbrockmendel Nov 1, 2017
c9bf005
remove unused; update imports; add whatsnew note
jbrockmendel Nov 2, 2017
4817941
name fixup
jbrockmendel Nov 2, 2017
25ef9b2
Merge branch 'master' of https://github.com/pandas-dev/pandas into ts…
jbrockmendel Nov 3, 2017
9c17366
Merge branch 'master' of https://github.com/pandas-dev/pandas into ts…
jbrockmendel Nov 5, 2017
cd34cdc
whitespace cleanup
jbrockmendel Nov 5, 2017
1868634
Merge branch 'master' of https://github.com/pandas-dev/pandas into ts…
jbrockmendel Nov 7, 2017
c3c4cae
Merge branch 'master' of https://github.com/pandas-dev/pandas into ts…
jbrockmendel Nov 7, 2017
d939e5c
Merge branch 'master' of https://github.com/pandas-dev/pandas into ts…
jbrockmendel Nov 8, 2017
096a5af
Edits per reviewer requests
jbrockmendel Nov 8, 2017
5701c5e
Merge branch 'master' of https://github.com/pandas-dev/pandas into ts…
jbrockmendel Nov 8, 2017
46d6551
Merge branch 'master' of https://github.com/pandas-dev/pandas into ts…
jbrockmendel Nov 9, 2017
b8b0124
edits per reviewer comments
jbrockmendel Nov 9, 2017
219884e
Merge branch 'master' of https://github.com/pandas-dev/pandas into ts…
jbrockmendel Nov 12, 2017
0ab2b08
whatsnew edit per request
jbrockmendel Nov 12, 2017
7b374d3
Merge branch 'master' of https://github.com/pandas-dev/pandas into ts…
jbrockmendel Nov 13, 2017
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
edits per reviewer comments
  • Loading branch information
jbrockmendel committed Nov 9, 2017
commit b8b012490b42c61976174b00a9fb4de114ae2bd1
2 changes: 1 addition & 1 deletion doc/source/whatsnew/v0.22.0.txt
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ Other API Changes
- :class:`Timestamp` will no longer silently ignore unused or invalid `tz` or `tzinfo` keyword arguments (:issue:`17690`)
- :class:`Timestamp` will no longer silently ignore invalid `freq` arguments (:issue:`5168`)
- :class:`CacheableOffset` and :class:`WeekDay` are no longer available in the `tseries.offsets` module (:issue:`17830`)
- :function:`tseries.frequencies.get_freq_group` and :list:`tseries.frequencies.DAYS` can now be accessed in `_libs.tslibs.resolution` (:issue:`18034`)
- :function:`tseries.frequencies.get_freq_group` and :list:`tseries.frequencies.DAYS` are removed from the private API (:issue:`18034`)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

private -> public

.. _whatsnew_0220.deprecations:

Deprecations
Expand Down
3 changes: 1 addition & 2 deletions pandas/tests/scalar/test_period.py
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,7 @@
from pandas._libs import tslib, period as libperiod
from pandas._libs.tslibs.parsing import DateParseError
from pandas import Period, Timestamp, offsets
from pandas._libs.tslibs.resolution import DAYS
from pandas.tseries.frequencies import MONTHS
from pandas._libs.tslibs.resolution import DAYS, _MONTHS as MONTHS


class TestPeriodProperties(object):
Expand Down