Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tslibs resolution #18034

Merged
merged 24 commits into from
Nov 13, 2017
Merged
Changes from 1 commit
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
c8cb176
implement tslibs.resolution
jbrockmendel Oct 26, 2017
757321d
flake cleanup
jbrockmendel Oct 26, 2017
98e612f
Merge branch 'master' of https://github.com/pandas-dev/pandas into ts…
jbrockmendel Oct 29, 2017
4b6080d
Merge branch 'master' of https://github.com/pandas-dev/pandas into ts…
jbrockmendel Oct 30, 2017
58ced56
Merge branch 'master' of https://github.com/pandas-dev/pandas into ts…
jbrockmendel Oct 31, 2017
1ae12c6
update imports
jbrockmendel Nov 1, 2017
1507a7f
Merge branch 'master' of https://github.com/pandas-dev/pandas into ts…
jbrockmendel Nov 1, 2017
7404b13
dummy commit to force CI re-run
jbrockmendel Nov 1, 2017
9b8c61c
edits per reviewer suggestions
jbrockmendel Nov 1, 2017
c9bf005
remove unused; update imports; add whatsnew note
jbrockmendel Nov 2, 2017
4817941
name fixup
jbrockmendel Nov 2, 2017
25ef9b2
Merge branch 'master' of https://github.com/pandas-dev/pandas into ts…
jbrockmendel Nov 3, 2017
9c17366
Merge branch 'master' of https://github.com/pandas-dev/pandas into ts…
jbrockmendel Nov 5, 2017
cd34cdc
whitespace cleanup
jbrockmendel Nov 5, 2017
1868634
Merge branch 'master' of https://github.com/pandas-dev/pandas into ts…
jbrockmendel Nov 7, 2017
c3c4cae
Merge branch 'master' of https://github.com/pandas-dev/pandas into ts…
jbrockmendel Nov 7, 2017
d939e5c
Merge branch 'master' of https://github.com/pandas-dev/pandas into ts…
jbrockmendel Nov 8, 2017
096a5af
Edits per reviewer requests
jbrockmendel Nov 8, 2017
5701c5e
Merge branch 'master' of https://github.com/pandas-dev/pandas into ts…
jbrockmendel Nov 8, 2017
46d6551
Merge branch 'master' of https://github.com/pandas-dev/pandas into ts…
jbrockmendel Nov 9, 2017
b8b0124
edits per reviewer comments
jbrockmendel Nov 9, 2017
219884e
Merge branch 'master' of https://github.com/pandas-dev/pandas into ts…
jbrockmendel Nov 12, 2017
0ab2b08
whatsnew edit per request
jbrockmendel Nov 12, 2017
7b374d3
Merge branch 'master' of https://github.com/pandas-dev/pandas into ts…
jbrockmendel Nov 13, 2017
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Merge branch 'master' of https://github.com/pandas-dev/pandas into ts…
…libs-resolution
  • Loading branch information
jbrockmendel committed Nov 1, 2017
commit 1507a7fe5da7e95dfba4730c1e6eee1ba8ace18d
8 changes: 5 additions & 3 deletions pandas/_libs/period.pyx
Original file line number Diff line number Diff line change
Expand Up @@ -27,14 +27,16 @@ from util cimport is_period_object, is_string_object, INT32_MIN

from lib cimport is_null_datetimelike
from pandas._libs import tslib
from pandas._libs.tslib import Timestamp, iNaT, NaT
from pandas._libs.tslib import Timestamp, iNaT
from tslibs.timezones cimport (
is_utc, is_tzlocal, get_utcoffset, get_dst_info, maybe_get_tz)

from tslibs.parsing import (parse_time_string, NAT_SENTINEL,
_get_rule_month, _MONTH_NUMBERS, _nat_strings)
_get_rule_month, _MONTH_NUMBERS)
from tslibs.frequencies cimport get_freq_code
from tslibs.resolution import resolution, Resolution
from tslibs.nattype import nat_strings, NaT
from tslibs.nattype cimport _nat_scalar_rules

from pandas.tseries import offsets
from pandas.tseries import frequencies
Expand Down Expand Up @@ -1080,7 +1082,7 @@ class Period(_Period):
converted = other.asfreq(freq)
ordinal = converted.ordinal

elif is_null_datetimelike(value) or value in _nat_strings:
elif is_null_datetimelike(value) or value in nat_strings:
ordinal = iNaT

elif is_string_object(value) or util.is_integer_object(value):
Expand Down
You are viewing a condensed version of this merge commit. You can view the full changes here.