Skip to content

Tslibs resolution #18034

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 24 commits into from
Nov 13, 2017
Merged

Tslibs resolution #18034

Changes from 1 commit
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
c8cb176
implement tslibs.resolution
jbrockmendel Oct 26, 2017
757321d
flake cleanup
jbrockmendel Oct 26, 2017
98e612f
Merge branch 'master' of https://github.com/pandas-dev/pandas into ts…
jbrockmendel Oct 29, 2017
4b6080d
Merge branch 'master' of https://github.com/pandas-dev/pandas into ts…
jbrockmendel Oct 30, 2017
58ced56
Merge branch 'master' of https://github.com/pandas-dev/pandas into ts…
jbrockmendel Oct 31, 2017
1ae12c6
update imports
jbrockmendel Nov 1, 2017
1507a7f
Merge branch 'master' of https://github.com/pandas-dev/pandas into ts…
jbrockmendel Nov 1, 2017
7404b13
dummy commit to force CI re-run
jbrockmendel Nov 1, 2017
9b8c61c
edits per reviewer suggestions
jbrockmendel Nov 1, 2017
c9bf005
remove unused; update imports; add whatsnew note
jbrockmendel Nov 2, 2017
4817941
name fixup
jbrockmendel Nov 2, 2017
25ef9b2
Merge branch 'master' of https://github.com/pandas-dev/pandas into ts…
jbrockmendel Nov 3, 2017
9c17366
Merge branch 'master' of https://github.com/pandas-dev/pandas into ts…
jbrockmendel Nov 5, 2017
cd34cdc
whitespace cleanup
jbrockmendel Nov 5, 2017
1868634
Merge branch 'master' of https://github.com/pandas-dev/pandas into ts…
jbrockmendel Nov 7, 2017
c3c4cae
Merge branch 'master' of https://github.com/pandas-dev/pandas into ts…
jbrockmendel Nov 7, 2017
d939e5c
Merge branch 'master' of https://github.com/pandas-dev/pandas into ts…
jbrockmendel Nov 8, 2017
096a5af
Edits per reviewer requests
jbrockmendel Nov 8, 2017
5701c5e
Merge branch 'master' of https://github.com/pandas-dev/pandas into ts…
jbrockmendel Nov 8, 2017
46d6551
Merge branch 'master' of https://github.com/pandas-dev/pandas into ts…
jbrockmendel Nov 9, 2017
b8b0124
edits per reviewer comments
jbrockmendel Nov 9, 2017
219884e
Merge branch 'master' of https://github.com/pandas-dev/pandas into ts…
jbrockmendel Nov 12, 2017
0ab2b08
whatsnew edit per request
jbrockmendel Nov 12, 2017
7b374d3
Merge branch 'master' of https://github.com/pandas-dev/pandas into ts…
jbrockmendel Nov 13, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
flake cleanup
  • Loading branch information
@jbrockmendel
jbrockmendel committed Oct 26, 2017
commit 757321dc9bfad4f5126d4d20ca727d725daed393
10 changes: 4 additions & 6 deletions pandas/tseries/frequencies.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# -*- coding: utf-8 -*-
from datetime import timedelta
from pandas.compat import long, zip
from pandas.compat import zip
from pandas import compat
import re
import warnings
Expand All @@ -13,19 +13,17 @@
is_timedelta64_dtype,
is_datetime64_dtype)

import pandas.core.algorithms as algos
from pandas.core.algorithms import unique
from pandas.tseries.offsets import DateOffset
from pandas.util._decorators import cache_readonly, deprecate_kwarg
from pandas.util._decorators import deprecate_kwarg
import pandas.tseries.offsets as offsets

from pandas._libs import lib, tslib
from pandas._libs import tslib
from pandas._libs.tslib import Timedelta
from pandas._libs.tslibs.frequencies import ( # noqa
get_freq_code, _base_and_stride, _period_str_to_code,
_INVALID_FREQ_ERROR, opattern, _lite_rule_alias, _dont_uppercase,
_period_code_map, _reverse_period_code_map)
from pandas._libs.tslibs.resolution import (
from pandas._libs.tslibs.resolution import ( # noqa
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why the noqa?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's public-facing so I didn't want to break anything downstream. Remove unused imports?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm, what exactly is public facing of these? I am ok with simply removing anything _leading, what is not here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the noqa is for DAYS, _maybe_add_count, _weekday_rule_aliases, get_freq_group. I think the private ones here can be removed without breaking anything. DAYS and get_freq_group are imported by and a couple other places.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok let's remove any non-used, you can put the non-private ones in a whatsnew note

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just pushed. Wasn't sure about wording in whatsnew note for the list DAYS.

DAYS,
Resolution,
_FrequencyInferer, _TimedeltaFrequencyInferer,
Expand Down