Debounce startTime and endTime in date range picker
#2801
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
benjaminleonard
approved these changes
Apr 10, 2025
Contributor
benjaminleonard
left a comment
benjaminleonard
left a comment
There was a problem hiding this comment.
Feels like a nice balance, nice.
david-crespo
added a commit
to oxidecomputer/omicron
that referenced
this pull request
Apr 10, 2025
oxidecomputer/console@3db0150...99a1f00 * [99a1f008](oxidecomputer/console@99a1f008) oxidecomputer/console#2801 * [1d37fcc7](oxidecomputer/console@1d37fcc7) oxidecomputer/console#2799 * [1d5f223f](oxidecomputer/console@1d5f223f) oxidecomputer/console#2798 * [73e36cb6](oxidecomputer/console@73e36cb6) oxidecomputer/console#2797
david-crespo
added a commit
to oxidecomputer/omicron
that referenced
this pull request
Apr 10, 2025
oxidecomputer/console@3db0150...99a1f00 * [99a1f008](oxidecomputer/console@99a1f008) oxidecomputer/console#2801 * [1d37fcc7](oxidecomputer/console@1d37fcc7) oxidecomputer/console#2799 * [1d5f223f](oxidecomputer/console@1d5f223f) oxidecomputer/console#2798 * [73e36cb6](oxidecomputer/console@73e36cb6) oxidecomputer/console#2797
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed on dogfood it's too easy to overload OxQL by holding the up arrow in the time picker. Input wasn't debounced, so we were firing a request for every value of the input. I couldn't believe how easy this was to do. 400ms seems quite responsive while fully solving the problem.
Before
2025-04-10-debounce-metrics-before.mp4
After
2025-04-10-debounce-metrics-after.mp4