-
Notifications
You must be signed in to change notification settings - Fork 18
Closed
Milestone
Description
We update the time immediately on keydown in the input, which means if you're changing the minutes you are firing off a ton of queries. Maybe this wouldn't matter if the queries were faster, but it is not great while they're slow. It's also kinda weird for the graph to churn so fast if they're fast.
console/app/ui/lib/DateRangePicker.tsx
Lines 95 to 109 in 1fe4a7e
| <TimeField | |
| label="Start time" | |
| value={state.timeRange?.start || null} | |
| onChange={(v) => state.setTime('start', v)} | |
| hourCycle={24} | |
| className="shrink-0 grow basis-0" | |
| /> | |
| <div className="text-quaternary">–</div> | |
| <TimeField | |
| label="End time" | |
| value={state.timeRange?.end || null} | |
| onChange={(v) => state.setTime('end', v)} | |
| hourCycle={24} | |
| className="shrink-0 grow basis-0" | |
| /> |
2025-03-03-time-range-change.mp4
Metadata
Metadata
Assignees
Labels
No labels