Increase list page size to 50 #2798
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
david-crespo
changed the title
charliepark
reviewed
Apr 9, 2025
| const row = page.getByRole('row', { name: 'snapshot-4' }) | ||
| await row.getByRole('button', { name: 'Row actions' }).click() | ||
| await page.getByRole('menuitem', { name: 'Create image' }).click() | ||
| await clickRowAction(page, 'disk-1-snapshot-8', 'Create image') |
Collaborator
Author
There was a problem hiding this comment.
I had to change from snapshot-4 because it doesn’t do an exact match and it was picking snapshot-40 etc
charliepark
approved these changes
Apr 9, 2025
Contributor
charliepark
left a comment
charliepark
left a comment
There was a problem hiding this comment.
A great improvement until we can add better pagination (and even then, 50 is great)
david-crespo
added a commit
to oxidecomputer/omicron
that referenced
this pull request
Apr 10, 2025
oxidecomputer/console@3db0150...99a1f00 * [99a1f008](oxidecomputer/console@99a1f008) oxidecomputer/console#2801 * [1d37fcc7](oxidecomputer/console@1d37fcc7) oxidecomputer/console#2799 * [1d5f223f](oxidecomputer/console@1d5f223f) oxidecomputer/console#2798 * [73e36cb6](oxidecomputer/console@73e36cb6) oxidecomputer/console#2797
david-crespo
added a commit
to oxidecomputer/omicron
that referenced
this pull request
Apr 10, 2025
oxidecomputer/console@3db0150...99a1f00 * [99a1f008](oxidecomputer/console@99a1f008) oxidecomputer/console#2801 * [1d37fcc7](oxidecomputer/console@1d37fcc7) oxidecomputer/console#2799 * [1d5f223f](oxidecomputer/console@1d5f223f) oxidecomputer/console#2798 * [73e36cb6](oxidecomputer/console@73e36cb6) oxidecomputer/console#2797
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should substantially reduce the proportion of the time that going past the first page is required. None of our JSON responses are that big, the API is fast, and it's probably rare for people to have that many of most resources. If everything is on one page, then ctrl-f works for find and it's less of a problem that we don't have filtering yet.
I'd also like to make the tables more dense by reducing vertical space, but this doesn't require that at all.