feat(linter): eslint-plugin-vitest/no-import-node-test

[eryue0220]

support eslint-plugin-vitest/no-import-node-test

[graphite-app]

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

[codspeed-hq]

CodSpeed Performance Report

Merging #4440 will not alter performance

_{Comparing eryue0220:feat/vitest-no-import-node-test (7cde289) with main (6f42c55)}

Summary

✅ 32 untouched benchmarks

[mysteryven]

Let's try module record to see if it can improve our performance👀

To run benchmark for vitest rule, we also need to modify:

oxc/tasks/benchmark/benches/linter.rs

Lines 44 to 51 in 7a75e0f

	let lint_options = LintOptions::default()
	.with_filter(filter)
	.with_import_plugin(true)
	.with_jsdoc_plugin(true)
	.with_jest_plugin(true)
	.with_jsx_a11y_plugin(true)
	.with_nextjs_plugin(true)
	.with_react_perf_plugin(true);

[eryue0220]

Let's try module record to see if it can improve our performance👀

To run benchmark for vitest rule, we also need to modify:

oxc/tasks/benchmark/benches/linter.rs

Lines 44 to 51 in 7a75e0f

	let lint_options = LintOptions::default()
	.with_filter(filter)
	.with_import_plugin(true)
	.with_jsdoc_plugin(true)
	.with_jest_plugin(true)
	.with_jsx_a11y_plugin(true)
	.with_nextjs_plugin(true)
	.with_react_perf_plugin(true);

still the same problem. :(

[mysteryven]

still the same problem. :(

We can try to use module record. e.g.

1. oxc/crates/oxc_linter/src/rules/import/no_self_import.rs

   Lines 30 to 46 in 7a75e0f

   	impl Rule for NoSelfImport {
   	fn run_once(&self, ctx: &LintContext<'_>) {
   	let module_record = ctx.module_record();
   	let resolved_absolute_path = &module_record.resolved_absolute_path;
   	for (request, requested_modules) in &module_record.requested_modules {
   	let Some(remote_module_record_ref) = module_record.loaded_modules.get(request) else {
   	continue;
   	};
   	if remote_module_record_ref.value().resolved_absolute_path == *resolved_absolute_path {
   	for requested_module in requested_modules {
   	ctx.diagnostic(no_self_import_diagnostic(requested_module.span()));
   	}
   	}
   	}
   	}
   	}

2. oxc/crates/oxc_linter/src/frameworks.rs

   Lines 83 to 85 in 7a75e0f

   	pub(crate) fn has_vitest_imports(module_record: &ModuleRecord) -> bool {
   	module_record.import_entries.iter().any(|entry| entry.module_request.name() == "vitest")
   	}

[eryue0220]

still the same problem. :(

We can try to use module record. e.g.

1. oxc/crates/oxc_linter/src/rules/import/no_self_import.rs

   Lines 30 to 46 in 7a75e0f

   	impl Rule for NoSelfImport {
   	fn run_once(&self, ctx: &LintContext<'_>) {
   	let module_record = ctx.module_record();
   	let resolved_absolute_path = &module_record.resolved_absolute_path;
   	for (request, requested_modules) in &module_record.requested_modules {
   	let Some(remote_module_record_ref) = module_record.loaded_modules.get(request) else {
   	continue;
   	};
   	if remote_module_record_ref.value().resolved_absolute_path == *resolved_absolute_path {
   	for requested_module in requested_modules {
   	ctx.diagnostic(no_self_import_diagnostic(requested_module.span()));
   	}
   	}
   	}
   	}
   	}

2. oxc/crates/oxc_linter/src/frameworks.rs

   Lines 83 to 85 in 7a75e0f

   	pub(crate) fn has_vitest_imports(module_record: &ModuleRecord) -> bool {
   	module_record.import_entries.iter().any(|entry| entry.module_request.name() == "vitest")
   	}

ooooh, sorry I forgot this.

[eryue0220]

Thanks, it works!!

[mysteryven]

Nice!