feat(linter/eslint): Implement prefer-numeric-literals

[jelly]

Rule Detail:
link

---

This lacks the fix, which I intend to work on as a follow up or if preferred I can leave the PR open an hack on it this week.

One interesting note is that eslint(radix) does not handle:

        "function *f(){ yield(Number).parseInt('11', 2) }", // { "ecmaVersion": 6 },

Maybe it is an idea to introduce a helper is_parseint_stmt which returns the call_expr? As the code is almost identical to the radix rule.

[graphite-app]

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

[jelly]

Just send #4110 for the radix issue.

[codspeed-hq]

CodSpeed Performance Report

Merging #4109 will not alter performance

_{Comparing jelly:eslint/numeric-literals (a627281) with main (bb33bcc)}

Summary

✅ 32 untouched benchmarks

[jelly]

Implemented the fixer, but I need to figure out if there is space on the start of the span and end of the previous span are only one apart and I'm not sure how to do that.

[mysteryven]

Implemented the fixer, but I need to figure out if there is space on the start of the span and end of the previous span are only one apart and I'm not sure how to do that.

Sound difficult for us, do you have any thoughts @DonIsaac

[DonIsaac]

Implemented the fixer, but I need to figure out if there is space on the start of the span and end of the previous span are only one apart and I'm not sure how to do that.

Sound difficult for us, do you have any thoughts @DonIsaac

Just saw this, my bad! I'll review this tomorrow.

[jelly]

Implemented the fixer, but I need to figure out if there is space on the start of the span and end of the previous span are only one apart and I'm not sure how to do that.

Sound difficult for us, do you have any thoughts @DonIsaac

Just saw this, my bad! I'll review this tomorrow.

So I know now that I can look up the parent_node easily in the fixer. But I think the AST does not really record the previous node.

Maybe we only need to check if we are part of a YieldExpression? Turns out this is indeed legal:

[jelle@t14s][~]%cat -p /tmp/foo.js
function *f(){ yield(Number).parseInt('11', 2) }

let x = f();
console.log(x.next());

[jelle@t14s][~]%node /tmp/foo.js
{ value: 3, done: false }

[jelly]

I've pushed work on a fixer to https://github.com/jelly/oxc/tree/eslint/numeric-literals-fixer, the tests pass but the eslint tests aren't great and allow for creation of invalid syntactical code for example:

parseInt('', 16); and parseInt('1234.5', 8) => 0o1234.5. So I'll need to make the fixer conditional, not entirely sure yet how I check fractions.

[mysteryven]

not entirely sure yet how I check fractions.

Looks from_str_radix can solve this: playground.

[jelly]

not entirely sure yet how I check fractions.

Looks from_str_radix can solve this: playground.

Thanks! That would solve everything I needed for the fixer!

[Boshen]

@mysteryven Would you like to help out and land this?

[DonIsaac]

I've pushed work on a fixer to https://github.com/jelly/oxc/tree/eslint/numeric-literals-fixer, the tests pass but the eslint tests aren't great and allow for creation of invalid syntactical code for example:

parseInt('', 16); and parseInt('1234.5', 8) => 0o1234.5. So I'll need to make the fixer conditional, not entirely sure yet how I check fractions.

If you cannot figure out a perfectly safe fix, consider making it dangerous.

oxc/crates/oxc_linter/src/fixer/fix.rs

Line 178 in 732f4e2

pub fn dangerously(mut self) -> Self {

[mysteryven]

Let's merge this, the fixer part will be the next separate PR.