feat(linter/react-perf): handle new objects and arrays in prop assignment patterns

[DonIsaac]

What This PR Does

Massively improves all react-perf rules

• feat: handle new objects/etc assigned to variables

const Foo = () => {
  const x = { foo: 'bar' } // <- now reports this new object
  return <Bar x={x} />
}

• feat: handle new objects/etc in binding patterns

const Foo = ({ x = [] }) => {
  //           ^^^^^^ now reports this new array
  return <Bar x={x} />
}

-feat: nice and descriptive labels for new objects/etc assigned to intermediate variables

  ⚠ eslint-plugin-react-perf(jsx-no-new-object-as-prop): JSX attribute values should not contain objects created in the same scope.
   ╭─[jsx_no_new_object_as_prop.tsx:1:27]
 1 │ const Foo = () => { const x = {}; return <Bar x={x} /> }
   ·                           ┬   ─┬                 ┬
   ·                           │    │                 ╰── And used here
   ·                           │    ╰── And assigned a new value here
   ·                           ╰── The prop was declared here
   ╰────
  help: simplify props or memoize props in the parent component (https://react.dev/reference/react/memo#my-component-rerenders-when-a-prop-is-an-object-or-array).

• feat: consider Object.assign() and Object.create() as a new object
• feat: consider arr.[map, filter, concat] as a new array
• refactor: move shared implementation code to ReactPerfRule in oxc_linter::utils::react_perf

[graphite-app]

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

[DonIsaac]

• feat(linter/react-perf): handle new objects and arrays in prop assignment patterns #4396 👈
• fix(linter/react_perf): allow new objects, array, fns, etc in top scope #4395
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @DonIsaac and the rest of your teammates on Graphite

[codspeed-hq]

CodSpeed Performance Report

Merging #4396 will not alter performance

_{Comparing don/07-21-feat_linter/react-perf_check_for_new_objects_etc_in_variables (68efcd4) with main (ac08de8)}

Summary

✅ 32 untouched benchmarks

[mysteryven]

Always learn new things from your refactor!

[graphite-app]

Merge activity

• Jul 22, 9:52 PM EDT: The merge label 'merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
• Jul 22, 9:52 PM EDT: mysteryven added this pull request to the Graphite merge queue.
• Jul 22, 9:56 PM EDT: mysteryven merged this pull request with the Graphite merge queue.