Skip to content

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Nov 5, 2025

Small perf optimization to raw transfer. Shorten deserializers by not assigning null to fields which were already initialized as null.

Copy link
Member Author

overlookmotel commented Nov 5, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added A-linter Area - Linter A-parser Area - Parser A-cli Area - CLI A-ast-tools Area - AST tools labels Nov 5, 2025
@github-actions github-actions bot added the C-performance Category - Solution not expected to change functional behavior, only performance label Nov 5, 2025
@overlookmotel overlookmotel marked this pull request as ready for review November 5, 2025 10:46
@overlookmotel overlookmotel self-assigned this Nov 5, 2025
@overlookmotel overlookmotel added the 0-merge Merge with Graphite Merge Queue label Nov 5, 2025
Copy link
Member Author

overlookmotel commented Nov 5, 2025

Merge activity

…rializers (#15305)

Small perf optimization to raw transfer. Shorten deserializers by not assigning `null` to fields which were already initialized as `null`.
@graphite-app graphite-app bot force-pushed the 10-22-fix_ast_estree_fix_raw_transfer_deserializer_for_assignmenttargetpropertyidentifier_ branch from 2b1f9b5 to 7f079ab Compare November 5, 2025 11:24
@graphite-app graphite-app bot force-pushed the 10-22-perf_ast_estree_remove_pointless_assignments_from_raw_transfer_deserializers branch from 29909e3 to c82fab0 Compare November 5, 2025 11:24
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Nov 5, 2025
Base automatically changed from 10-22-fix_ast_estree_fix_raw_transfer_deserializer_for_assignmenttargetpropertyidentifier_ to main November 5, 2025 11:30
@graphite-app graphite-app bot merged commit c82fab0 into main Nov 5, 2025
19 checks passed
@graphite-app graphite-app bot deleted the 10-22-perf_ast_estree_remove_pointless_assignments_from_raw_transfer_deserializers branch November 5, 2025 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-ast-tools Area - AST tools A-cli Area - CLI A-linter Area - Linter A-parser Area - Parser C-performance Category - Solution not expected to change functional behavior, only performance

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants