refactor(ast/estree): shorten raw transfer deserializer for AssignmentTargetPropertyIdentifier
#15303
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
github-actions
bot
added
A-linter
github-actions
bot
added
the
C-cleanup
This was referenced Nov 5, 2025
CodSpeed Performance ReportMerging #15303 will not alter performanceComparing Summary
|
Contributor
Merge activity
|
…ntTargetPropertyIdentifier` (#15303) There are no `deserialize` calls while constructing `value` here, so it's pointless to assign to `parent` and then set it back again. Remove this pointless code, and shorten the deserializer a little.
graphite-app
bot
force-pushed
the
10-22-fix_ast_estree_correct_raw_transfer_deserializer_for_formalparameter_
branch
from
080a69a to
d92451e
Compare
graphite-app
bot
force-pushed
the
10-22-refactor_ast_estree_shorten_raw_transfer_deserializer_for_assignmenttargetpropertyidentifier_
branch
from
9a8e54d to
a7cf856
Compare
Base automatically changed from
10-22-fix_ast_estree_correct_raw_transfer_deserializer_for_formalparameter_
to
main
November 5, 2025 11:28
graphite-app
bot
deleted the
10-22-refactor_ast_estree_shorten_raw_transfer_deserializer_for_assignmenttargetpropertyidentifier_
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are no
deserializecalls while constructingvaluehere, so it's pointless to assign toparentand then set it back again. Remove this pointless code, and shorten the deserializer a little.