Skip to content

perf(ast/estree): remove pointless assignments from raw transfer deserializers #15305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 5, 2025
Merged

perf(ast/estree): remove pointless assignments from raw transfer deserializers #15305

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 0 additions & 20 deletions apps/oxlint/src-js/generated/deserialize.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,7 +200,6 @@ function deserializeIdentifierName(pos) {
});
node.decorators = [];
node.optional = false;
node.typeAnnotation = null;
parent = previousParent;
return node;
}
Expand All @@ -223,7 +222,6 @@ function deserializeIdentifierReference(pos) {
});
node.decorators = [];
node.optional = false;
node.typeAnnotation = null;
parent = previousParent;
return node;
}
Expand All @@ -246,7 +244,6 @@ function deserializeBindingIdentifier(pos) {
});
node.decorators = [];
node.optional = false;
node.typeAnnotation = null;
parent = previousParent;
return node;
}
Expand All @@ -269,7 +266,6 @@ function deserializeLabelIdentifier(pos) {
});
node.decorators = [];
node.optional = false;
node.typeAnnotation = null;
parent = previousParent;
return node;
}
Expand Down Expand Up @@ -1107,7 +1103,6 @@ function deserializeArrayAssignmentTarget(pos) {
node.decorators = [];
node.elements = elements;
node.optional = false;
node.typeAnnotation = null;
parent = previousParent;
return node;
}
Expand All @@ -1134,7 +1129,6 @@ function deserializeObjectAssignmentTarget(pos) {
node.decorators = [];
node.properties = properties;
node.optional = false;
node.typeAnnotation = null;
parent = previousParent;
return node;
}
Expand All @@ -1159,8 +1153,6 @@ function deserializeAssignmentTargetRest(pos) {
node.decorators = [];
node.argument = deserializeAssignmentTarget(pos + 8);
node.optional = false;
node.typeAnnotation = null;
node.value = null;
parent = previousParent;
return node;
}
Expand Down Expand Up @@ -1215,7 +1207,6 @@ function deserializeAssignmentTargetWithDefault(pos) {
node.left = deserializeAssignmentTarget(pos + 8);
node.right = deserializeExpression(pos + 24);
node.optional = false;
node.typeAnnotation = null;
parent = previousParent;
return node;
}
Expand Down Expand Up @@ -1645,7 +1636,6 @@ function deserializeExpressionStatement(pos) {
parent,
});
node.expression = deserializeExpression(pos + 8);
node.directive = null;
parent = previousParent;
return node;
}
Expand Down Expand Up @@ -2164,7 +2154,6 @@ function deserializeAssignmentPattern(pos) {
node.left = deserializeBindingPattern(pos + 8);
node.right = deserializeExpression(pos + 40);
node.optional = false;
node.typeAnnotation = null;
parent = previousParent;
return node;
}
Expand All @@ -2191,7 +2180,6 @@ function deserializeObjectPattern(pos) {
node.decorators = [];
node.properties = properties;
node.optional = false;
node.typeAnnotation = null;
parent = previousParent;
return node;
}
Expand Down Expand Up @@ -2246,7 +2234,6 @@ function deserializeArrayPattern(pos) {
node.decorators = [];
node.elements = elements;
node.optional = false;
node.typeAnnotation = null;
parent = previousParent;
return node;
}
Expand All @@ -2271,8 +2258,6 @@ function deserializeBindingRestElement(pos) {
node.decorators = [];
node.argument = deserializeBindingPattern(pos + 8);
node.optional = false;
node.typeAnnotation = null;
node.value = null;
parent = previousParent;
return node;
}
Expand Down Expand Up @@ -2442,7 +2427,6 @@ function deserializeArrowFunctionExpression(pos) {
node.params = deserializeBoxFormalParameters(pos + 16);
node.returnType = deserializeOptionBoxTSTypeAnnotation(pos + 24);
node.body = body;
node.id = null;
node.generator = false;
parent = previousParent;
return node;
Expand Down Expand Up @@ -3141,7 +3125,6 @@ function deserializeNullLiteral(pos) {
range: [start, end],
parent,
});
node.value = null;
node.raw = start === 0 && end === 0 ? null : 'null';
parent = previousParent;
return node;
Expand Down Expand Up @@ -4733,7 +4716,6 @@ function deserializeTSPropertySignature(pos) {
});
node.key = deserializePropertyKey(pos + 8);
node.typeAnnotation = deserializeOptionBoxTSTypeAnnotation(pos + 24);
node.accessibility = null;
node.static = false;
parent = previousParent;
return node;
Expand Down Expand Up @@ -4775,7 +4757,6 @@ function deserializeTSIndexSignature(pos) {
});
node.parameters = deserializeVecTSIndexSignatureName(pos + 8);
node.typeAnnotation = deserializeBoxTSTypeAnnotation(pos + 32);
node.accessibility = null;
parent = previousParent;
return node;
}
Expand Down Expand Up @@ -4847,7 +4828,6 @@ function deserializeTSMethodSignature(pos) {
node.typeParameters = deserializeOptionBoxTSTypeParameterDeclaration(pos + 24);
node.params = params;
node.returnType = deserializeOptionBoxTSTypeAnnotation(pos + 48);
node.accessibility = null;
node.readonly = false;
node.static = false;
parent = previousParent;
Expand Down
5 changes: 0 additions & 5 deletions napi/parser/generated/deserialize/js.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1813,7 +1813,6 @@ function deserializeArrowFunctionExpression(pos) {
expression === true && (body = body.body[0].expression);
node.params = deserializeBoxFormalParameters(pos + 16);
node.body = body;
node.id = null;
node.generator = false;
return node;
}
Expand Down Expand Up @@ -2350,7 +2349,6 @@ function deserializeNullLiteral(pos) {
start,
end,
};
node.value = null;
node.raw = start === 0 && end === 0 ? null : 'null';
return node;
}
Expand Down Expand Up @@ -3522,7 +3520,6 @@ function deserializeTSPropertySignature(pos) {
};
node.key = deserializePropertyKey(pos + 8);
node.typeAnnotation = deserializeOptionBoxTSTypeAnnotation(pos + 24);
node.accessibility = null;
node.static = false;
return node;
}
Expand Down Expand Up @@ -3559,7 +3556,6 @@ function deserializeTSIndexSignature(pos) {
};
node.parameters = deserializeVecTSIndexSignatureName(pos + 8);
node.typeAnnotation = deserializeBoxTSTypeAnnotation(pos + 32);
node.accessibility = null;
return node;
}

Expand Down Expand Up @@ -3619,7 +3615,6 @@ function deserializeTSMethodSignature(pos) {
node.typeParameters = deserializeOptionBoxTSTypeParameterDeclaration(pos + 24);
node.params = params;
node.returnType = deserializeOptionBoxTSTypeAnnotation(pos + 48);
node.accessibility = null;
node.readonly = false;
node.static = false;
return node;
Expand Down
5 changes: 0 additions & 5 deletions napi/parser/generated/deserialize/js_parent.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2108,7 +2108,6 @@ function deserializeArrowFunctionExpression(pos) {
}
node.params = deserializeBoxFormalParameters(pos + 16);
node.body = body;
node.id = null;
node.generator = false;
parent = previousParent;
return node;
Expand Down Expand Up @@ -2728,7 +2727,6 @@ function deserializeNullLiteral(pos) {
end,
parent,
});
node.value = null;
node.raw = start === 0 && end === 0 ? null : 'null';
parent = previousParent;
return node;
Expand Down Expand Up @@ -4103,7 +4101,6 @@ function deserializeTSPropertySignature(pos) {
});
node.key = deserializePropertyKey(pos + 8);
node.typeAnnotation = deserializeOptionBoxTSTypeAnnotation(pos + 24);
node.accessibility = null;
node.static = false;
parent = previousParent;
return node;
Expand Down Expand Up @@ -4143,7 +4140,6 @@ function deserializeTSIndexSignature(pos) {
});
node.parameters = deserializeVecTSIndexSignatureName(pos + 8);
node.typeAnnotation = deserializeBoxTSTypeAnnotation(pos + 32);
node.accessibility = null;
parent = previousParent;
return node;
}
Expand Down Expand Up @@ -4211,7 +4207,6 @@ function deserializeTSMethodSignature(pos) {
node.typeParameters = deserializeOptionBoxTSTypeParameterDeclaration(pos + 24);
node.params = params;
node.returnType = deserializeOptionBoxTSTypeAnnotation(pos + 48);
node.accessibility = null;
node.readonly = false;
node.static = false;
parent = previousParent;
Expand Down
5 changes: 0 additions & 5 deletions napi/parser/generated/deserialize/js_range.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1978,7 +1978,6 @@ function deserializeArrowFunctionExpression(pos) {
expression === true && (body = body.body[0].expression);
node.params = deserializeBoxFormalParameters(pos + 16);
node.body = body;
node.id = null;
node.generator = false;
return node;
}
Expand Down Expand Up @@ -2558,7 +2557,6 @@ function deserializeNullLiteral(pos) {
end,
range: [start, end],
};
node.value = null;
node.raw = start === 0 && end === 0 ? null : 'null';
return node;
}
Expand Down Expand Up @@ -3886,7 +3884,6 @@ function deserializeTSPropertySignature(pos) {
};
node.key = deserializePropertyKey(pos + 8);
node.typeAnnotation = deserializeOptionBoxTSTypeAnnotation(pos + 24);
node.accessibility = null;
node.static = false;
return node;
}
Expand Down Expand Up @@ -3924,7 +3921,6 @@ function deserializeTSIndexSignature(pos) {
};
node.parameters = deserializeVecTSIndexSignatureName(pos + 8);
node.typeAnnotation = deserializeBoxTSTypeAnnotation(pos + 32);
node.accessibility = null;
return node;
}

Expand Down Expand Up @@ -3988,7 +3984,6 @@ function deserializeTSMethodSignature(pos) {
node.typeParameters = deserializeOptionBoxTSTypeParameterDeclaration(pos + 24);
node.params = params;
node.returnType = deserializeOptionBoxTSTypeAnnotation(pos + 48);
node.accessibility = null;
node.readonly = false;
node.static = false;
return node;
Expand Down
5 changes: 0 additions & 5 deletions napi/parser/generated/deserialize/js_range_parent.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2194,7 +2194,6 @@ function deserializeArrowFunctionExpression(pos) {
}
node.params = deserializeBoxFormalParameters(pos + 16);
node.body = body;
node.id = null;
node.generator = false;
parent = previousParent;
return node;
Expand Down Expand Up @@ -2835,7 +2834,6 @@ function deserializeNullLiteral(pos) {
range: [start, end],
parent,
});
node.value = null;
node.raw = start === 0 && end === 0 ? null : 'null';
parent = previousParent;
return node;
Expand Down Expand Up @@ -4307,7 +4305,6 @@ function deserializeTSPropertySignature(pos) {
});
node.key = deserializePropertyKey(pos + 8);
node.typeAnnotation = deserializeOptionBoxTSTypeAnnotation(pos + 24);
node.accessibility = null;
node.static = false;
parent = previousParent;
return node;
Expand Down Expand Up @@ -4348,7 +4345,6 @@ function deserializeTSIndexSignature(pos) {
});
node.parameters = deserializeVecTSIndexSignatureName(pos + 8);
node.typeAnnotation = deserializeBoxTSTypeAnnotation(pos + 32);
node.accessibility = null;
parent = previousParent;
return node;
}
Expand Down Expand Up @@ -4418,7 +4414,6 @@ function deserializeTSMethodSignature(pos) {
node.typeParameters = deserializeOptionBoxTSTypeParameterDeclaration(pos + 24);
node.params = params;
node.returnType = deserializeOptionBoxTSTypeAnnotation(pos + 48);
node.accessibility = null;
node.readonly = false;
node.static = false;
parent = previousParent;
Expand Down
Loading
Loading