Skip to content

Conversation

@sapphi-red
Copy link
Member

@sapphi-red sapphi-red commented Nov 2, 2025

Allow codes like function foo() { class Bar { [arguments]: 1 } }.

Copy link
Member Author

sapphi-red commented Nov 2, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@sapphi-red sapphi-red requested review from Boshen and camc314 and removed request for camc314 November 2, 2025 12:51
@sapphi-red sapphi-red changed the title fix(parser): allow arguments in the class field keys fix(semantic): allow arguments in the class field keys Nov 2, 2025
@codspeed-hq
Copy link

codspeed-hq bot commented Nov 2, 2025

CodSpeed Performance Report

Merging #15227 will not alter performance

Comparing 11-02-fix_parser_allow_arguments_in_the_class_field_keys (d085a40) with 11-02-fix_parser_reject_using___await_using_in_a_switch_case___default_clause (693d569)

Summary

✅ 37 untouched

@sapphi-red sapphi-red force-pushed the 11-02-fix_parser_allow_arguments_in_the_class_field_keys branch from 0892c0d to d085a40 Compare November 2, 2025 13:00
@sapphi-red sapphi-red marked this pull request as ready for review November 2, 2025 13:17
@sapphi-red sapphi-red requested a review from Dunqing as a code owner November 2, 2025 13:17
@Boshen Boshen assigned Dunqing and unassigned Boshen Nov 2, 2025
@Boshen
Copy link
Member

Boshen commented Nov 2, 2025

I don't understand the code when .address() is used, so handing over to @Dunqing

@Dunqing Dunqing added the 0-merge Merge with Graphite Merge Queue label Nov 3, 2025
Copy link
Member

Dunqing commented Nov 3, 2025

Merge activity

@sapphi-red sapphi-red changed the base branch from 11-02-fix_parser_reject_using___await_using_in_a_switch_case___default_clause to graphite-base/15227 November 3, 2025 06:32
@sapphi-red sapphi-red force-pushed the 11-02-fix_parser_allow_arguments_in_the_class_field_keys branch from d085a40 to f09c1db Compare November 3, 2025 06:32
@sapphi-red sapphi-red changed the base branch from graphite-base/15227 to main November 3, 2025 06:32
Allow codes like `function foo() { class Bar { [arguments]: 1 } }`.
@graphite-app graphite-app bot force-pushed the 11-02-fix_parser_allow_arguments_in_the_class_field_keys branch from f09c1db to 4a54107 Compare November 3, 2025 06:38
@graphite-app graphite-app bot merged commit 4a54107 into main Nov 3, 2025
20 checks passed
@graphite-app graphite-app bot deleted the 11-02-fix_parser_allow_arguments_in_the_class_field_keys branch November 3, 2025 06:44
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Nov 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-semantic Area - Semantic C-bug Category - Bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants