Skip to content

Conversation

@sapphi-red
Copy link
Member

@sapphi-red sapphi-red commented Nov 2, 2025

Reject codes like while (1) using foo = {} similar to while (1) let foo = {}.

Copy link
Member Author

sapphi-red commented Nov 2, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@sapphi-red sapphi-red force-pushed the 11-02-fix_parser_reject_using___await_using_in_single_statement_contexts branch from b1a60ed to abfe820 Compare November 2, 2025 11:42
@sapphi-red sapphi-red force-pushed the 11-02-fix_parser_reject_trailing_commas_after_rest_elements_in_object_patterns branch from 71d9da7 to 5db1b70 Compare November 2, 2025 11:42
@sapphi-red sapphi-red requested a review from Boshen November 2, 2025 11:43
@sapphi-red sapphi-red marked this pull request as ready for review November 2, 2025 11:51
@codspeed-hq
Copy link

codspeed-hq bot commented Nov 2, 2025

CodSpeed Performance Report

Merging #15224 will not alter performance

Comparing 11-02-fix_parser_reject_using___await_using_in_single_statement_contexts (abfe820) with 11-02-fix_parser_reject_trailing_commas_after_rest_elements_in_object_patterns (5db1b70)

Summary

✅ 37 untouched

@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Nov 2, 2025
Copy link
Member

Boshen commented Nov 2, 2025

Merge activity

…xts (#15224)

Reject codes like `while (1) using foo = {}` similar to `while (1) let foo = {}`.
@sapphi-red sapphi-red force-pushed the 11-02-fix_parser_reject_using___await_using_in_single_statement_contexts branch from abfe820 to 25d0dfe Compare November 2, 2025 12:11
@sapphi-red sapphi-red force-pushed the 11-02-fix_parser_reject_trailing_commas_after_rest_elements_in_object_patterns branch from 5db1b70 to ad9147e Compare November 2, 2025 12:11
@graphite-app graphite-app bot force-pushed the 11-02-fix_parser_reject_trailing_commas_after_rest_elements_in_object_patterns branch from ad9147e to 0398d40 Compare November 2, 2025 12:11
@graphite-app graphite-app bot force-pushed the 11-02-fix_parser_reject_using___await_using_in_single_statement_contexts branch from 25d0dfe to 4668004 Compare November 2, 2025 12:12
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Nov 2, 2025
Base automatically changed from 11-02-fix_parser_reject_trailing_commas_after_rest_elements_in_object_patterns to main November 2, 2025 12:19
@graphite-app graphite-app bot merged commit 4668004 into main Nov 2, 2025
22 checks passed
@graphite-app graphite-app bot deleted the 11-02-fix_parser_reject_using___await_using_in_single_statement_contexts branch November 2, 2025 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-parser Area - Parser C-bug Category - Bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants