-
-
Notifications
You must be signed in to change notification settings - Fork 722
fix(parser): reject trailing commas after rest elements in object patterns #15223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
graphite-app
merged 1 commit into
main
from
11-02-fix_parser_reject_trailing_commas_after_rest_elements_in_object_patterns
Nov 2, 2025
Merged
fix(parser): reject trailing commas after rest elements in object patterns #15223
graphite-app
merged 1 commit into
main
from
11-02-fix_parser_reject_trailing_commas_after_rest_elements_in_object_patterns
Nov 2, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 2, 2025
Member
Author
This was referenced Nov 2, 2025
71d9da7 to
5db1b70
Compare
CodSpeed Performance ReportMerging #15223 will not alter performanceComparing Summary
|
Contributor
Merge activity
|
…terns (#15223) Reject codes like `({...a,} = {});` like we reject `([...a,] = []);`.
280f488 to
0997ef9
Compare
5db1b70 to
ad9147e
Compare
0997ef9 to
c28807b
Compare
ad9147e to
0398d40
Compare
Base automatically changed from
11-02-fix_parser_reject_async_await_in_scripts
to
main
November 2, 2025 12:17
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.

Reject codes like
({...a,} = {});like we reject([...a,] = []);.