feat(linter): move `no-unused-expressions` to correctness #14099

camchenry · 2025-09-25T01:37:18Z

closes linter: change no-unused-expressions to correctness #13796

Moves no-unused-expressions rule to be correctness and run by default. Also updates the config to have a JSON schema so that we can show the auto-generate the config options on the website.

camchenry · 2025-09-25T01:37:35Z

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

0-merge - adds this PR to the back of the merge queue
hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

codspeed-hq · 2025-09-25T01:50:32Z

CodSpeed Instrumentation Performance Report

Merging #14099 will not alter performance

_{Comparing 09-24-feat_linter_move_no-unused-expressions_to_correctness (1472147) with main (07a0c86)¹}

Summary

✅ 4 untouched
⏩ 33 skipped²

No successful run was found on main (1472147) during the generation of this report, so 07a0c86 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩
33 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

Copilot

Pull Request Overview

This PR moves the no-unused-expressions rule from the "restriction" category to the "correctness" category, making it run by default. It also updates the rule's diagnostic message to be more specific and adds JSON schema support for configuration options.

Key changes:

Changes rule category from restriction to correctness (now runs by default)
Updates diagnostic message from "Disallow unused expressions" to "Expected expression to be used"
Improves help text from "Consider removing this expression" to "Consider using this expression or removing it"
Adds JSON schema support with field documentation for configuration options

Reviewed Changes

Copilot reviewed 52 out of 52 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
`crates/oxc_linter/src/rules/eslint/no_unused_expressions.rs`	Main rule implementation with category change, message updates, and JSON schema support
`crates/oxc_linter/src/snapshots/eslint_no_unused_expressions.snap`	Updated test snapshots reflecting new diagnostic messages
`crates/oxc_language_server/src/snapshots/...`	Language server test snapshot with additional no-unused-expressions diagnostic
`apps/oxlint/test/__snapshots__/e2e.test.ts.snap`	E2E test snapshot showing additional diagnostic from now-enabled rule
Multiple `apps/oxlint/src/snapshots/...` files	CLI test snapshots with updated rule counts (88→89 rules) due to rule now being enabled by default

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

graphite-app · 2025-09-25T07:49:51Z

Merge activity

Sep 25, 7:49 AM UTC: camc314 added this pull request to the Graphite merge queue.
Sep 25, 7:55 AM UTC: Merged by the Graphite merge queue.

- closes #13796 Moves `no-unused-expressions` rule to be `correctness` and run by default. Also updates the config to have a JSON schema so that we can show the auto-generate the config options on the website.

## [1.19.0] - 2025-09-29 ### 🚀 Features - eb6345f linter/unicorn: Implement no-array-callback-reference (#14230) (camc314) - c64fa61 linter: Add `import/no-named-export` rule (#14229) (yefan) - d30159b linter: Fix for unsorted keys (#14225) (Hamir Mahal) - acd1266 linter/plugins: `oxlint` export types (#14163) (overlookmotel) - c0e461f linter: Add `unicorn/no-array-sort` rule (#14117) (Cason Kervis) - 00954de linter/plugins: Remove `--js-plugins` CLI option (#14134) (overlookmotel) - b4d716f linter/plugins: Move custom JS plugin config to `jsPlugins` (#14133) (overlookmotel) - 60f0b3f linter: Add fix for `preserve-caught-error` (#14104) (Cam McHenry) - 2d74c17 linter/no-multiple-resolved: Implement promise rule no-multiple-resolved (#13420) (Li Wei) - 5e05d1b semantic: Put jsdoc behind linter feature, remove runtime flag (#14140) (Boshen) - 71af1aa semantic: Add "linter" feature (#14139) (Boshen) - 1a6d7ae linter: Add `vue/max-props` rule (#14039) (yefan) - 9c3afea linter/plugins: Support fixes (#14094) (overlookmotel) - 1472147 linter: Move `no-unused-expressions` to correctness (#14099) (camchenry) - 8b7c784 linter: Add react/jsx-pascal-case rule (#12165) (Mikhail Baev) - c796966 linter/plugins: Add `meta` property to rules (#14089) (overlookmotel) ### 🐛 Bug Fixes - 39a171e linter: Get cli args on JS side, to avoid runtime inconsistencies (#14223) (camc314) - e045391 linter/plugins: Error on JS plugin with reserved name (#14226) (overlookmotel) - 6005015 linter: Correctly handle CRLF when inserting disable comments in framework files (#14228) (shulaoda) - 37f6b09 linter/plugins: Make `null` a valid value for `meta.fixable` (#14204) (overlookmotel) - 8879b5a linter/plugins: Add types export to `npm/oxlint` (#14219) (overlookmotel) - e37c435 language_server: Correct position for "ignore this rule for this file" in vue/astro/svelte files (#14187) (Sysix) - f8abab2 editor: Stricter path validation for `oxc.path.server` (#14202) (Sysix) - e9a14d1 linter/plugins: Allow `fix` function to return `undefined` (#14182) (overlookmotel) - ee9ecbe linter/plugins: Fix TS type for fixer methods (#14166) (overlookmotel) - 03d1684 linter/plugins: Output warning on first JS plugin load (#14165) (overlookmotel) - 9716f7c linter/plugins: Fix TS types (#14162) (overlookmotel) - d36d227 language_server: Don't lint file on code action when it is already ignored (#13976) (Sysix) - 353bfe7 language_server: Check if tsconfig path is a file before starting the `LintService` (#14126) (Sysix) - fc7026d linter: Add missing `NODE_TYPES`, `cfg_id` method for no-multiple-resolved (#14147) (camc314) - 180c790 linter: Fix false positive in `no-restricted-globals` (#14135) (yefan) - 4a4fce8 linter: Fix cli argument parsing (#14112) (camc314) - 9f3e2bc linter/plugins: Output errors thrown in JS plugins (#14096) (overlookmotel) - 357a2d3 linter: Add support for `tsgolint.exe` on Windows (#14101) (camchenry) - 2604b28 linter: Fix lint errors building `oxlint` (#14095) (overlookmotel) - d8e9cc5 linter/plugins: Validate type of `before` and `after` hooks (#14086) (overlookmotel) ### 🚜 Refactor - 4c3f1ac linter: Move `BUILT_IN_ERRORS` to utils file (#14221) (camc314) - 61ec0a7 linter/plugins: Simplify creation of `context` in `defineRule` ESLint shim (#14206) (overlookmotel) - 7a0eb57 language_server: Refactor ignore code action logic as a linter fix (#14183) (Sysix) - 3b1fe6f linter/plugins: Flatten directory structure of `dist` (#14199) (overlookmotel) - d52cba6 linter: Bump TSDown to latest (#14198) (overlookmotel) - 983dd1b linter/plugins: Add `Fixer` type (#14180) (overlookmotel) - 2f8b076 linter/plugins: Remove dead code (#14178) (overlookmotel) - 497236e semantic: Move AstNode::cfg_id to struct of arrays in AstNodes (#14137) (Boshen) - 5ba765c semantic: Move AstNode::flags to struct of arrays in AstNodes (#14136) (Boshen) - ffc810d linter: `preserve-caught-errors`: rename config and add docs (#14103) (camchenry) - f91db73 linter: Add `CompositeFix::merge_fixes_fallible` method (#14093) (overlookmotel) - e55ffe0 curly: Enhance curly brace rule configuration and handling (#13498) (Antoine Zanardi) - 2fb69fd eslint/eqeqeq: Clean up implementation and improve documentation (#13527) (Antoine Zanardi) - e69cd86 linter/plugins: `loadPluginImpl` return an object (#14087) (overlookmotel) ### 📚 Documentation - b83b1bd language_server: Docs for `Backend` struct (#14172) (Sysix) - 3106ba0 language_server: Docs for `WorkspaceWorker` (#14161) (Sysix) - b19f5bc linter/plugins: Improve JSDoc comments for `definePlugin` and `defineRule` (#14159) (overlookmotel) ### ⚡ Performance - 2575065 linter/plugins: Store if rule is fixable as boolean (#14205) (overlookmotel) - b6d2546 linter: Reduce string cloning in tsgo fixes (#14092) (overlookmotel) - c94c5dc linter: Remove allocation in `CompositeFix::merge_fixes` (#14090) (overlookmotel) ### 🧪 Testing - be58d6d language_server: Fix test for ServerFormatter in windows (#14210) (Sysix) - a9b603e linter/plugins: Convert all plugins in tests to TS (#14200) (overlookmotel) - 6ff3a23 linter/plugins: Add tests for `.ts`, `.mts`, `.cts` plugin files (#14164) (overlookmotel) - 8988d64 linter/plugins: Add line breaks to plugins files (#14181) (overlookmotel) - d7041c1 language_server: Add linebreaks for formatter snapshot (#14173) (Sysix) - 52db331 linter/plugins: Type-check test fixtures (#14158) (overlookmotel) - aca083a linter/plugins: Include stderr output in snapshots (#14155) (overlookmotel) - a3c8f46 linter/plugins: Do not run `pnpm` in tests (#14157) (overlookmotel) - d985aeb editor: Remove cross-module tests, covered by language server (#14156) (Sysix) - 0029b7f linter/plugins: Normalize line breaks in snapshots (#14154) (overlookmotel) - 7f2c101 linter/plugins: Specify path to `node` in tests (#14152) (overlookmotel) - fc14abc linter/plugins: Format test fixtures (#14125) (overlookmotel) - a6f965f linter/plugins: Simplify configs in test fixtures (#14124) (overlookmotel) - b1685f7 linter/plugins: Refactor tests (#14123) (overlookmotel) - 788e495 linter/plugins: Improve ESLint compat tests (#14119) (overlookmotel) - 5750077 linter/plugins: Fix file paths in snapshots (#14115) (overlookmotel) - 5c862f9 linter/plugins: Standardize test fixture structure (#14114) (overlookmotel) Co-authored-by: camc314 <18101008+camc314@users.noreply.github.com>

github-actions bot added A-linter Area - Linter A-cli Area - CLI A-editor Area - Editor and Language Server C-enhancement Category - New feature or request labels Sep 25, 2025

camchenry force-pushed the 09-24-feat_linter_move_no-unused-expressions_to_correctness branch from 26bd30b to 8397b14 Compare September 25, 2025 01:55

camchenry marked this pull request as ready for review September 25, 2025 02:16

camchenry requested review from Sysix and camc314 as code owners September 25, 2025 02:16

Copilot AI review requested due to automatic review settings September 25, 2025 02:16

camchenry mentioned this pull request Sep 25, 2025

fix(linter): add support for tsgolint.exe on Windows #14101

Merged

Copilot AI reviewed Sep 25, 2025

View reviewed changes

This was referenced Sep 25, 2025

refactor(linter): preserve-caught-errors: rename config and add docs #14103

Merged

feat(linter): add fix for preserve-caught-error #14104

Merged

graphite-app bot added the 0-merge Merge with Graphite Merge Queue label Sep 25, 2025

feat(linter): move no-unused-expressions to correctness (#14099)

1472147

- closes #13796 Moves `no-unused-expressions` rule to be `correctness` and run by default. Also updates the config to have a JSON schema so that we can show the auto-generate the config options on the website.

graphite-app bot force-pushed the 09-24-feat_linter_move_no-unused-expressions_to_correctness branch from 8397b14 to 1472147 Compare September 25, 2025 07:50

graphite-app bot merged commit 1472147 into main Sep 25, 2025
20 checks passed

graphite-app bot deleted the 09-24-feat_linter_move_no-unused-expressions_to_correctness branch September 25, 2025 07:55

graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Sep 25, 2025

Boshen mentioned this pull request Sep 29, 2025

release(oxlint): v1.19.0 #14231

Merged

skovhus mentioned this pull request Oct 1, 2025

linter: no-unused-expressions false positives #14275

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

feat(linter): move `no-unused-expressions` to correctness #14099

feat(linter): move `no-unused-expressions` to correctness #14099

Uh oh!

camchenry commented Sep 25, 2025 •

edited

Loading

Uh oh!

camchenry commented Sep 25, 2025 •

edited

Loading

Uh oh!

codspeed-hq bot commented Sep 25, 2025 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

graphite-app bot commented Sep 25, 2025 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

feat(linter): move no-unused-expressions to correctness #14099

feat(linter): move no-unused-expressions to correctness #14099

Uh oh!

Conversation

camchenry commented Sep 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

camchenry commented Sep 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

How to use the Graphite Merge Queue

Uh oh!

codspeed-hq bot commented Sep 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

CodSpeed Instrumentation Performance Report

Merging #14099 will not alter performance

Summary

Footnotes

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

graphite-app bot commented Sep 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

feat(linter): move `no-unused-expressions` to correctness #14099

feat(linter): move `no-unused-expressions` to correctness #14099

camchenry commented Sep 25, 2025 •

edited

Loading

camchenry commented Sep 25, 2025 •

edited

Loading

codspeed-hq bot commented Sep 25, 2025 •

edited

Loading

graphite-app bot commented Sep 25, 2025 •

edited

Loading