fix(language_server): don't lint file on code action when it is already ignored #13976

Sysix · 2025-09-21T13:46:02Z

part of #13778

before:

Even if the file is ignored or not supported by both linters, the code actions would re trigger a lint task.

after:

respect the None result which indicates the ignore status

Sysix · 2025-09-21T13:46:21Z

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

0-merge - adds this PR to the back of the merge queue
hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

codspeed-hq · 2025-09-21T13:50:43Z

CodSpeed Instrumentation Performance Report

Merging #13976 will not alter performance

_{Comparing 09-21-fix_language_server_don_t_lint_file_on_code_action_when_it_is_already_ignored (5846986) with main (b7fb7ba)¹}

Summary

✅ 37 untouched

No successful run was found on main (c796966) during the generation of this report, so b7fb7ba was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

Copilot

Pull Request Overview

This PR fixes an issue where the language server would unnecessarily re-trigger linting tasks for files that are already ignored or unsupported by linters. The fix ensures that when a file has an explicit ignore status (represented by a None result in the cache), no additional linting is performed.

Updated the get_diagnostics method to properly handle None entries that indicate ignored files
Added test coverage to verify the behavior when files are ignored vs missing from cache
Made diagnostic structs derive Default to support testing

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File	Description
crates/oxc_language_server/src/linter/server_linter.rs	Fixed logic to respect `None` entries indicating ignored files and added comprehensive test coverage
crates/oxc_language_server/src/linter/error_with_position.rs	Added `Default` derive to support test creation
editors/vscode/tests/code_actions.spec.ts	Minor test improvements for stability

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

crates/oxc_language_server/src/linter/server_linter.rs

graphite-app · 2025-09-26T13:26:26Z

Merge activity

Sep 26, 1:26 PM UTC: camc314 added this pull request to the Graphite merge queue.
Sep 26, 1:34 PM UTC: Merged by the Graphite merge queue.

…dy ignored (#13976) part of #13778 ## before: Even if the file is ignored or not supported by both linters, the code actions would re trigger a lint task. ## after: respect the `None` result which indicates the ignore status

## [1.19.0] - 2025-09-29 ### 🚀 Features - eb6345f linter/unicorn: Implement no-array-callback-reference (#14230) (camc314) - c64fa61 linter: Add `import/no-named-export` rule (#14229) (yefan) - d30159b linter: Fix for unsorted keys (#14225) (Hamir Mahal) - acd1266 linter/plugins: `oxlint` export types (#14163) (overlookmotel) - c0e461f linter: Add `unicorn/no-array-sort` rule (#14117) (Cason Kervis) - 00954de linter/plugins: Remove `--js-plugins` CLI option (#14134) (overlookmotel) - b4d716f linter/plugins: Move custom JS plugin config to `jsPlugins` (#14133) (overlookmotel) - 60f0b3f linter: Add fix for `preserve-caught-error` (#14104) (Cam McHenry) - 2d74c17 linter/no-multiple-resolved: Implement promise rule no-multiple-resolved (#13420) (Li Wei) - 5e05d1b semantic: Put jsdoc behind linter feature, remove runtime flag (#14140) (Boshen) - 71af1aa semantic: Add "linter" feature (#14139) (Boshen) - 1a6d7ae linter: Add `vue/max-props` rule (#14039) (yefan) - 9c3afea linter/plugins: Support fixes (#14094) (overlookmotel) - 1472147 linter: Move `no-unused-expressions` to correctness (#14099) (camchenry) - 8b7c784 linter: Add react/jsx-pascal-case rule (#12165) (Mikhail Baev) - c796966 linter/plugins: Add `meta` property to rules (#14089) (overlookmotel) ### 🐛 Bug Fixes - 39a171e linter: Get cli args on JS side, to avoid runtime inconsistencies (#14223) (camc314) - e045391 linter/plugins: Error on JS plugin with reserved name (#14226) (overlookmotel) - 6005015 linter: Correctly handle CRLF when inserting disable comments in framework files (#14228) (shulaoda) - 37f6b09 linter/plugins: Make `null` a valid value for `meta.fixable` (#14204) (overlookmotel) - 8879b5a linter/plugins: Add types export to `npm/oxlint` (#14219) (overlookmotel) - e37c435 language_server: Correct position for "ignore this rule for this file" in vue/astro/svelte files (#14187) (Sysix) - f8abab2 editor: Stricter path validation for `oxc.path.server` (#14202) (Sysix) - e9a14d1 linter/plugins: Allow `fix` function to return `undefined` (#14182) (overlookmotel) - ee9ecbe linter/plugins: Fix TS type for fixer methods (#14166) (overlookmotel) - 03d1684 linter/plugins: Output warning on first JS plugin load (#14165) (overlookmotel) - 9716f7c linter/plugins: Fix TS types (#14162) (overlookmotel) - d36d227 language_server: Don't lint file on code action when it is already ignored (#13976) (Sysix) - 353bfe7 language_server: Check if tsconfig path is a file before starting the `LintService` (#14126) (Sysix) - fc7026d linter: Add missing `NODE_TYPES`, `cfg_id` method for no-multiple-resolved (#14147) (camc314) - 180c790 linter: Fix false positive in `no-restricted-globals` (#14135) (yefan) - 4a4fce8 linter: Fix cli argument parsing (#14112) (camc314) - 9f3e2bc linter/plugins: Output errors thrown in JS plugins (#14096) (overlookmotel) - 357a2d3 linter: Add support for `tsgolint.exe` on Windows (#14101) (camchenry) - 2604b28 linter: Fix lint errors building `oxlint` (#14095) (overlookmotel) - d8e9cc5 linter/plugins: Validate type of `before` and `after` hooks (#14086) (overlookmotel) ### 🚜 Refactor - 4c3f1ac linter: Move `BUILT_IN_ERRORS` to utils file (#14221) (camc314) - 61ec0a7 linter/plugins: Simplify creation of `context` in `defineRule` ESLint shim (#14206) (overlookmotel) - 7a0eb57 language_server: Refactor ignore code action logic as a linter fix (#14183) (Sysix) - 3b1fe6f linter/plugins: Flatten directory structure of `dist` (#14199) (overlookmotel) - d52cba6 linter: Bump TSDown to latest (#14198) (overlookmotel) - 983dd1b linter/plugins: Add `Fixer` type (#14180) (overlookmotel) - 2f8b076 linter/plugins: Remove dead code (#14178) (overlookmotel) - 497236e semantic: Move AstNode::cfg_id to struct of arrays in AstNodes (#14137) (Boshen) - 5ba765c semantic: Move AstNode::flags to struct of arrays in AstNodes (#14136) (Boshen) - ffc810d linter: `preserve-caught-errors`: rename config and add docs (#14103) (camchenry) - f91db73 linter: Add `CompositeFix::merge_fixes_fallible` method (#14093) (overlookmotel) - e55ffe0 curly: Enhance curly brace rule configuration and handling (#13498) (Antoine Zanardi) - 2fb69fd eslint/eqeqeq: Clean up implementation and improve documentation (#13527) (Antoine Zanardi) - e69cd86 linter/plugins: `loadPluginImpl` return an object (#14087) (overlookmotel) ### 📚 Documentation - b83b1bd language_server: Docs for `Backend` struct (#14172) (Sysix) - 3106ba0 language_server: Docs for `WorkspaceWorker` (#14161) (Sysix) - b19f5bc linter/plugins: Improve JSDoc comments for `definePlugin` and `defineRule` (#14159) (overlookmotel) ### ⚡ Performance - 2575065 linter/plugins: Store if rule is fixable as boolean (#14205) (overlookmotel) - b6d2546 linter: Reduce string cloning in tsgo fixes (#14092) (overlookmotel) - c94c5dc linter: Remove allocation in `CompositeFix::merge_fixes` (#14090) (overlookmotel) ### 🧪 Testing - be58d6d language_server: Fix test for ServerFormatter in windows (#14210) (Sysix) - a9b603e linter/plugins: Convert all plugins in tests to TS (#14200) (overlookmotel) - 6ff3a23 linter/plugins: Add tests for `.ts`, `.mts`, `.cts` plugin files (#14164) (overlookmotel) - 8988d64 linter/plugins: Add line breaks to plugins files (#14181) (overlookmotel) - d7041c1 language_server: Add linebreaks for formatter snapshot (#14173) (Sysix) - 52db331 linter/plugins: Type-check test fixtures (#14158) (overlookmotel) - aca083a linter/plugins: Include stderr output in snapshots (#14155) (overlookmotel) - a3c8f46 linter/plugins: Do not run `pnpm` in tests (#14157) (overlookmotel) - d985aeb editor: Remove cross-module tests, covered by language server (#14156) (Sysix) - 0029b7f linter/plugins: Normalize line breaks in snapshots (#14154) (overlookmotel) - 7f2c101 linter/plugins: Specify path to `node` in tests (#14152) (overlookmotel) - fc14abc linter/plugins: Format test fixtures (#14125) (overlookmotel) - a6f965f linter/plugins: Simplify configs in test fixtures (#14124) (overlookmotel) - b1685f7 linter/plugins: Refactor tests (#14123) (overlookmotel) - 788e495 linter/plugins: Improve ESLint compat tests (#14119) (overlookmotel) - 5750077 linter/plugins: Fix file paths in snapshots (#14115) (overlookmotel) - 5c862f9 linter/plugins: Standardize test fixture structure (#14114) (overlookmotel) Co-authored-by: camc314 <18101008+camc314@users.noreply.github.com>

Sysix mentioned this pull request Sep 21, 2025

refactor(language_server): use minimal text edit for ServerFormatter #13960

Merged

github-actions bot added the A-editor Area - Editor and Language Server label Sep 21, 2025

Sysix mentioned this pull request Sep 21, 2025

test(language_server): add test_and_snapshot_multiple_file #13966

Merged

Sysix mentioned this pull request Sep 21, 2025

test(language_server): add Tester for ServerFormatter #13969

Merged

github-actions bot added the C-bug Category - Bug label Sep 21, 2025

Sysix force-pushed the 09-21-fix_language_server_don_t_lint_file_on_code_action_when_it_is_already_ignored branch from 4346cbf to 1b6ea67 Compare September 21, 2025 16:45

graphite-app bot changed the base branch from 09-21-test_language_server_add_tester_for_serverformatter to graphite-base/13976 September 21, 2025 17:35

graphite-app bot force-pushed the graphite-base/13976 branch from b4ed5a3 to 2600858 Compare September 21, 2025 17:41

graphite-app bot force-pushed the 09-21-fix_language_server_don_t_lint_file_on_code_action_when_it_is_already_ignored branch from 1b6ea67 to 54e041c Compare September 21, 2025 17:41

graphite-app bot changed the base branch from graphite-base/13976 to main September 21, 2025 17:42

graphite-app bot force-pushed the 09-21-fix_language_server_don_t_lint_file_on_code_action_when_it_is_already_ignored branch from 54e041c to 194c258 Compare September 21, 2025 17:42

Sysix force-pushed the 09-21-fix_language_server_don_t_lint_file_on_code_action_when_it_is_already_ignored branch 2 times, most recently from 5846986 to 3f66c6c Compare September 25, 2025 20:18

Sysix marked this pull request as ready for review September 26, 2025 13:17

Sysix requested a review from camc314 as a code owner September 26, 2025 13:17

Copilot AI review requested due to automatic review settings September 26, 2025 13:17

Copilot AI reviewed Sep 26, 2025

View reviewed changes

crates/oxc_language_server/src/linter/server_linter.rs Show resolved Hide resolved

crates/oxc_language_server/src/linter/server_linter.rs Show resolved Hide resolved

graphite-app bot force-pushed the 09-21-fix_language_server_don_t_lint_file_on_code_action_when_it_is_already_ignored branch from 3f66c6c to d36d227 Compare September 26, 2025 13:30

graphite-app bot merged commit d36d227 into main Sep 26, 2025
20 checks passed

graphite-app bot deleted the 09-21-fix_language_server_don_t_lint_file_on_code_action_when_it_is_already_ignored branch September 26, 2025 13:34

Boshen mentioned this pull request Sep 29, 2025

release(oxlint): v1.19.0 #14231

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

fix(language_server): don't lint file on code action when it is already ignored #13976

fix(language_server): don't lint file on code action when it is already ignored #13976

Uh oh!

Sysix commented Sep 21, 2025 •

edited

Loading

Uh oh!

Sysix commented Sep 21, 2025 •

edited

Loading

Uh oh!

codspeed-hq bot commented Sep 21, 2025 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

graphite-app bot commented Sep 26, 2025 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

fix(language_server): don't lint file on code action when it is already ignored #13976

fix(language_server): don't lint file on code action when it is already ignored #13976

Uh oh!

Conversation

Sysix commented Sep 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

before:

after:

Uh oh!

Sysix commented Sep 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

How to use the Graphite Merge Queue

Uh oh!

codspeed-hq bot commented Sep 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

CodSpeed Instrumentation Performance Report

Merging #13976 will not alter performance

Summary

Footnotes

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

graphite-app bot commented Sep 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Sysix commented Sep 21, 2025 •

edited

Loading

Sysix commented Sep 21, 2025 •

edited

Loading

codspeed-hq bot commented Sep 21, 2025 •

edited

Loading

graphite-app bot commented Sep 26, 2025 •

edited

Loading