fix(linter/plugins): error on JS plugin with reserved name (#14226)

Raise an error if a JS plugin has same name as a built-in plugin e.g. `import`. It'd be impossible to know whether `import/rule-name` was referring to the built-in rule, or the JS plugin's rule of same name.

Author: overlookmotel

apps/oxlint/test/e2e.test.ts

@@ -65,6 +65,10 @@ describe('oxlint CLI', () => {
     await testFixture('missing_custom_plugin');
   });
 
+  it('should report an error if a custom plugin has a reserved name', async () => {
+    await testFixture('reserved_name');
+  });
+
   it('should report an error if a custom plugin throws an error during import', async () => {
     await testFixture('custom_plugin_import_error');
   });

apps/oxlint/test/fixtures/reserved_name/.oxlintrc.json

@@ -0,0 +1,3 @@
+{
+  "jsPlugins": ["./plugin.ts"]
+}

apps/oxlint/test/fixtures/reserved_name/output.snap.md

@@ -0,0 +1,15 @@
+# Exit code
+1
+
+# stdout
+```
+Failed to parse configuration file.
+
+  x Plugin name 'import' is reserved, and cannot be used for JS plugins
+```
+
+# stderr
+```
+WARNING: JS plugins are experimental and not subject to semver.
+Breaking changes are possible while JS plugins support is under development.
+```

apps/oxlint/test/fixtures/reserved_name/plugin.ts

@@ -0,0 +1,10 @@
+import type { Plugin } from '../../../dist/index.js';
+
+const plugin: Plugin = {
+  meta: {
+    name: 'import', // Reserved name
+  },
+  rules: {},
+};
+
+export default plugin;

crates/oxc_linter/src/config/config_builder.rs

@@ -532,8 +532,12 @@ impl ConfigStoreBuilder {
 
         match result {
             PluginLoadResult::Success { name, offset, rule_names } => {
-                external_plugin_store.register_plugin(plugin_path, name, offset, rule_names);
-                Ok(())
+                if name != "eslint" && LintPlugins::from(name.as_str()) == LintPlugins::empty() {
+                    external_plugin_store.register_plugin(plugin_path, name, offset, rule_names);
+                    Ok(())
+                } else {
+                    Err(ConfigBuilderError::ReservedExternalPluginName { plugin_name: name })
+                }
             }
             PluginLoadResult::Failure(e) => Err(ConfigBuilderError::PluginLoadFailed {
                 plugin_specifier: plugin_specifier.to_string(),
@@ -580,6 +584,9 @@ pub enum ConfigBuilderError {
     NoExternalLinterConfigured {
         plugin_specifier: String,
     },
+    ReservedExternalPluginName {
+        plugin_name: String,
+    },
 }
 
 impl Display for ConfigBuilderError {
@@ -610,6 +617,13 @@ impl Display for ConfigBuilderError {
                 )?;
                 Ok(())
             }
+            ConfigBuilderError::ReservedExternalPluginName { plugin_name } => {
+                write!(
+                    f,
+                    "Plugin name '{plugin_name}' is reserved, and cannot be used for JS plugins",
+                )?;
+                Ok(())
+            }
             ConfigBuilderError::ExternalRuleLookupError(e) => std::fmt::Display::fmt(&e, f),
         }
     }