Skip to content

Conversation

@sapphi-red
Copy link
Member

@sapphi-red sapphi-red commented Aug 28, 2025

added end mappings for array literals and object literals to fix stack trace.

refs #13180

Copy link
Member Author

sapphi-red commented Aug 28, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@codspeed-hq
Copy link

codspeed-hq bot commented Aug 28, 2025

CodSpeed Instrumentation Performance Report

Merging #13354 will degrade performances by 4.58%

Comparing 08-29-fix_codegen_add_end_sourcemaps_for_array_literals_and_object_literals (1044566) with main (7aff3b6)1

Summary

❌ 1 regressions
✅ 37 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
mangler[RadixUIAdoptionSection.jsx] 14.1 µs 14.8 µs -4.58%

Footnotes

  1. No successful run was found on main (1044566) during the generation of this report, so 7aff3b6 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@sapphi-red sapphi-red marked this pull request as ready for review August 28, 2025 16:15
@graphite-app graphite-app bot added the 0-merge Merge with Graphite Merge Queue label Aug 29, 2025
@graphite-app
Copy link
Contributor

graphite-app bot commented Aug 29, 2025

Merge activity

…ls (#13354)

added end mappings for array literals and object literals to fix stack trace.

refs #13180
@graphite-app graphite-app bot force-pushed the 08-28-test_codegen_add_test_that_verifies_stack_traces_are_correct branch from 6e8a298 to f547c94 Compare August 29, 2025 02:38
@graphite-app graphite-app bot force-pushed the 08-29-fix_codegen_add_end_sourcemaps_for_array_literals_and_object_literals branch from c3b7fd3 to 1044566 Compare August 29, 2025 02:39
Base automatically changed from 08-28-test_codegen_add_test_that_verifies_stack_traces_are_correct to main August 29, 2025 02:43
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Aug 29, 2025
@graphite-app graphite-app bot merged commit 1044566 into main Aug 29, 2025
25 checks passed
@graphite-app graphite-app bot deleted the 08-29-fix_codegen_add_end_sourcemaps_for_array_literals_and_object_literals branch August 29, 2025 02:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-codegen Area - Code Generation C-bug Category - Bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants