Skip to content

Conversation

@sapphi-red
Copy link
Member

@sapphi-red sapphi-red commented Aug 28, 2025

Added tests that verifies the stack traces are correct.

@github-actions github-actions bot added A-codegen Area - Code Generation C-test Category - Testing. Code is missing test cases, or a PR is adding them labels Aug 28, 2025
Copy link
Member Author

sapphi-red commented Aug 28, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@sapphi-red sapphi-red marked this pull request as ready for review August 28, 2025 13:22
@codspeed-hq
Copy link

codspeed-hq bot commented Aug 28, 2025

CodSpeed Instrumentation Performance Report

Merging #13351 will degrade performances by 6.51%

Comparing 08-28-test_codegen_add_test_that_verifies_stack_traces_are_correct (f547c94) with main (7aff3b6)1

Summary

⚡ 1 improvements
❌ 1 regressions
✅ 36 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
mangler[RadixUIAdoptionSection.jsx] 14.1 µs 15.1 µs -6.51%
mangler[cal.com.tsx] 3.4 ms 3.2 ms +4.29%

Footnotes

  1. No successful run was found on main (f547c94) during the generation of this report, so 7aff3b6 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@sapphi-red sapphi-red force-pushed the 08-28-test_codegen_add_test_that_verifies_stack_traces_are_correct branch from 9a4568e to 6e8a298 Compare August 28, 2025 15:56
@graphite-app graphite-app bot added the 0-merge Merge with Graphite Merge Queue label Aug 29, 2025
@graphite-app
Copy link
Contributor

graphite-app bot commented Aug 29, 2025

Merge activity

Added tests that verifies the stack traces are correct.
Copilot AI review requested due to automatic review settings August 29, 2025 02:38
@graphite-app graphite-app bot force-pushed the 08-28-test_codegen_add_test_that_verifies_stack_traces_are_correct branch from 6e8a298 to f547c94 Compare August 29, 2025 02:38
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@graphite-app graphite-app bot merged commit f547c94 into main Aug 29, 2025
24 checks passed
@graphite-app graphite-app bot deleted the 08-28-test_codegen_add_test_that_verifies_stack_traces_are_correct branch August 29, 2025 02:43
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Aug 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-codegen Area - Code Generation C-test Category - Testing. Code is missing test cases, or a PR is adding them

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants