Skip to content

fix(codegen): add end sourcemaps for array literals and object literals #13354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 29, 2025
Merged

fix(codegen): add end sourcemaps for array literals and object literals #13354

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions crates/oxc_codegen/src/gen.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1473,6 +1473,7 @@ impl Gen for ArrayExpression<'_> {
p.print_indent();
}
p.print_ascii_byte(b']');
p.add_source_mapping_end(self.span);
}
}

Expand Down Expand Up @@ -1515,6 +1516,7 @@ impl GenExpr for ObjectExpression<'_> {
p.print_soft_space();
}
p.print_ascii_byte(b'}');
p.add_source_mapping_end(self.span);
});
}
}
Expand Down
8 changes: 8 additions & 0 deletions crates/oxc_codegen/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -843,6 +843,14 @@ impl<'a> Codegen<'a> {
}
}

fn add_source_mapping_end(&mut self, span: Span) {
if let Some(sourcemap_builder) = self.sourcemap_builder.as_mut() {
if !span.is_empty() {
sourcemap_builder.add_source_mapping(self.code.as_bytes(), span.end, None);
}
}
}

fn add_source_mapping_for_name(&mut self, span: Span, name: &str) {
if let Some(sourcemap_builder) = self.sourcemap_builder.as_mut() {
if !span.is_empty() {
Expand Down
4 changes: 2 additions & 2 deletions crates/oxc_codegen/tests/integration/snapshots/stacktrace_is_correct.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,7 @@ obj.fn([1])();

Error
at <anonymous> (/project/input.js:5:19)
at <anonymous> (/project/input.js:9:9)
at <anonymous> (/project/input.js:9:11)

------------------------------------------------------
## Input
Expand Down Expand Up @@ -180,7 +180,7 @@ obj.fn({ a })();

Error
at <anonymous> (/project/input.js:6:19)
at <anonymous> (/project/input.js:10:9)
at <anonymous> (/project/input.js:10:11)

------------------------------------------------------
## Input
Expand Down
Loading