Skip to content

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Jul 31, 2025

Remove an unnecessary clone from SymbolTester. Don't need to clone the Reference only to pass a reference to it to filter. Just use the original &Reference.

Copy link
Member Author

overlookmotel commented Jul 31, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@codspeed-hq
Copy link

codspeed-hq bot commented Jul 31, 2025

CodSpeed Instrumentation Performance Report

Merging #12667 will not alter performance

Comparing 07-29-test_semantic_remove_unnecessary_clone (2aa65b9) with 07-29-refactor_linter_transformer_use_scoping_symbol_is_unused_ (77acc11)

Summary

✅ 34 untouched benchmarks

@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Jul 31, 2025
Copy link
Member

Boshen commented Jul 31, 2025

Merge activity

Remove an unnecessary `clone` from `SymbolTester`. Don't need to clone the `Reference` only to pass a reference to it to `filter`. Just use the original `&Reference`.
@graphite-app graphite-app bot force-pushed the 07-29-refactor_linter_transformer_use_scoping_symbol_is_unused_ branch from 5b28e87 to 77acc11 Compare July 31, 2025 15:33
@graphite-app graphite-app bot requested a review from camc314 as a code owner July 31, 2025 15:33
@graphite-app graphite-app bot force-pushed the 07-29-test_semantic_remove_unnecessary_clone branch from 566b8b2 to 2aa65b9 Compare July 31, 2025 15:34
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Jul 31, 2025
Base automatically changed from 07-29-refactor_linter_transformer_use_scoping_symbol_is_unused_ to main July 31, 2025 15:42
@graphite-app graphite-app bot merged commit 2aa65b9 into main Jul 31, 2025
25 checks passed
@graphite-app graphite-app bot deleted the 07-29-test_semantic_remove_unnecessary_clone branch July 31, 2025 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-semantic Area - Semantic C-test Category - Testing. Code is missing test cases, or a PR is adding them

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants