refactor(mangler): move NodeId lookup into is_name_set_reference_node

[overlookmotel]

Pure refactor. Follow-on after #12663. Move looking up NodeId for a Reference into is_name_set_reference_node. This makes it clearer that the ReferenceId and NodeId are connected.

[overlookmotel]

• test(semantic): remove unnecessary clone #12667
• refactor(linter, transformer): use Scoping::symbol_is_unused #12666
• refactor(semantic)!: Scoping::get_resolved_reference_ids return slice #12665
• refactor(mangler): move NodeId lookup into is_name_set_reference_node #12664 👈 (View in Graphite)
• perf(mangler): remove unnecessary AstNode lookups #12663
• main

---

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

• 0-merge - adds this PR to the back of the merge queue
• hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

[codspeed-hq]

CodSpeed Instrumentation Performance Report

Merging #12664 will not alter performance

_{Comparing 07-29-refactor_mangler_move_nodeid_lookup_into_is_name_set_reference_node_ (77d397a) with 07-29-perf_mangler_remove_unnecessary_astnode_lookups (4adc1ed)}

Summary

✅ 34 untouched benchmarks

[graphite-app]

Merge activity

• Jul 31, 3:27 PM UTC: Boshen added this pull request to the Graphite merge queue.
• Jul 31, 3:39 PM UTC: Merged by the Graphite merge queue.