refactor(semantic)!: Scoping::get_resolved_reference_ids return slice
#12665
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
A-semantic
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Jul 31, 2025
overlookmotel
changed the title
Scoping::get_resolved_reference_ids return sliceScoping::get_resolved_reference_ids return slice
CodSpeed Instrumentation Performance ReportMerging #12665 will not alter performanceComparing Summary
|
Contributor
Merge activity
|
…ce (#12665) It's more conventional for methods to return a `&[T]` instead of a `&Vec<T>`.
graphite-app
bot
force-pushed
the
07-29-refactor_mangler_move_nodeid_lookup_into_is_name_set_reference_node_
branch
from
e2723af to
77d397a
Compare
graphite-app
bot
force-pushed
the
07-29-refactor_semantic_scoping_get_resolved_reference_ids_return_slice
branch
from
4bc411b to
3175aa3
Compare
Base automatically changed from
07-29-refactor_mangler_move_nodeid_lookup_into_is_name_set_reference_node_
to
main
July 31, 2025 15:39
graphite-app
bot
deleted the
07-29-refactor_semantic_scoping_get_resolved_reference_ids_return_slice
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's more conventional for methods to return a
&[T]instead of a&Vec<T>.