feat(linter): add `vue/valid-define-emits` #12545

Sysix · 2025-07-27T12:04:24Z

https://github.com/vuejs/eslint-plugin-vue/blob/master/docs/rules/valid-define-emits.md

Extended the docs and tests to cover (non) empty defineEmits() with export default of other script block.
Related vuejs/eslint-plugin-vue#2914

Sysix · 2025-07-27T12:04:33Z

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

0-merge - adds this PR to the back of the merge queue
hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

codspeed-hq · 2025-07-27T12:11:42Z

CodSpeed Instrumentation Performance Report

Merging #12545 will not alter performance

_{Comparing 07-27-feat_linter_add_vue_valid-define-emits_ (5b91f3c) with main (6431033)¹}

Summary

✅ 34 untouched benchmarks

No successful run was found on main (5b91f3c) during the generation of this report, so 6431033 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

crates/oxc_linter/src/rules/vue/valid_define_emits.rs

crates/oxc_linter/src/snapshots/vue_valid_define_emits.snap

Moved this PR into an own stack to fix the bug in #12545

crates/oxc_linter/src/rules/vue/valid_define_emits.rs

Sysix · 2025-08-17T13:08:26Z

/ping @camc314
I synced the stack with main.

Boshen · 2025-08-27T02:02:16Z

Merge activity

Aug 27, 2:02 AM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
Aug 27, 2:02 AM UTC: Boshen added this pull request to the Graphite merge queue.
Aug 27, 2:08 AM UTC: Merged by the Graphite merge queue.

related #11440 https://github.com/vuejs/eslint-plugin-vue/blob/master/docs/rules/valid-define-emits.md Extended the docs and tests to cover (non) empty `defineEmits()` with `export default` of other script block. Related vuejs/eslint-plugin-vue#2914

This was referenced Jul 27, 2025

refactor(linter): add setup detection for vue files #12541

Closed

refactor(linter): add vue and regex to BuiltinLintPlugins #12542

Merged

chore(rulegen): add new-vue-rule just command #12543

Merged

github-actions bot added A-linter Area - Linter C-enhancement Category - New feature or request labels Jul 27, 2025

Sysix force-pushed the 07-27-feat_linter_add_vue_valid-define-emits_ branch from e06586b to cf7505c Compare July 27, 2025 12:05

Sysix force-pushed the 07-26-refactor_linter_add_setup_detection_for_vue_files branch from 4658fba to 8f63297 Compare July 27, 2025 12:05

graphite-app bot force-pushed the 07-26-refactor_linter_add_setup_detection_for_vue_files branch 2 times, most recently from 6df5bd5 to 363330d Compare July 27, 2025 12:38

graphite-app bot force-pushed the 07-27-feat_linter_add_vue_valid-define-emits_ branch from cf7505c to 3092f5a Compare July 27, 2025 12:38

Sysix force-pushed the 07-27-feat_linter_add_vue_valid-define-emits_ branch from 3092f5a to 3a47b3c Compare July 27, 2025 14:55

Sysix force-pushed the 07-26-refactor_linter_add_setup_detection_for_vue_files branch from 363330d to cb96836 Compare July 28, 2025 18:34

Sysix force-pushed the 07-27-feat_linter_add_vue_valid-define-emits_ branch from 93a08b0 to 1e94d0b Compare July 28, 2025 18:34

Sysix marked this pull request as ready for review July 28, 2025 18:53

Sysix requested a review from camc314 as a code owner July 28, 2025 18:53

graphite-app bot reviewed Jul 28, 2025

View reviewed changes

crates/oxc_linter/src/rules/vue/valid_define_emits.rs Show resolved Hide resolved

Sysix force-pushed the 07-27-feat_linter_add_vue_valid-define-emits_ branch from 1e94d0b to 7216d4d Compare July 28, 2025 18:57

Sysix commented Jul 28, 2025

View reviewed changes

crates/oxc_linter/src/snapshots/vue_valid_define_emits.snap Show resolved Hide resolved

Sysix marked this pull request as draft July 29, 2025 17:26

This was referenced Jul 29, 2025

feat: add mut LabelSpan.set_span_offset oxc-project/oxc-miette#62

Merged

test(linter): fix offset for partical source texts #12594

Merged

Sysix marked this pull request as ready for review July 29, 2025 20:34

Sysix mentioned this pull request Jul 29, 2025

refactor(linter): simplify offset adjustment by using Message.move_offset #12595

Merged

graphite-app bot pushed a commit that referenced this pull request Jul 31, 2025

test(linter): fix offset for partical source texts (#12594)

2ceb835

Moved this PR into an own stack to fix the bug in #12545

Sysix force-pushed the 07-26-refactor_linter_add_setup_detection_for_vue_files branch from cb96836 to cdf6b57 Compare July 31, 2025 17:25

Sysix force-pushed the 07-27-feat_linter_add_vue_valid-define-emits_ branch from 7216d4d to 5ee13db Compare July 31, 2025 17:25

Sysix marked this pull request as draft August 1, 2025 13:48

Sysix changed the base branch from 07-26-refactor_linter_add_setup_detection_for_vue_files to graphite-base/12545 August 3, 2025 12:38

Sysix force-pushed the 07-27-feat_linter_add_vue_valid-define-emits_ branch from 9d7836f to a59c687 Compare August 4, 2025 17:45

Sysix marked this pull request as ready for review August 4, 2025 17:50

graphite-app bot reviewed Aug 4, 2025

View reviewed changes

crates/oxc_linter/src/rules/vue/valid_define_emits.rs Show resolved Hide resolved

Sysix force-pushed the 07-27-feat_linter_add_vue_valid-define-emits_ branch from a59c687 to 6d1cad5 Compare August 4, 2025 17:53

Sysix force-pushed the 08-02-refactor_linter_run_linter_with_contextsubhost_ branch from 9a5d730 to 4fed1ef Compare August 4, 2025 18:01

Sysix force-pushed the 07-27-feat_linter_add_vue_valid-define-emits_ branch 3 times, most recently from 42bf821 to f5c9c83 Compare August 5, 2025 17:59

Sysix force-pushed the 08-02-refactor_linter_run_linter_with_contextsubhost_ branch 2 times, most recently from 0b97694 to 2724683 Compare August 9, 2025 14:56

Sysix force-pushed the 07-27-feat_linter_add_vue_valid-define-emits_ branch 2 times, most recently from 31250fd to f665d07 Compare August 13, 2025 17:54

Sysix force-pushed the 08-02-refactor_linter_run_linter_with_contextsubhost_ branch from 2724683 to bf34941 Compare August 13, 2025 17:54

Sysix force-pushed the 07-27-feat_linter_add_vue_valid-define-emits_ branch from f665d07 to 21af1a1 Compare August 17, 2025 12:47

Sysix force-pushed the 08-02-refactor_linter_run_linter_with_contextsubhost_ branch from bf34941 to 2ae79ad Compare August 17, 2025 12:47

Sysix force-pushed the 07-27-feat_linter_add_vue_valid-define-emits_ branch from 21af1a1 to c6d2a41 Compare August 17, 2025 12:52

Sysix force-pushed the 08-02-refactor_linter_run_linter_with_contextsubhost_ branch from 2ae79ad to d7b4ebf Compare August 17, 2025 12:52

Sysix force-pushed the 07-27-feat_linter_add_vue_valid-define-emits_ branch from c6d2a41 to a3d475b Compare August 26, 2025 19:34

Sysix force-pushed the 08-02-refactor_linter_run_linter_with_contextsubhost_ branch from d7b4ebf to 9bac168 Compare August 26, 2025 19:34

Boshen added the 0-merge Merge with Graphite Merge Queue label Aug 27, 2025

graphite-app bot force-pushed the 08-02-refactor_linter_run_linter_with_contextsubhost_ branch from 9bac168 to e871dab Compare August 27, 2025 02:03

graphite-app bot force-pushed the 07-27-feat_linter_add_vue_valid-define-emits_ branch from a3d475b to 5b91f3c Compare August 27, 2025 02:03

graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Aug 27, 2025

Base automatically changed from 08-02-refactor_linter_run_linter_with_contextsubhost_ to main August 27, 2025 02:07

graphite-app bot merged commit 5b91f3c into main Aug 27, 2025
25 checks passed

graphite-app bot deleted the 07-27-feat_linter_add_vue_valid-define-emits_ branch August 27, 2025 02:08

oxc-bot mentioned this pull request Aug 30, 2025

release(oxlint): v1.14.0 #13416

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

feat(linter): add `vue/valid-define-emits` #12545

feat(linter): add `vue/valid-define-emits` #12545

Uh oh!

Sysix commented Jul 27, 2025 •

edited

Loading

Uh oh!

Sysix commented Jul 27, 2025 •

edited

Loading

Uh oh!

codspeed-hq bot commented Jul 27, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Sysix commented Aug 17, 2025

Uh oh!

Boshen commented Aug 27, 2025 •

edited by graphite-app bot

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

feat(linter): add vue/valid-define-emits #12545

feat(linter): add vue/valid-define-emits #12545

Uh oh!

Conversation

Sysix commented Jul 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Sysix commented Jul 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

How to use the Graphite Merge Queue

Uh oh!

codspeed-hq bot commented Jul 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

CodSpeed Instrumentation Performance Report

Merging #12545 will not alter performance

Summary

Footnotes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Sysix commented Aug 17, 2025

Uh oh!

Boshen commented Aug 27, 2025 • edited by graphite-app bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

feat(linter): add `vue/valid-define-emits` #12545

feat(linter): add `vue/valid-define-emits` #12545

Sysix commented Jul 27, 2025 •

edited

Loading

Sysix commented Jul 27, 2025 •

edited

Loading

codspeed-hq bot commented Jul 27, 2025 •

edited

Loading

Boshen commented Aug 27, 2025 •

edited by graphite-app bot

Loading