Skip to content

Conversation

@Sysix
Copy link
Member

@Sysix Sysix commented Aug 2, 2025

Here we are not aligning every diagnostic to the source text offset. Later we could cross-reference with an extra method push_diagnostic_without_adjustment or something similar.

@github-actions github-actions bot added A-linter Area - Linter C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Aug 2, 2025
Copy link
Member Author

Sysix commented Aug 2, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@codspeed-hq
Copy link

codspeed-hq bot commented Aug 2, 2025

CodSpeed Instrumentation Performance Report

Merging #12769 will not alter performance

Comparing 08-02-refactor_linter_run_linter_with_contextsubhost_ (e871dab) with main (6431033)1

Summary

✅ 34 untouched benchmarks

Footnotes

  1. No successful run was found on main (e871dab) during the generation of this report, so 6431033 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@Sysix Sysix force-pushed the 08-02-refactor_linter_run_linter_with_contextsubhost_ branch 2 times, most recently from b58f99d to 9a5d730 Compare August 3, 2025 12:38
@Sysix Sysix force-pushed the 08-01-refactor_linter_introduce_contextsubhost_for_cross_script_block_analyse branch from 23e3b37 to 646cd76 Compare August 3, 2025 12:38
@Sysix Sysix marked this pull request as ready for review August 3, 2025 15:30
@Sysix Sysix requested a review from camc314 as a code owner August 3, 2025 15:30
@Sysix Sysix force-pushed the 08-01-refactor_linter_introduce_contextsubhost_for_cross_script_block_analyse branch from 646cd76 to f72c007 Compare August 4, 2025 18:01
@Sysix Sysix force-pushed the 08-02-refactor_linter_run_linter_with_contextsubhost_ branch from 9a5d730 to 4fed1ef Compare August 4, 2025 18:01
@Sysix Sysix force-pushed the 08-01-refactor_linter_introduce_contextsubhost_for_cross_script_block_analyse branch from f72c007 to 5f79f25 Compare August 5, 2025 17:59
@Sysix Sysix force-pushed the 08-02-refactor_linter_run_linter_with_contextsubhost_ branch from 4fed1ef to 0b97694 Compare August 5, 2025 17:59
@Sysix Sysix force-pushed the 08-01-refactor_linter_introduce_contextsubhost_for_cross_script_block_analyse branch from 5f79f25 to 81fac36 Compare August 9, 2025 14:56
@Sysix Sysix force-pushed the 08-02-refactor_linter_run_linter_with_contextsubhost_ branch 2 times, most recently from 2724683 to bf34941 Compare August 13, 2025 17:54
@Sysix Sysix force-pushed the 08-01-refactor_linter_introduce_contextsubhost_for_cross_script_block_analyse branch from 81fac36 to d04f456 Compare August 13, 2025 17:54
@Sysix Sysix force-pushed the 08-02-refactor_linter_run_linter_with_contextsubhost_ branch from bf34941 to 2ae79ad Compare August 17, 2025 12:47
@Sysix Sysix force-pushed the 08-01-refactor_linter_introduce_contextsubhost_for_cross_script_block_analyse branch from d04f456 to 3fdf343 Compare August 17, 2025 12:47
@Sysix Sysix force-pushed the 08-02-refactor_linter_run_linter_with_contextsubhost_ branch from 2ae79ad to d7b4ebf Compare August 17, 2025 12:52
@Sysix Sysix force-pushed the 08-02-refactor_linter_run_linter_with_contextsubhost_ branch from d7b4ebf to 9bac168 Compare August 26, 2025 19:34
@Sysix Sysix force-pushed the 08-01-refactor_linter_introduce_contextsubhost_for_cross_script_block_analyse branch from 3fdf343 to 6a32eeb Compare August 26, 2025 19:34
@graphite-app graphite-app bot added the 0-merge Merge with Graphite Merge Queue label Aug 27, 2025
@graphite-app
Copy link
Contributor

graphite-app bot commented Aug 27, 2025

Merge activity

Here we are not aligning every diagnostic to the source text offset. Later we could cross-reference with an extra method `push_diagnostic_without_adjustment` or something similar.
@graphite-app graphite-app bot force-pushed the 08-01-refactor_linter_introduce_contextsubhost_for_cross_script_block_analyse branch from 6a32eeb to 077abdf Compare August 27, 2025 02:02
@graphite-app graphite-app bot force-pushed the 08-02-refactor_linter_run_linter_with_contextsubhost_ branch from 9bac168 to e871dab Compare August 27, 2025 02:03
Base automatically changed from 08-01-refactor_linter_introduce_contextsubhost_for_cross_script_block_analyse to main August 27, 2025 02:06
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Aug 27, 2025
@graphite-app graphite-app bot merged commit e871dab into main Aug 27, 2025
25 checks passed
@graphite-app graphite-app bot deleted the 08-02-refactor_linter_run_linter_with_contextsubhost_ branch August 27, 2025 02:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-linter Area - Linter C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants