Skip to content

refactor(linter): add setup detection for vue files #12541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

refactor(linter): add setup detection for vue files #12541

wants to merge 1 commit into from

Conversation

@Sysix
Copy link
Member

@Sysix Sysix commented Jul 26, 2025 •
edited
Loading

Some Vue ESLint rules are only executed in script / non-script blocks.
valid-define-emits is one rule example.

Defined it as a "general" FrameworkOptions option.
Maybe there are some astro rules which are only applied inside the frontmatter

@github-actions github-actions bot added A-linter Area - Linter C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Jul 26, 2025
@Sysix Graphite App
Copy link
Member Author

Sysix commented Jul 26, 2025 •
edited
Loading

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@codspeed-hq
Copy link

codspeed-hq bot commented Jul 26, 2025 •
edited
Loading

CodSpeed Instrumentation Performance Report

Merging #12541 will not alter performance

Comparing 07-26-refactor_linter_add_setup_detection_for_vue_files (cdf6b57) with main (7c1ff78)

Summary

✅ 34 untouched benchmarks

@Sysix Sysix force-pushed the 07-26-refactor_linter_add_setup_detection_for_vue_files branch from 822407d to 05f6e18 Compare July 26, 2025 20:27
@Sysix Sysix marked this pull request as ready for review July 26, 2025 20:34
@Sysix Sysix requested a review from camc314 as a code owner July 26, 2025 20:34
@Sysix Sysix changed the base branch from main to graphite-base/12541 July 27, 2025 12:04
@Sysix Sysix force-pushed the 07-26-refactor_linter_add_setup_detection_for_vue_files branch from 05f6e18 to 4658fba Compare July 27, 2025 12:04
@Sysix Sysix force-pushed the graphite-base/12541 branch from 94b06ef to be257d8 Compare July 27, 2025 12:04
@Sysix Sysix changed the base branch from graphite-base/12541 to 07-27-chore_rulegen_add_new-vue-rule_just_command July 27, 2025 12:04
This was referenced Jul 27, 2025
Merged
Merged
Merged
@Sysix Sysix force-pushed the 07-26-refactor_linter_add_setup_detection_for_vue_files branch from 4658fba to 8f63297 Compare July 27, 2025 12:05
@Sysix Sysix force-pushed the 07-27-chore_rulegen_add_new-vue-rule_just_command branch from be257d8 to c290eae Compare July 27, 2025 12:05
@camc314 camc314 self-assigned this Jul 27, 2025
@graphite-app graphite-app bot changed the base branch from 07-27-chore_rulegen_add_new-vue-rule_just_command to graphite-base/12541 July 27, 2025 12:29
@graphite-app graphite-app bot force-pushed the graphite-base/12541 branch from c290eae to d3604f9 Compare July 27, 2025 12:37
@graphite-app graphite-app bot force-pushed the 07-26-refactor_linter_add_setup_detection_for_vue_files branch from 8f63297 to 6df5bd5 Compare July 27, 2025 12:37
@graphite-app graphite-app bot changed the base branch from graphite-base/12541 to main July 27, 2025 12:38
@graphite-app graphite-app bot force-pushed the 07-26-refactor_linter_add_setup_detection_for_vue_files branch from 6df5bd5 to 363330d Compare July 27, 2025 12:38
@Sysix Sysix force-pushed the 07-26-refactor_linter_add_setup_detection_for_vue_files branch from 363330d to cb96836 Compare July 28, 2025 18:34
This was referenced Jul 29, 2025
Merged
Merged
@Sysix Sysix force-pushed the 07-26-refactor_linter_add_setup_detection_for_vue_files branch from cb96836 to cdf6b57 Compare July 31, 2025 17:25
@Sysix Sysix marked this pull request as draft August 1, 2025 13:48
@Sysix Sysix mentioned this pull request Aug 1, 2025
Merged
@Sysix Sysix closed this Aug 3, 2025
graphite-app bot pushed a commit that referenced this pull request Aug 27, 2025
@Sysix
refactor(linter): introduce ContextSubHost for cross script block a…
077abdf 
…nalyse (#12724)

Another approach to #12541 stack.
Because `vue/valid-define-emit` and other rules required the semantics of the other script block.

## The Goal:
`Linter.run` should run with the complete file context. In `vue` files and others, there can be multiple Semantics / Module Records.
Because `vue` requires some magic compiler rules, the linter should have access to the complete file.
This will also fix the offset bug in #12758. ~~**Don't** merge both stacks without rebasing.~~

I do not like the loop part. Maybe you guys have some better ideas.

---

<img width="1160" height="422" alt="benchmark results" src="https://github.com/user-attachments/assets/88702a01-eeb2-4a4f-8d80-c5236d3fa8cc" />
@Sysix Sysix deleted the 07-26-refactor_linter_add_setup_detection_for_vue_files branch October 3, 2025 00:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@camc314 camc314 Awaiting requested review from camc314 camc314 is a code owner

Copilot code review Copilot Awaiting requested review from Copilot Copilot will automatically review once the pull request is marked ready for review

Assignees

@camc314 camc314

Labels

A-linter Area - Linter C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Sysix @camc314