Skip to content

Conversation

@Sysix
Copy link
Member

@Sysix Sysix commented May 31, 2025

on hold: first support textdocument/diagnostics:
vscode error report for missing support

@Sysix Sysix changed the title feat(language_server): support workpace/diagnostic feat(language_server): support workspace/diagnostic May 31, 2025
@github-actions github-actions bot added A-editor Area - Editor and Language Server C-enhancement Category - New feature or request labels May 31, 2025
Copy link
Member Author

Sysix commented May 31, 2025

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@codspeed-hq
Copy link

codspeed-hq bot commented May 31, 2025

CodSpeed Instrumentation Performance Report

Merging #11414 will create unknown performance changes

Comparing 05-31-feat_language_server_support_workpace_diagnostic_ (2dff221) with 06-02-feat_language_server_support_textdocument_diagnostic_ (320977c)

Summary

🆕 38 new benchmarks

Benchmarks breakdown

Benchmark BASE HEAD Change
🆕 codegen[RadixUIAdoptionSection.jsx] N/A 132 µs N/A
🆕 codegen[binder.ts] N/A 4.8 ms N/A
🆕 codegen[cal.com.tsx] N/A 38.9 ms N/A
🆕 codegen[react.development.js] N/A 2.2 ms N/A
🆕 formatter[RadixUIAdoptionSection.jsx] N/A 299.7 µs N/A
🆕 formatter[binder.ts] N/A 19.3 ms N/A
🆕 formatter[cal.com.tsx] N/A 150.4 ms N/A
🆕 formatter[react.development.js] N/A 9.5 ms N/A
🆕 lexer[RadixUIAdoptionSection.jsx] N/A 21.1 µs N/A
🆕 lexer[binder.ts] N/A 929.3 µs N/A
🆕 lexer[cal.com.tsx] N/A 5.8 ms N/A
🆕 lexer[react.development.js] N/A 383.8 µs N/A
🆕 linter[RadixUIAdoptionSection.jsx] N/A 2.8 ms N/A
🆕 linter[binder.ts] N/A 149.1 ms N/A
🆕 linter[cal.com.tsx] N/A 1.3 s N/A
🆕 linter[react.development.js] N/A 54.6 ms N/A
🆕 mangler[RadixUIAdoptionSection.jsx] N/A 14.1 µs N/A
🆕 mangler[binder.ts] N/A 797.5 µs N/A
🆕 mangler[cal.com.tsx] N/A 3.5 ms N/A
🆕 mangler[react.development.js] N/A 282.9 µs N/A
... ... ... ... ...

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.

@Sysix Sysix force-pushed the 05-31-refactor_language_server_linter_runtime_returns_fxhashmap_ branch from 7e4b711 to e519d9e Compare May 31, 2025 16:50
@Sysix Sysix force-pushed the 05-31-feat_language_server_support_workpace_diagnostic_ branch 2 times, most recently from be09182 to f752261 Compare June 1, 2025 11:27
@Sysix Sysix force-pushed the 05-31-refactor_language_server_linter_runtime_returns_fxhashmap_ branch from e519d9e to 18dc87f Compare June 1, 2025 11:27
@Sysix Sysix force-pushed the 05-31-feat_language_server_support_workpace_diagnostic_ branch from f752261 to 4e3e59f Compare June 1, 2025 13:38
@Sysix Sysix force-pushed the 05-31-feat_language_server_support_workpace_diagnostic_ branch from 4e3e59f to d384b02 Compare June 2, 2025 17:29
@Sysix Sysix changed the base branch from 05-31-refactor_language_server_linter_runtime_returns_fxhashmap_ to graphite-base/11414 June 2, 2025 17:37
@Sysix Sysix changed the base branch from graphite-base/11414 to 05-31-refactor_language_server_linter_runtime_returns_fxhashmap_ June 2, 2025 17:37
@Sysix Sysix changed the base branch from 05-31-refactor_language_server_linter_runtime_returns_fxhashmap_ to graphite-base/11414 June 2, 2025 17:38
@Sysix Sysix changed the base branch from graphite-base/11414 to 05-31-refactor_language_server_linter_runtime_returns_fxhashmap_ June 2, 2025 17:38
@Sysix Sysix changed the base branch from 05-31-refactor_language_server_linter_runtime_returns_fxhashmap_ to graphite-base/11414 June 2, 2025 17:39
@Sysix Sysix changed the base branch from graphite-base/11414 to 05-31-refactor_language_server_linter_runtime_returns_fxhashmap_ June 2, 2025 17:39
@Sysix Sysix changed the base branch from 05-31-refactor_language_server_linter_runtime_returns_fxhashmap_ to graphite-base/11414 June 2, 2025 17:40
@Sysix Sysix changed the base branch from graphite-base/11414 to 05-31-refactor_language_server_linter_runtime_returns_fxhashmap_ June 2, 2025 17:40
@Sysix Sysix changed the base branch from 05-31-refactor_language_server_linter_runtime_returns_fxhashmap_ to graphite-base/11414 June 2, 2025 17:40
@Sysix Sysix force-pushed the 05-31-feat_language_server_support_workpace_diagnostic_ branch from d384b02 to fd1fc22 Compare June 2, 2025 17:41
@Sysix Sysix force-pushed the graphite-base/11414 branch from 4c0e32f to d0fbfb4 Compare June 2, 2025 17:41
@Sysix Sysix changed the base branch from graphite-base/11414 to 06-02-feat_language_server_support_textdocument_diagnostic_ June 2, 2025 17:41
@Sysix Sysix force-pushed the 06-02-feat_language_server_support_textdocument_diagnostic_ branch from d0fbfb4 to ff92bd2 Compare June 2, 2025 21:13
@Sysix Sysix force-pushed the 05-31-feat_language_server_support_workpace_diagnostic_ branch from fd1fc22 to 1e796d2 Compare June 2, 2025 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-editor Area - Editor and Language Server C-enhancement Category - New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants