-
-
Notifications
You must be signed in to change notification settings - Fork 722
refactor(language_server): introduce helper path_to_uri
#11398
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
CodSpeed Instrumentation Performance ReportMerging #11398 will not alter performanceComparing Summary
|
bb7ded9 to
2ce0659
Compare
6e330d4 to
b1f8e21
Compare
dfdb189 to
d2c136c
Compare
d2c136c to
e7f3100
Compare
b1f8e21 to
e60f616
Compare
e7f3100 to
2414ee9
Compare
e60f616 to
46d0ec0
Compare
2414ee9 to
7708d56
Compare
7708d56 to
512672d
Compare
46d0ec0 to
208f3b4
Compare
208f3b4 to
bbf7107
Compare
512672d to
9f39a1d
Compare

Currently only used for the test. The plan is to convert paths back to URI when we implement workspace wide diagnostics.
The client will not send us URIs, we need to create them on our own.
The current implementation from
Uri::from_file_pathis broken because of the escape characters.I see someone from
tower-lsp-serverwants to implement something similar:tower-lsp-community/tower-lsp-server#46