Skip to content

Conversation

@Sysix
Copy link
Member

@Sysix Sysix commented May 30, 2025

The language server wants to use Walk too when the editor is requesting workspace wide diagnostics.

Copy link
Member Author

Sysix commented May 30, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added A-linter Area - Linter A-cli Area - CLI labels May 30, 2025
@Sysix Sysix changed the title reactor(linter): move Walk from oxlint to oxc_linter with own options struct refactor(linter): move Walk from oxlint to oxc_linter with own options struct May 30, 2025
@github-actions github-actions bot added the C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior label May 30, 2025
@codspeed-hq
Copy link

codspeed-hq bot commented May 30, 2025

CodSpeed Instrumentation Performance Report

Merging #11391 will degrade performances by 4.09%

Comparing 05-30-reactor_linter_move_walk_from_oxlint_to_oxc_linter_with_own_options_struct (bbf7107) with main (ec4fc83)

Summary

❌ 1 regressions
✅ 37 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
mangler[cal.com.tsx] 2.9 ms 3 ms -4.09%

@Sysix Sysix force-pushed the 05-30-reactor_linter_move_walk_from_oxlint_to_oxc_linter_with_own_options_struct branch from 6e330d4 to b1f8e21 Compare May 31, 2025 12:04
@Sysix
Copy link
Member Author

Sysix commented May 31, 2025

Only the first 2 PRs in the stacks are ready. Questioning the bridge between the server and oxc_linter

@Sysix Sysix marked this pull request as ready for review May 31, 2025 16:41
@Sysix Sysix requested a review from camc314 as a code owner May 31, 2025 16:41
@Sysix Sysix force-pushed the 05-30-reactor_linter_move_walk_from_oxlint_to_oxc_linter_with_own_options_struct branch from b1f8e21 to e60f616 Compare May 31, 2025 16:50
@Sysix Sysix force-pushed the 05-30-reactor_linter_move_walk_from_oxlint_to_oxc_linter_with_own_options_struct branch from e60f616 to 46d0ec0 Compare June 2, 2025 17:29
@Sysix Sysix force-pushed the 05-30-reactor_linter_move_walk_from_oxlint_to_oxc_linter_with_own_options_struct branch from 46d0ec0 to 208f3b4 Compare June 2, 2025 17:39
@Sysix Sysix force-pushed the 05-30-reactor_linter_move_walk_from_oxlint_to_oxc_linter_with_own_options_struct branch from 208f3b4 to bbf7107 Compare June 2, 2025 21:18
@Sysix Sysix closed this Jun 3, 2025
@Sysix Sysix deleted the 05-30-reactor_linter_move_walk_from_oxlint_to_oxc_linter_with_own_options_struct branch July 11, 2025 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-cli Area - CLI A-linter Area - Linter C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants