Skip to content

Conversation

@hannesa2
Copy link
Contributor

@hannesa2 hannesa2 commented Feb 9, 2019

Now we can search log. It's helpful to investigate what's happen with a specific file #2394

It's based/depends on #2402 . That's why it's just a preview and needs a merge of AndroidX first.

searchlog

@hannesa2
Copy link
Contributor Author

hannesa2 commented Feb 9, 2019

With additional commit "colorize log" your see colorized

  • errors
  • warnings
  • verbose
  • debug and info are like before to avoid too much ugly colors

image

The color comes only when owncloud/android-library#233 is merged, but it's not mandatory.

Btw, you see immediate some missusages of Log_OC.e(foo)

@hannesa2
Copy link
Contributor Author

hannesa2 commented Feb 10, 2019

Because app crashes and I don't see on my real device what's wrong, I added an option to look into logcat in release version too.
image

Now you can see crashes which are not catched by Log_OC

@hannesa2 hannesa2 force-pushed the SearchLog branch 2 times, most recently from 8d98138 to b893d20 Compare February 10, 2019 21:01
@davigonz davigonz added this to the 2.11.0 milestone Feb 11, 2019
@hannesa2 hannesa2 force-pushed the SearchLog branch 2 times, most recently from a7e1f44 to 0e907eb Compare February 11, 2019 19:07
@davigonz davigonz requested a review from hosy February 13, 2019 11:14
@hannesa2 hannesa2 force-pushed the SearchLog branch 2 times, most recently from 4dd1627 to 334ee42 Compare February 13, 2019 20:32
@hannesa2 hannesa2 changed the title Search log (preview) Search log Feb 13, 2019
@davigonz davigonz self-requested a review February 22, 2019 13:34
@hannesa2
Copy link
Contributor Author

Btw, I encapsulate the functionality to an own repo https://github.com/hannesa2/Logcat
But it's use https://github.com/JakeWharton/timber and log to file with https://github.com/hannesa2/Logcat/blob/master/LogcatLib/src/main/java/info/hannes/timber/FileLoggingTree.kt and makes 'Log_OC.java' obsolete

If you want to go the way to use this lib, please let me know, otherwise I leave PR like it is

@davigonz
Copy link
Contributor

@hannesa2 I requested some changes, can you have a look?

@hannesa2 hannesa2 force-pushed the SearchLog branch 2 times, most recently from 24d8900 to d252055 Compare February 27, 2019 06:30
@jesmrec
Copy link
Collaborator

jesmrec commented Mar 13, 2019

Log Search -> OK
Colorize -> OK
Logcat -> OK

before merging, please update the PR reference to the owncloud-android-library to master where owncloud/android-library#233 is already merged. If not, after merging the current PR will have the library reference outdated.

@jesmrec jesmrec self-requested a review March 13, 2019 11:45
@hannesa2
Copy link
Contributor Author

done

@jesmrec
Copy link
Collaborator

jesmrec commented Mar 14, 2019

#2442 outdated this one. New rebase and will be merged.

@hannesa2
Copy link
Contributor Author

and again

@michaelstingl michaelstingl merged commit cec2f37 into owncloud:master Mar 14, 2019
@michaelstingl
Copy link
Contributor

and again

I understand, this is annoying. @jesmrec proposed to change how the Transifex pushes work. We'll check and improve here.

@hannesa2
Copy link
Contributor Author

hannesa2 commented Mar 14, 2019

@michaelstingl thank you to see the issue
An other way could be to change the git flow eg #2359 (comment)

@hannesa2 hannesa2 deleted the SearchLog branch March 14, 2019 08:22
@hannesa2
Copy link
Contributor Author

@michaelstingl
Interesting, this rebase policy is not valid for everyone

image

This is not bad, it just just helps me, to see my position

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants