auto upload of pictures is broken

[hannesa2]

With the current version, it seems the auto sync of pictures is broken. On my device there was nothing synced since months

[hannesa2]

I did a test on a real device from 15:05 till 18:55

Problem A:

It seems CameraUploadsSyncJobService does not start

adb pull /storage/emulated/0/owncloud/log/currentLog.txt .
cat currentLog.txt |grep CameraUploadsSyncJobService

2018/12/08 15:03:20 CameraUploadsHandler : Scheduling a CameraUploadsSyncJobService
2018/12/08 15:03:38 CameraUploadsHandler : Scheduling a CameraUploadsSyncJobService
2018/12/08 15:03:45 CameraUploadsHandler : Scheduling a CameraUploadsSyncJobService
2018/12/08 15:03:50 CameraUploadsHandler : Scheduling a CameraUploadsSyncJobService
2018/12/08 15:05:40 CameraUploadsHandler : Scheduling a CameraUploadsSyncJobService

Looks like L53 is never reached

Problem B:

Last entry at 15:47:47. After this time app seems to stop doing anything in background. No Job started, nothing

Problem C:

I see a lot of actions in background, but server directory Kamera-Upload has still only one file instead if > 800 files

status:UPLOAD_FAILED and result:NETWORK_CONNECTION
Socket timeout exception Exception
UPLOAD_IN_PROGRESS and result:UNKNOWN
updateCameraUploadSync returns with: 1
Unrecovered transport exception Exception

Does someone understand what's going on. Here is the complete log
currentLog.txt

[jesmrec]

Thanks a lot for reporting. We have had some issues of people who automatic uploads do not work for them. I guess you selected the correct source folder. We will have a look.

[davigonz]

Thanks for reporting this @hannesa2, in the currentLog.txt you attach I see several logs saying Scheduling a CameraUploadsSyncJobService in different hours but there's no 15 minutes wait.

2018/12/08 15:03:20 CameraUploadsHandler : Scheduling a CameraUploadsSyncJobService 2018/12/08 15:03:38 CameraUploadsHandler : Scheduling a CameraUploadsSyncJobService 2018/12/08 15:03:45 CameraUploadsHandler : Scheduling a CameraUploadsSyncJobService 2018/12/08 15:03:50 CameraUploadsHandler : Scheduling a CameraUploadsSyncJobService 2018/12/08 15:05:40 CameraUploadsHandler : Scheduling a CameraUploadsSyncJobService

If the CameraUploadsSyncJobService is scheduled at 15:03, the job execution should start approximately at 15:18, do you have more logs to see what's going on at that time? Thanks

[hannesa2]

Sorry, that was the only detected log file. If there are more, please tell me.
Or should we add more places to log, or add additional info ?

Btw, such lines 2018/12/08 15:03:20 CameraUploadsHandler : Scheduling a CameraUploadsSyncJobService I modified manually, because timestamp is in separate line. What's the purpose of it ? I recommend to have it in one line, maybe with method name and line number.
I could make a PR to do so, at least for time and log in one line

[hannesa2]

In my point of view, this issue has very high (or highest) priority.
But I can't fix, because my real device has loose connection and on Emulator I do no picture make.
@davigonz I guess you are the right person, at least the code lines have your name

[davigonz]

Or should we add more places to log, or add additional info ?

Please @hannesa2 , try to get more logs, I would need to see at least a period of 15 minutes in your log since you enable CameraUploads feature to see what's going on there.

In my point of view, this issue has very high (or highest) priority.
But I can't fix, because my real device has loose connection and on Emulator I do no picture make.
@davigonz I guess you are the right person, at least the code lines have your name

Before fixing something, first we need to reproduce it and this is not the case.

[hannesa2]

It would be nice to have this owncloud/android-library#225 to have a more easy investigation

[hannesa2]

"Before fixing something, first we need to reproduce it and this is not the case." ... I can do it on my wife's and my device. Pixel and Pixel 2 both with Android P.

It looks like this created before period to check, ignoring prevents the upload.

android/owncloudApp/src/main/java/com/owncloud/android/files/services/CameraUploadsSyncJobService.java

Line 188 in 415f88f

if (isImage && localFile.lastModified() <= mOCCameraUploadSync.getPicturesLastSync() ||

I didn't invented it, so I didn't know exactly the purpose of OCCameraUploadSync.
Please have a look ! @davigonz
This male function causes all my PRs and has for me the highest prio !
And because of the merge velocity, I made my private release which is ahead of upstream master https://github.com/hannesa2/owncloud-android/releases

Here are the logs
olderLog.txt
currentLog.txt

[davigonz]

I can do it on my wife's and my device. Pixel and Pixel 2 both with Android P.
I didn't invented it, so I didn't know exactly the purpose of OCCameraUploadSync.

@hannesa2 we have to reproduce it in our side so we can fix and properly test it, I'm not saying you invented it, I trust you.

It looks like this created before period to check, ignoring prevents the upload.
I didn't know exactly the purpose of OCCameraUploadSync.

Camera uploads feature, as ...whatever.jpg created before period to check said in your currentLog.txt, does not upload pictures taken or videos recorded before enabling the feature, there's a warning message about that when you enable the feature as well.

For example, if you take some pictures at 11:30 and you enable Camera uploads at 12:00, those pictures won't be uploaded, just those taken after 12:00.

That's the main aim of using OCCameraUploadSync, apart from preventing to upload duplicated files when CameraUploadsSyncJobService is executed every 15 minutes. In other words, is a timestamp from which the pictures/videos taken should be uploaded.

And because of the merge velocity, I made my private release which is ahead of upstream master

If you want to contribute with some of the features of that private release, please open PR and we will review it.

[hannesa2]

For example, if you take some pictures at 11:30 and you enable Camera uploads at 12:00, those pictures won't be uploaded, just those taken after 12:00.

And how to enable to sync my older, not synced files ?
Btw in 2018 Ownclud only synced 4 files !

[hannesa2]

Android camera view, these are just the last ...

here I can scroll down and see tons of other picture

In Owncloud:

This is ALL

You see just four !

[davigonz]

@hannesa2 what I see in the logs and taking into account the photos you have, if Camera uploads feature detects /storage/emulated/0/DCIM/Camera/IMG_20181228_144728_1.jpg as created before period to check is because it should have uploaded a picture created after that moment, have a look at https://github.com/owncloud/android/blob/master/owncloudApp/src/main/java/com/owncloud/android/files/services/CameraUploadsSyncJobService.java#L207, is executed after requesting a new upload and there's no photo in your Kamera-Upload folder after 28/12/2018 at at 14:47:28. This is a bit weird.

There's more ways to update that timestamp:

• When disabling and enabling again the Camera uploads feature, e.g. uncheck + check again in Settings menu => https://github.com/owncloud/android/blob/master/owncloudApp/src/main/java/com/owncloud/android/ui/activity/Preferences.java#L517
• When changing the source path in which to check the pictures/videos to upload => https://github.com/owncloud/android/blob/master/owncloudApp/src/main/java/com/owncloud/android/ui/activity/Preferences.java#L651

Have you performed any of those actions? Thanks