remove Lint errors #2442
Merged
remove Lint errors #2442
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hannesa2
force-pushed
the
RemoveLintErrors
branch
from
98138d5 to
020cdaf
Compare
hannesa2
force-pushed
the
RemoveLintErrors
branch
3 times, most recently
from
b85f08e to
bf5ab94
Compare
hannesa2
force-pushed
the
RemoveLintErrors
branch
from
bf5ab94 to
e98d064
Compare
davigonz
approved these changes
Feb 26, 2019
Contributor
|
@hannesa2 the code looks good to me but Android Studio Lint looks a bit different to your screenshot and it still shows some errors. Are you using a custom Lint o something like that? |
Contributor
Author
|
This lint has often a delay. Please do a clean/build and wait till lint scan all files in background. This background has sometime a delay |
hannesa2
force-pushed
the
RemoveLintErrors
branch
2 times, most recently
from
1bf0603 to
b581181
Compare
hannesa2
force-pushed
the
RemoveLintErrors
branch
2 times, most recently
from
5ff9a3c to
204ace4
Compare
jesmrec
approved these changes
Mar 13, 2019
Collaborator
|
Approved. @hannesa2, you know how to do now |
hannesa2
force-pushed
the
RemoveLintErrors
branch
from
204ace4 to
8779d12
Compare
Contributor
Author
|
done |
Collaborator
|
Transifex pushed before... we need another try. |
hannesa2
force-pushed
the
RemoveLintErrors
branch
from
8779d12 to
271db97
Compare
Contributor
Author
|
done But the second request I don't found. But I rebased the second too
|
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's related to #2441, most of the lints are now removed.
eg:
Still open :