Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix an equality check #3399

Merged
merged 1 commit into from
Feb 20, 2024
Merged

Fix an equality check #3399

merged 1 commit into from
Feb 20, 2024

Conversation

joschmitt
Copy link
Member

Replace an == by an ===. The == actually tries to do math and is super slow.

@thofma thofma added the backport 1.0.x Should be backported to the release 1.0 branch label Feb 20, 2024
@thofma
Copy link
Collaborator

thofma commented Feb 20, 2024

Adding backport label, since we need this for some upcoming OSCAR article.

@joschmitt
Copy link
Member Author

I have no idea why this one doctest fails...

Copy link

codecov bot commented Feb 20, 2024

Codecov Report

Merging #3399 (37aae65) into master (a73b844) will decrease coverage by 0.01%.
Report is 1 commits behind head on master.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3399      +/-   ##
==========================================
- Coverage   82.10%   82.10%   -0.01%     
==========================================
  Files         557      557              
  Lines       73971    73971              
==========================================
- Hits        60734    60733       -1     
- Misses      13237    13238       +1     
Files Coverage Δ
src/Rings/MPolyQuo.jl 93.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

@thofma thofma merged commit 6408748 into oscar-system:master Feb 20, 2024
23 checks passed
@joschmitt joschmitt deleted the js/fixequal branch February 21, 2024 07:55
benlorenz pushed a commit that referenced this pull request Feb 21, 2024
@benlorenz benlorenz mentioned this pull request Feb 21, 2024
33 tasks
@benlorenz benlorenz removed the backport 1.0.x Should be backported to the release 1.0 branch label Feb 21, 2024
benlorenz added a commit that referenced this pull request Feb 23, 2024
### Backported PRs

- [x] #3367
- [x] #3379 
- [x] #3369
- [x] #3291
- [x] #3325
- [x] #3350 
- [x] #3351
- [x] #3365 
- [x] #3366
- [x] #3382
- [x] #3373
- [x] #3341
- [x] #3346
- [x] #3381
- [x] #3385
- [x] #3387 
- [x] #3398 
- [x] #3399 
- [x] #3374 
- [x] #3406 
- [x] #2823
- [x] #3298
- [x] #3386 
- [x] #3412 
- [x] #3392 
- [x] #3415 
- [x] #3394
- [x] #3391
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants