Adv/upgrade regression fix #3325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #3325 +/- ##
===========================================
+ Coverage 57.57% 81.73% +24.16%
===========================================
Files 543 556 +13
Lines 72784 74107 +1323
===========================================
+ Hits 41904 60574 +18670
+ Misses 30880 13533 -17347
|
|
Who should review this? |
1 similar comment
|
Who should review this? |
@benlorenz looked at it this week, and we decided we wanted to pretty print |
benlorenz
approved these changes
Feb 16, 2024
|
OK, then just merge at your own discretion. |
|
backport? |
antonydellavecchia
added
the
backport 1.0.x
benlorenz
pushed a commit
that referenced
this pull request
Feb 19, 2024
* some debuggging * add fix to upgrade tests, and fix code regression * updates johnson matrices, and always adds the refs to s.refs
benlorenz
removed
the
backport 1.0.x
benlorenz
added a commit
that referenced
this pull request
Feb 23, 2024
### Backported PRs - [x] #3367 - [x] #3379 - [x] #3369 - [x] #3291 - [x] #3325 - [x] #3350 - [x] #3351 - [x] #3365 - [x] #3366 - [x] #3382 - [x] #3373 - [x] #3341 - [x] #3346 - [x] #3381 - [x] #3385 - [x] #3387 - [x] #3398 - [x] #3399 - [x] #3374 - [x] #3406 - [x] #2823 - [x] #3298 - [x] #3386 - [x] #3412 - [x] #3392 - [x] #3415 - [x] #3394 - [x] #3391
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a regression in the upgrade script, and fixes test for upgrades that allowed said regression.
Also adds comment in error message when trying to serialize an unsupported type.