-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adv/upgrade regression fix #3325
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #3325 +/- ##
===========================================
+ Coverage 57.57% 81.73% +24.16%
===========================================
Files 543 556 +13
Lines 72784 74107 +1323
===========================================
+ Hits 41904 60574 +18670
+ Misses 30880 13533 -17347
|
Who should review this? |
1 similar comment
Who should review this? |
@benlorenz looked at it this week, and we decided we wanted to pretty print |
OK, then just merge at your own discretion. |
backport? |
* some debuggging * add fix to upgrade tests, and fix code regression * updates johnson matrices, and always adds the refs to s.refs
### Backported PRs - [x] #3367 - [x] #3379 - [x] #3369 - [x] #3291 - [x] #3325 - [x] #3350 - [x] #3351 - [x] #3365 - [x] #3366 - [x] #3382 - [x] #3373 - [x] #3341 - [x] #3346 - [x] #3381 - [x] #3385 - [x] #3387 - [x] #3398 - [x] #3399 - [x] #3374 - [x] #3406 - [x] #2823 - [x] #3298 - [x] #3386 - [x] #3412 - [x] #3392 - [x] #3415 - [x] #3394 - [x] #3391
Fixes a regression in the upgrade script, and fixes test for upgrades that allowed said regression.
Also adds comment in error message when trying to serialize an unsupported type.