-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
QuadFormAndIsom
: fixes and a new feature
#3394
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…primitive embeddings
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #3394 +/- ##
==========================================
- Coverage 82.08% 81.96% -0.12%
==========================================
Files 557 557
Lines 73971 74034 +63
==========================================
- Hits 60716 60685 -31
- Misses 13255 13349 +94
|
@@ -2000,3 +2038,49 @@ function _glue_stabilizers(phi::TorQuadModuleMap, | |||
unique!(stab) | |||
return disc, stab | |||
end | |||
|
|||
function _glue_stabilizers(L::ZZLatWithIsom, M::ZZLatWithIsom, N::ZZLatWithIsom; subM::Bool = true, subN::Bool = true) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please document what this function computes (even though it is internal)
simonbrandhorst
approved these changes
Feb 22, 2024
benlorenz
added
the
backport 1.0.x
Should be backported to the release 1.0 branch
label
Feb 23, 2024
benlorenz
pushed a commit
that referenced
this pull request
Feb 23, 2024
(cherry picked from commit 376b3f0)
benlorenz
removed
the
backport 1.0.x
Should be backported to the release 1.0 branch
label
Feb 23, 2024
benlorenz
added a commit
that referenced
this pull request
Feb 23, 2024
### Backported PRs - [x] #3367 - [x] #3379 - [x] #3369 - [x] #3291 - [x] #3325 - [x] #3350 - [x] #3351 - [x] #3365 - [x] #3366 - [x] #3382 - [x] #3373 - [x] #3341 - [x] #3346 - [x] #3381 - [x] #3385 - [x] #3387 - [x] #3398 - [x] #3399 - [x] #3374 - [x] #3406 - [x] #2823 - [x] #3298 - [x] #3386 - [x] #3412 - [x] #3392 - [x] #3415 - [x] #3394 - [x] #3391
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes:
_glue_stabilizers
to avoid duplicate codeNew feature: