Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QuadFormAndIsom: fixes and a new feature #3394

Merged
merged 15 commits into from
Feb 22, 2024

Conversation

StevellM
Copy link
Member

Fixes:

  • Last fixes on enumeration of finite isometries
  • Fixes on Nikulin's primitive embeddings
  • Broaden _glue_stabilizers to avoid duplicate code
  • Correct obvious typos

New feature:

  • Enumeration of isometries of infinite order with irreducible minimal polynomial

Copy link

codecov bot commented Feb 21, 2024

Codecov Report

Merging #3394 (c6d9624) into master (56b8182) will decrease coverage by 0.12%.
Report is 6 commits behind head on master.
The diff coverage is 68.47%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3394      +/-   ##
==========================================
- Coverage   82.08%   81.96%   -0.12%     
==========================================
  Files         557      557              
  Lines       73971    74034      +63     
==========================================
- Hits        60716    60685      -31     
- Misses      13255    13349      +94     
Files Coverage Δ
...ntal/QuadFormAndIsom/src/lattices_with_isometry.jl 99.44% <100.00%> (-0.04%) ⬇️
...mental/QuadFormAndIsom/src/spaces_with_isometry.jl 98.48% <ø> (ø)
experimental/QuadFormAndIsom/test/runtests.jl 100.00% <100.00%> (ø)
experimental/QuadFormAndIsom/src/enumeration.jl 96.62% <96.55%> (+1.81%) ⬆️
experimental/QuadFormAndIsom/src/embeddings.jl 96.38% <88.88%> (-0.24%) ⬇️
.../QuadFormAndIsom/src/hermitian_miranda_morrison.jl 47.28% <12.79%> (-25.43%) ⬇️

... and 2 files with indirect coverage changes

@@ -2000,3 +2038,49 @@ function _glue_stabilizers(phi::TorQuadModuleMap,
unique!(stab)
return disc, stab
end

function _glue_stabilizers(L::ZZLatWithIsom, M::ZZLatWithIsom, N::ZZLatWithIsom; subM::Bool = true, subN::Bool = true)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please document what this function computes (even though it is internal)

@simonbrandhorst simonbrandhorst merged commit 376b3f0 into oscar-system:master Feb 22, 2024
20 checks passed
@benlorenz benlorenz added the backport 1.0.x Should be backported to the release 1.0 branch label Feb 23, 2024
benlorenz pushed a commit that referenced this pull request Feb 23, 2024
@benlorenz benlorenz mentioned this pull request Feb 23, 2024
33 tasks
@benlorenz benlorenz removed the backport 1.0.x Should be backported to the release 1.0 branch label Feb 23, 2024
benlorenz added a commit that referenced this pull request Feb 23, 2024
### Backported PRs

- [x] #3367
- [x] #3379 
- [x] #3369
- [x] #3291
- [x] #3325
- [x] #3350 
- [x] #3351
- [x] #3365 
- [x] #3366
- [x] #3382
- [x] #3373
- [x] #3341
- [x] #3346
- [x] #3381
- [x] #3385
- [x] #3387 
- [x] #3398 
- [x] #3399 
- [x] #3374 
- [x] #3406 
- [x] #2823
- [x] #3298
- [x] #3386 
- [x] #3412 
- [x] #3392 
- [x] #3415 
- [x] #3394
- [x] #3391
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants