Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump dependencies #2796

Merged
merged 6 commits into from
Sep 14, 2023
Merged

Bump dependencies #2796

merged 6 commits into from
Sep 14, 2023

Conversation

lgoettgens
Copy link
Member

@lgoettgens lgoettgens commented Sep 13, 2023

This prepares Oscar for the breaking releases of AbstractAlgebra v0.32.0, Nemo v0.36.0, and Hecke v0.21.0.

cc @thofma @fingolfin

@thofma thofma marked this pull request as ready for review September 14, 2023 12:14
@thofma thofma closed this Sep 14, 2023
@thofma thofma reopened this Sep 14, 2023
@lgoettgens
Copy link
Member Author

The CI job reports:

Invalidations on default branch: 1823 (1823 via deps)
This branch: 1826 (1826 via deps)

This low increase seems to be okay for the large amount of stuff moved from Nemo to AA.

@thofma
Copy link
Collaborator

thofma commented Sep 14, 2023

This is just Nemocas/AbstractAlgebra.jl#1436

@codecov
Copy link

codecov bot commented Sep 14, 2023

Codecov Report

Merging #2796 (3acf034) into master (ebee98c) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2796      +/-   ##
==========================================
- Coverage   73.61%   73.60%   -0.01%     
==========================================
  Files         455      455              
  Lines       64469    64466       -3     
==========================================
- Hits        47459    47452       -7     
- Misses      17010    17014       +4     
Files Changed Coverage
experimental/GModule/GModule.jl ø
experimental/Matrix/matrix.jl ø
...ntal/QuadFormAndIsom/src/lattices_with_isometry.jl ø
...mental/QuadFormAndIsom/src/spaces_with_isometry.jl ø
experimental/Schemes/AlgebraicCycles.jl ø
experimental/Schemes/CartierDivisor.jl ø
experimental/Schemes/WeilDivisor.jl ø
...ometry/Schemes/AffineSchemes/Objects/Attributes.jl ø
...ry/Schemes/ProjectiveSchemes/Objects/Attributes.jl ø
.../ToricVarieties/NormalToricVarieties/attributes.jl ø
... and 7 more

@thofma thofma merged commit 6d73925 into master Sep 14, 2023
14 of 28 checks passed
@thofma thofma deleted the lg/bump-deps branch September 14, 2023 20:42
fieker pushed a commit that referenced this pull request Sep 29, 2023
* Bump compats

* Remove functions moved to Nemo (Nemocas/Nemo.jl#1519)

* Fix `ZZ` printing (Nemocas/Nemo.jl#1506)

* Fix `identity_map` docstrings (Nemocas/AbstractAlgebra.jl#1431)

* Fix `PosInf` docstring (Nemocas/Nemo.jl#1528)

* Adapt doctests to new printing for maps Nemocas/AbstractAlgebra.jl#1424
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants